Received-SPF: pass (google.com: domain of linux-kernel+bounces-165711-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 1 May 2024 12:28:39 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: Tom Lendacky <thomas.lendacky@amd.com>, Dan Williams
	<dan.j.williams@intel.com>, <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
	<linux-coco@lists.linux.dev>, <svsm-devel@coconut-svsm.dev>
CC: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Andy Lutomirski <luto@kernel.org>, "Peter
 Zijlstra" <peterz@infradead.org>, Michael Roth <michael.roth@amd.com>,
	"Ashish Kalra" <ashish.kalra@amd.com>
Subject: Re: [PATCH v4 13/15] x86/sev: Take advantage of configfs visibility
 support in TSM
Message-ID: <663297e7cbdee_1384629418@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <cover.1713974291.git.thomas.lendacky@amd.com>
 <e3143c1f3d0b26fcd8884c6f75644b634a7138e8.1713974291.git.thomas.lendacky@amd.com>
 <662c239680842_b6e02944b@dwillia2-mobl3.amr.corp.intel.com.notmuch>
 <f6af3a35-7ddd-7f56-d7d9-34c77647614d@amd.com>
 <33620512-a456-aa87-25d3-e15f2d3d256f@amd.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <33620512-a456-aa87-25d3-e15f2d3d256f@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?c+JPi0/MUFh8tryxgKyC66VjULkClVQy5MTCIVavVnOb5gnWR93r/K1eFr?=
 =?iso-8859-1?Q?ev28lZx+1Bp5S51iYbwHnZkSFqb168VDAHURItk+tA9kdoXZhoWTA2Zq+0?=
 =?iso-8859-1?Q?RwUS7stUG3PUjj/s9cLm3CaTjzrUmK/H8Y27TxSVim8YuzHauDLq5XKDXC?=
 =?iso-8859-1?Q?gHQJp3h56pYdW+dtCQfw1E5GKm8pPk87P7Kx0IoeWjyFR5dlNzUXvKpOEE?=
 =?iso-8859-1?Q?FpcYCDYqQzyFzToHg8J6a4tbKYXhxZb9wVPl3Yzww1gZadx/V5dXX8ROOK?=
 =?iso-8859-1?Q?9NwN4n5459xern2IilI8Vq0XArC5vNtY0mIwk5psVQx3YfLYIWGOSlUW3O?=
 =?iso-8859-1?Q?cxMjWiGVYy2LJWVTmypc4dHV4ulZkZIICGgHVc/4VQB3pSzPSbSOolG0YK?=
 =?iso-8859-1?Q?zCH95oxRqfVACi6CZ2XZsav0t8v7OaQynqRY1He0VFy5FqBWdElHXRnOcK?=
 =?iso-8859-1?Q?HLeZ1mlbfRYj56cbkXxIqwCif6GF2WTB3K06tJ4tWQshpemZKa23l3uRqA?=
 =?iso-8859-1?Q?+T6zs6IzRp5x/L9l/cqmkQYi3V5u3SfbRrAI/vH26a2FiddAuqFOekcb6s?=
 =?iso-8859-1?Q?t9XHOqrRdqwVVLUtEgm8hkkSTMsuhA2wBj9WaHzV8FIBpthFe6jdUamCgq?=
 =?iso-8859-1?Q?5CmWc6FSwXeCLF5gs60SUK+hgyH2CEGC9TN6mQZpUFjVju1DH7HrWQ/klm?=
 =?iso-8859-1?Q?DmhGeQOZiU6GnffvA3+xw6SRsXT6AHUns+N/VWKROVNBSIjWAyTau8hQI1?=
 =?iso-8859-1?Q?IzF2QvD2/fs9D/5HWNnUm1KIeJedUrhl7mH1qXdy9YA3UanTLHDt5ea4zZ?=
 =?iso-8859-1?Q?qUda6sFzak6JnMRvGJD+YwXguIrz9wr97lUE+4XRDnvGZX30geE67pOc7N?=
 =?iso-8859-1?Q?Hte8TzOIzKyr2KLgsc+UzIS3DeG2BjNv7YJutZcCq+LSi5+3s+WexhU6Xh?=
 =?iso-8859-1?Q?BP/nkuFdscxCJaGX6++KpFp18L0LOHU93EFC5yBM+AS9wBSRMJr5DWagAX?=
 =?iso-8859-1?Q?n7y1GYFKWq9rMqzMhGSDQgfl+z5CJKoy4WWgP3m+TzdILF/SWDAB504cI+?=
 =?iso-8859-1?Q?jHVCGBTqjZt8p6MFufKYvpFFY/4NbeML3NzcVoigmMRZh3OzIkxV9CM8HC?=
 =?iso-8859-1?Q?ZBa7sBIFVNU8++RvlhAFUdORiMaitEHRT6Yo/agZ/liCZeCJUmd/wm3RqE?=
 =?iso-8859-1?Q?dAiItZ8VmEBEY4zvIXyUTG0A0y5ZRcf83ooDe/gXyFOAjT+FJ+lyEI7dFu?=
 =?iso-8859-1?Q?wpAQtnCaOwI3vDxHOhEWxHFletJWL0gajr2UW0lkDsvoUnzW8pu1FwNVJX?=
 =?iso-8859-1?Q?zoyjNwLyxw+U0oZfkJjucrsZeKXOGnsfeHV4x9WH7Ef0b5nlg9keM532eI?=
 =?iso-8859-1?Q?DDD56LXgNJpc3abkW+9nzsKtikGWjLCcap2vQ9SihYPU3zezKiJm9gV1Wx?=
 =?iso-8859-1?Q?FDSDAQL0Rh0Z6B9QGLsswznPCLVefkYXJnshZumFjXsG0XG0XtE6KVA5Yz?=
 =?iso-8859-1?Q?IhfAntXnZaORu3rn0XzYD2RxojoJQ0sOEd+zZVYva9z827M8ql0QXF7fbr?=
 =?iso-8859-1?Q?6bfOWKfn672kAheHIkYmv08MwGlyXBRi25veLeZK8UYfPf9W97Uhhlc/2a?=
 =?iso-8859-1?Q?dHe8bs0YhtxkzKY2K0f5qv8WpJkL90KaAyOybkkJL0A6hqYWCAh5hoRQ?=
 =?iso-8859-1?Q?=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 40cb1f40-c448-42ea-3d74-08dc6a14e93f
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2024 19:28:42.6891
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qaf5tduUmCmEwyjl2B+4xEBtlTZ+Zrnl5lC1uF9n4lNbYpFDEGdC9y6adaroOJAOTqc/ju6wXXqVQ+xELQwo7lYbe+IGfQOmsEYYCBcvDbU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5882
X-OriginatorOrg: intel.com

Tom Lendacky wrote:
[..]
> >>> +static bool tsm_report_is_visible(struct config_item *item,
> >>> +????????????????? struct configfs_attribute *attr, int n)
> >>
> >> Per the comment on where to find the is_visible() callbacks for a given
> >> item type, I expect the need to pass @item here goes away when this can
> >> assume that there is only one way to have is_visible() invoked for
> >> @attr, right?
> > 
> > Yes.
> 
> But as I look closer, there is only a single ops callback pair 
> (is_visible() and is_bin_visible()), so as long there is never another 
> group / subdir defined under the TSM report, this works. But if another 
> group is added, then the item parameter would likely be needed or the 
> ops callback would have to be updated to differentiate for the vendor 
> (SNP/TDX).

Makes sense, for the tsm_report_is_visible() signature. Especially as
this is proposed as a generic configfs facility. It has symmetry with
sysfs that passes an @kobj parent anchor, to sysfs is_visible()
callbacks.

However, I still think neither @item nor @attr need to be passed down
from tsm_report_is_visible() to the vendor backend. Those can be added
when/if another item type is added, which I do not see on the horizon.