Received-SPF: pass (google.com: domain of linux-kernel+bounces-165844-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 1 May 2024 16:23:52 -0700
From: Roman Gushchin <roman.gushchin@linux.dev>
To: Shakeel Butt <shakeel.butt@linux.dev>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@kernel.org>,
	Muchun Song <muchun.song@linux.dev>,
	Yosry Ahmed <yosryahmed@google.com>,
	"T . J . Mercier" <tjmercier@google.com>, kernel-team@meta.com,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 8/8] memcg: use proper type for mod_memcg_state
Message-ID: <ZjLPCE1F5oH91sHU@P9FQF9L96D>
References: <20240501172617.678560-1-shakeel.butt@linux.dev>
 <20240501172617.678560-9-shakeel.butt@linux.dev>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240501172617.678560-9-shakeel.butt@linux.dev>

On Wed, May 01, 2024 at 10:26:17AM -0700, Shakeel Butt wrote:
> The memcg stats update functions can take arbitrary integer but the
> only input which make sense is enum memcg_stat_item and we don't
> want these functions to be called with arbitrary integer, so replace
> the parameter type with enum memcg_stat_item and compiler will be able
> to warn if memcg stat update functions are called with incorrect index
> value.
> 
> Signed-off-by: Shakeel Butt <shakeel.butt@linux.dev>
> Reviewed-by: T.J. Mercier <tjmercier@google.com>

Reviewed-by: Roman Gushchin <roman.gushchin@linux.dev>

Thanks!