Received-SPF: pass (google.com: domain of linux-kernel+bounces-165862-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Peng Fan <peng.fan@nxp.com>
To: Cristian Marussi <cristian.marussi@arm.com>, "Peng Fan (OSS)"
	<peng.fan@oss.nxp.com>
CC: "sudeep.holla@arm.com" <sudeep.holla@arm.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH V2] firmware: arm_scmi: power_control: support suspend
 command
Thread-Topic: [PATCH V2] firmware: arm_scmi: power_control: support suspend
 command
Thread-Index: AQHamT+2kPkNNu1tdEe0xkM7CL1Pt7GCZrYAgACrLSA=
Date: Wed, 1 May 2024 23:52:52 +0000
Message-ID:
 <DU0PR04MB9417117051682D9BC5B195D988192@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20240428075105.2187837-1-peng.fan@oss.nxp.com>
 <ZjJFLag-0ei0a3xM@pluto>
In-Reply-To: <ZjJFLag-0ei0a3xM@pluto>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?OXCgMstgoQHMX3zzrLGNq3I5yeHUr0KZAL2jQfSeL2BoamI61f9rrccx8JSi?=
 =?us-ascii?Q?xeWl0d0MIVXKJJt44Sv1Z0fcpJNLvcoMV0QZbXvS0VzmTEsxOdbelAzOAYPk?=
 =?us-ascii?Q?rscR1B31Tc2RIZrvQOa5Y8kXuGX1Q0NoVlf89qsxq3GDtYS7Uga04Rhe7wbi?=
 =?us-ascii?Q?ZrsNc6JnARnn1qbxuvUSyRjO8+SmXgZSvGL+VFGqUKx/qDjeXfPEkLriZ49b?=
 =?us-ascii?Q?jK71D7Uo59/ZxUeAzVYmkjOk1tBL5bdnm1iX0YTeq2bH0S02Ka3SnPve9ikX?=
 =?us-ascii?Q?0z9UbExu/ljK+bs9UptKgSxHOtL8KVmfAr/iYYtxOFCIYmKHcxxE5t8u+oDJ?=
 =?us-ascii?Q?CUoPe+wL8U4+e40Uc69ehNO7YNAHmJIjumevcrrTu+qZP1NOXGIqjoCl3i/8?=
 =?us-ascii?Q?d013qDKdm+qQQJnB6151WwvyWfN3gH4VNHYDTgTwsZ2RPse3pPUI7xNe4shR?=
 =?us-ascii?Q?NImBUAzyaEleJ3exU2jJBzOhNPlb5OnvTk5qJfsaOPk9Wa5MID8D3SyOM8yX?=
 =?us-ascii?Q?oci3AkVrKqvE0+ljmYq+q9/RhSJ62uRrfcxDWrRyTyoxNjzyfEiI7qHTotB/?=
 =?us-ascii?Q?0ZvXhbdTbhLumIbxiTA4Vcf9or5fHj/AzQQirS5LXdCI3oB0ORlZly4eJpJs?=
 =?us-ascii?Q?tfKxwIwyy7jLX9kDvOZCPP+aR/MOVoYxc9sfO/aKfDQJ1hdJAlqGIxFyp1OW?=
 =?us-ascii?Q?V9uymnWAYp8rmSKyo/TL2eIyNsJsSFApzdanF1uZnlJrh3slox/uuQr1myYB?=
 =?us-ascii?Q?MiI6nprKP0IaaFp+xdS3/W2HRFdyTgLRKSJSZPuViT3kF8qb1XuG09DG6bRb?=
 =?us-ascii?Q?cWmgICuJCwOuJlWfuHDPvkqdUeuEiE7e9H+nVljfOBNMJBLc7boSJQytqzu4?=
 =?us-ascii?Q?NTA1vR654thYR7ede3Iz/omOTJp5Tw8ZgP+29oxLX73P8Nzci23DZcVmLRb3?=
 =?us-ascii?Q?w4TQR/Dv+tDLjqtgBgEwa5dG+rhPDuAd0vJANxk3nh4FliEQBmt1fQAXN6Xq?=
 =?us-ascii?Q?qbupPpiJ3HnuX90LOobUP67w5IfFQty6eJHlzxwEVnqPBBrL9U7KrugM+sqA?=
 =?us-ascii?Q?VAf/CaYVDNy7WpV7LPiwMF1J1Z2wMsYwGMlKii8kbl0RShq4jm2yBePLgRHk?=
 =?us-ascii?Q?yHyMoYqquIkX0dykS2DjVmdneBhdDhJcVOb5AwxFHgy7QJZOMD9yp9R9NFJK?=
 =?us-ascii?Q?622YyR0ITi/TGOgBOpyWtMiNNQ9me9CzN8S9Ij2nzwap9Fr98Ix7NL9NOhPN?=
 =?us-ascii?Q?x4kAvUVboj2ipXstXkpu4UtZBL6hL8SEg5bcVs/RdbsxYqpaLIddzcaDOC+1?=
 =?us-ascii?Q?HYEMn4ICI+Tr9FxWC0rBTBCwC07webiY28tQP3H03bX56n2dfARrkIM2Kd5F?=
 =?us-ascii?Q?gkjlqYgltWFHDFXjoGccSE+ERB+BL6X7MD9cXkRPhe89PJl41/8sJG0MLIpE?=
 =?us-ascii?Q?k9ZjRIuWNi81uqgf9xYIezgtHpIeosGB8A96Q7g6fgVKnwZl/fjvUqyg2ImD?=
 =?us-ascii?Q?sOTVUsUq8Khd50WY/A3/qzQNxfDTk1jiO3MbZpaPv0Vzdb1zZLqKtbEgkICm?=
 =?us-ascii?Q?xdJiBpIOYHRAZP8lIz4=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ebbe1de-7c55-4c66-284e-08dc6a39d0e5
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 May 2024 23:52:52.9847
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jY/J64GRrGj7SjtnHWTcq3TEisOrbBEQCNVBS1xi62L+Y1dewuDG5/xC7shBxNjM9/HIOJGMczcVerhsPZ1mdA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB10031

> Subject: Re: [PATCH V2] firmware: arm_scmi: power_control: support
> suspend command
>=20
> On Sun, Apr 28, 2024 at 03:51:05PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Support System suspend notification. Using a work struct to call
> > pm_suspend. There is no way to pass suspend level to pm_suspend, so
> > use MEM as of now.
> >
> > - The choice of S2R(MEM) by default. The userspace can configure whatev=
er
> >   default behaviour expected as S2R, if issuing suspend from userspace.
> >
> > - The userspace needs to keep the wakeup source enabled, otherwise the
> >   system may never resume back.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
>=20
> Have you tried triggering a suspend with this on your setup ?

Yes, this feature is already in NXP internal git tree and tested.

>=20
> Anyway, LGTM.
> Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
>=20

Thanks,
Peng.
> Thanks,
> Cristian