Received-SPF: pass (google.com: domain of linux-kernel+bounces-165888-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <0d26a80d9b595954aabd8f6c6e18c710.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <53c31752-c8a2-4098-837e-2f84f03c8748@moroto.mountain>
References: <53c31752-c8a2-4098-837e-2f84f03c8748@moroto.mountain>
Subject: Re: [PATCH] spmi: pmic-arb: Fix of_irq_get_byname() error checking
From: Stephen Boyd <sboyd@kernel.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
To: Abel Vesa <abel.vesa@linaro.org>, Dan Carpenter <dan.carpenter@linaro.org>
Date: Wed, 01 May 2024 17:55:03 -0700
User-Agent: alot/0.10

Quoting Dan Carpenter (2024-04-24 04:42:46)
> There are two bugs in this code:
> 1)  The "irq" variable needs to be signed for the error handling to
>     work.
> 2) The of_irq_get_byname() also returns zero on error so change the
>    comparison from < 0 to <=3D 0.
>=20
> Fixes: 932282f154ac ("spmi: pmic-arb: Register controller for bus instead=
 of arbiter")

Sadly this isn't stable because I just send patches over email.

> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---

Applied to spmi-next