Received: by 2002:ab2:60d1:0:b0:1f7:5705:b850 with SMTP id i17csp886698lqm; Wed, 1 May 2024 20:57:25 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXfGqwmDpZlO0DxgGQB5MvvaiVv3z6UCqqRrfuRcJK2CSxePe3GWZ69kSD6MaclZDiqhUZgxJj6SZqPnVhUfbaCPgAXbu4VUjYZIkTvFg== X-Google-Smtp-Source: AGHT+IEyiXVk5a2fa7m6em7+q0Z4K19tNc2fMYG4lJS4nthxXLB9V9WO0VEhjBT7SK9aU9poDxVx X-Received: by 2002:a17:903:2592:b0:1e3:c419:35c2 with SMTP id jb18-20020a170903259200b001e3c41935c2mr3641594plb.34.1714622245188; Wed, 01 May 2024 20:57:25 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714622245; cv=pass; d=google.com; s=arc-20160816; b=bHveHgXcDODQtRehV0lQNNi7eUA5NKN0X+n6r+0K0L8DWue8Hv0jlRo+RjsxvAvqDu MBBN94fAocLRRJ+2cvOBn5C0yLHN5UztN85KTmGU5XsWjnUSLgdRaxVSB4JfyYw6tuV2 +O+UlroR21h7V7bCZWPP55ni0oowK7WDdra27WSFC7SnlnvSIy3r91zVjjbdv8/VDIG4 Wv1bH3mjAnDLngtQpDB9BiPlLlHYe9F/sCldZQ/jw6wtJs2OQ4DbcxLVvXO+NE5BurfC j+dSz/YJLqqTJWWrRdwMrDQRuIAgsbzYsWYXCqH24gGI2aVxgrKBVKS2roqVHmdptE87 K8sw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=mO5pYStwOZbV6DU0bjL2D45EP90QqRwpD8sID0Tntow=; fh=NT1JlY0KUfwwHge3JGekHiIquyp5mBDoAvAzuzjWvfs=; b=c4ccSbtZxl8zNFGYVH/U+MebYhcOEJ/bxaBYCnBbEf+1FGK1ZiiOdarc6m5dKt+BFU 9GU0EpBjjGq0Sg/+evnXZ0VdYtnSQXLUQs6MfAYFee2Qzlfb/FRzQAmyYK/UXotnwpa9 nzTceNX7RB4xjAaZX6wZLkirQzzsdED+K9oUXK/KUAkye9EtLBc6QPmpMFsg6HAZiz6r 0y3ojHBkZHIBkerNp18fGQ9J8/XOjG8/FURYIW8UbDpRpwWHoBfYl1sKMV7vdyKHxaOc 2woUydGEKJzoilkzzVtuNh2cnwUI2xxJ7FustRUweEZZT7furCv91gTiWtL8lYtHbYO8 p26g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=h4uBsHfv; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-165948-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-165948-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id l13-20020a170903120d00b001e4063f59a4si198920plh.581.2024.05.01.20.57.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 20:57:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-165948-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=h4uBsHfv; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-165948-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-165948-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id A1B382840C9 for ; Thu, 2 May 2024 03:57:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E5AD019BBA; Thu, 2 May 2024 03:57:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="h4uBsHfv" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C969D527; Thu, 2 May 2024 03:57:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714622228; cv=none; b=tTAKz/+WOZyb8h4kwmeWSCyOY3ywzw7l1s53a9urHNZzTK9uyXpiE/O7q8njvw5QAEQzVmRbp8DZmE2tRXsViSWkGbnQwz2OsNd4uNqZ5f4dP5FoLIrySY7V5Ua5AM9GKQMcBVvSliUhIeFDZSwAJujyGOZgt1sCABGKB87ZjiE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714622228; c=relaxed/simple; bh=GhLrb4LsugJQdErEM1U3FioSUcGebSzbtNTOsJjlJe4=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=NyxhD/CZLilmQiTN0JjGbFUS1w9OjahbhGtZKiNfUUV/BC7bjEdPkbAAjGfIjnmBWW7Q2YkqJXtzTE9NVQyb9LtgbRoxfVVX7Yr9OcPPDFhQ18s4zoJEgyKWNJPrMnsbXcR/vh+N0nUvr+PuYzvQe6udGpFMj3S7nfzudMIv9XM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=h4uBsHfv; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0964C4AF4D; Thu, 2 May 2024 03:57:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714622227; bh=GhLrb4LsugJQdErEM1U3FioSUcGebSzbtNTOsJjlJe4=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=h4uBsHfvJ70gB5079HVXd1JVMXmwd4oeFaHxkutp2sUdk77EGI7ruVtyss9OVDqT3 QARmiCfSHZFhcyA9BOqIB1qO0gTPUiRdyPwKgpPZf3Bqyf06T9zUam+Q1U4L20wuMO 36ApLDr/oOoA0l/4D5r2Pr/4RlZN1Nv2v3xhfHncs6dAGjaWF7hSTdacRF9Lp/WF7j Q304t34WpWbaG47iBOzK0jx9ZZFJGzzVrAjpeLlvI6/f1KA2AxsDbJCTwbqk9FaseM drOrMnCYezj1Y6ZWcaEOVgvRIELSS0lPK8dSiMc9qm42X9QwZ2Eqborw9owLEP7mZz Lev8AaSUdZNNw== From: Mark Brown To: linux-spi@vger.kernel.org, Wolfram Sang Cc: Chen-Yu Tsai , imx@lists.linux.dev, Jernej Skrabec , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, Samuel Holland , Sascha Hauer , Shawn Guo In-Reply-To: <20240430114142.28551-1-wsa+renesas@sang-engineering.com> References: <20240430114142.28551-1-wsa+renesas@sang-engineering.com> Subject: Re: [PATCH v2 0/8] spi: use 'time_left' instead of 'timeout' with wait_for_*() functions Message-Id: <171462222567.1904471.14171309243632895183.b4-ty@kernel.org> Date: Thu, 02 May 2024 12:57:05 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14-dev On Tue, 30 Apr 2024 13:41:32 +0200, Wolfram Sang wrote: > There is a confusing pattern in the kernel to use a variable named 'timeout' to > store the result of wait_for_*() functions causing patterns like: > > timeout = wait_for_completion_timeout(...) > if (!timeout) return -ETIMEDOUT; > > with all kinds of permutations. Use 'time_left' as a variable to make the code > obvious and self explaining. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/8] spi: armada-3700: use 'time_left' variable with wait_for_completion_timeout() commit: 7dbbbb1206dd0b695b9a76d3b758c8a689f1aa52 [2/8] spi: fsl-lpspi: use 'time_left' variable with wait_for_completion_timeout() commit: eef51e99f7b9ecc903a3a9ad9e7ca84dc35c3f52 [3/8] spi: imx: use 'time_left' variable with wait_for_completion_timeout() commit: eaeac043ab842d2e84616ff0412eec0121c1758c [4/8] spi: pic32-sqi: use 'time_left' variable with wait_for_completion_timeout() commit: a7c79e50a26cb619400ccc6294dbd7d8c24a0341 [5/8] spi: pic32: use 'time_left' variable with wait_for_completion_timeout() commit: e66480aed4a194f278da1e46ec45221b3983216f [6/8] spi: sun4i: use 'time_left' variable with wait_for_completion_timeout() commit: 34bed8a33f3a4f69b0ef584ef49f04a671a4a5c2 [7/8] spi: sun6i: use 'time_left' variable with wait_for_completion_timeout() commit: 83a3f1ba60d6e2f73c9dd2627a8ce41867dbc46b [8/8] spi: xlp: use 'time_left' variable with wait_for_completion_timeout() commit: 594aa75d6bdda85b5fd027a5056d8cd1345c1db3 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark