Received-SPF: pass (google.com: domain of linux-kernel+bounces-166007-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <c9ad463f-cc67-44eb-bf94-449144e3078b@collabora.com>
Date: Thu, 2 May 2024 11:33:17 +0500
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>,
 Edward Liaw <edliaw@google.com>, oe-lkp@lists.linux.dev, lkp@intel.com,
 linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
 Andy Lutomirski <luto@amacapital.net>,
 Axel Rasmussen <axelrasmussen@google.com>, Bill Wendling <morbo@google.com>,
 David Hildenbrand <david@redhat.com>, Justin Stitt <justinstitt@google.com>,
 "Mike Rapoport (IBM)" <rppt@kernel.org>,
 Nathan Chancellor <nathan@kernel.org>,
 Nick Desaulniers <ndesaulniers@google.com>, Peter Xu <peterx@redhat.com>,
 Shuah Khan <shuah@kernel.org>, Will Drewry <wad@chromium.org>,
 linux-kselftest@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [linus:master] [selftests/harness] 8092162335:
 kernel-selftests.sgx.make.fail
To: Kees Cook <keescook@chromium.org>,
 kernel test robot <oliver.sang@intel.com>
References: <202404301040.3bea5782-oliver.sang@intel.com>
 <202405011330.85D66871E@keescook>
Content-Language: en-US
From: Muhammad Usama Anjum <usama.anjum@collabora.com>
In-Reply-To: <202405011330.85D66871E@keescook>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 5/2/24 1:32 AM, Kees Cook wrote:
> On Tue, Apr 30, 2024 at 11:02:36AM +0800, kernel test robot wrote:
>> version: kernel-selftests-x86_64-c7864053-1_20240419
>> [...]
>> compiler: gcc-13
>> 2024-04-29 15:02:59 make -j16 -C sgx
>> [...]
>> gcc -Wall -Werror -static-pie -nostdlib -ffreestanding -fPIE -fno-stack-protector -mrdrnd -I/usr/src/perf_selftests-x86_64-rhel-8.3-kselftests-8092162335554c8ef5e7f50eff68aa9cfbdbf865/tools/testing/selftests/../../../tools/include test_encl.c test_encl_bootstrap.S -o /usr/src/perf_selftests-x86_64-rhel-8.3-kselftests-8092162335554c8ef5e7f50eff68aa9cfbdbf865/tools/testing/selftests/sgx/test_encl.elf -Wl,-T,test_encl.lds,--build-id=none
>> /usr/bin/ld: warning: /tmp/lkp/cct4g3SV.o: missing .note.GNU-stack section implies executable stack
>> /usr/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
>> In file included from main.c:21:
>> ../kselftest_harness.h: In function ‘__run_test’:
>> ../kselftest_harness.h:1166:13: error: implicit declaration of function ‘asprintf’; did you mean ‘vsprintf’? [-Werror=implicit-function-declaration]
>>  1166 |         if (asprintf(&test_name, "%s%s%s.%s", f->name,
>>       |             ^~~~~~~~
>>       |             vsprintf
>> cc1: all warnings being treated as errors
> 
> What environment is this being built in? "asprintf" should be available
> via stdio.h, and "kselftest_harness.h" includes that (and _GNU_SOURCE).
Sometimes the order of include is as following:

#inlucde <stdio.h>
#define _GNU_SOURCE
#inlucde <stdio.h>

The _GNU_SOURCE wasn't defined the first time stdio.h was included hence
the definition of asprintf isn't present. The second inclusion of stdio.h
when _GNU_SOURCE is defined is ignored as it was already included.

This is being fixed in following series:
https://lore.kernel.org/all/20240430235057.1351993-1-edliaw@google.com

-- 
BR,
Muhammad Usama Anjum