Received-SPF: pass (google.com: domain of linux-kernel+bounces-166025-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 2 May 2024 08:54:54 +0200
From: Horatiu Vultur <horatiu.vultur@microchip.com>
To: Min Li <lnimi@hotmail.com>
CC: <richardcochran@gmail.com>, <lee@kernel.org>,
	<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>, Min Li
	<min.li.xe@renesas.com>
Subject: Re: [PATCH net-next v7 4/5] ptp: clockmatrix: Fix caps.max_adj to
 reflect DPLL_MAX_FREQ_OFFSET[MAX_FFO]
Message-ID: <20240502065454.vn3rcfovwysqvbub@DEN-DL-M31836.microchip.com>
References: <20240501160324.27514-1-lnimi@hotmail.com>
 <LV3P220MB12026BB3CBA7FCE8480438FBA0192@LV3P220MB1202.NAMP220.PROD.OUTLOOK.COM>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <LV3P220MB12026BB3CBA7FCE8480438FBA0192@LV3P220MB1202.NAMP220.PROD.OUTLOOK.COM>

The 05/01/2024 12:03, Min Li wrote:

Hi Min Li,

Maybe the entire patch should target net instead of net-next. As this is
fixing an issue.

> @@ -2285,6 +2301,10 @@ static int idtcm_enable_channel(struct idtcm *idtcm, u32 index)
>                 ppd->chan = index;
>         }
> 
> +       err = initialize_max_adj(channel);
> +       if (err)
> +               return err;
> +
>         err = initialize_dco_operating_mode(channel);
>         if (err)
>                 return err;
> @@ -2437,8 +2457,13 @@ static int idtcm_probe(struct platform_device *pdev)
> 
>         err = idtcm_load_firmware(idtcm, &pdev->dev);
> 
> -       if (err)
> +       if (err) {
> +               if (err == -ENOENT) {
> +                       mutex_unlock(idtcm->lock);
> +                       return -EPROBE_DEFER;
> +               }
>                 dev_warn(idtcm->dev, "loading firmware failed with %d", err);
> +       }
> 
>         wait_for_chip_ready(idtcm);
> 

Also this change should be in a separate patch as this doesn't have
anything to do with caps.max_adj but it is releasing the lock in case
firmware fails to be loaded.

-- 
/Horatiu