Received-SPF: pass (google.com: domain of linux-kernel+bounces-166028-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 2 May 2024 08:58:36 +0200
From: Horatiu Vultur <horatiu.vultur@microchip.com>
To: Min Li <lnimi@hotmail.com>
CC: <richardcochran@gmail.com>, <lee@kernel.org>,
	<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>, Min Li
	<min.li.xe@renesas.com>
Subject: Re: [PATCH net-next v7 0/5] ptp: clockmatrix: support 32-bit address
 space
Message-ID: <20240502065836.a6xfpqsxm3vocxwe@DEN-DL-M31836.microchip.com>
References: <LV3P220MB12026032F3316F557415AD9FA0192@LV3P220MB1202.NAMP220.PROD.OUTLOOK.COM>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <LV3P220MB12026032F3316F557415AD9FA0192@LV3P220MB1202.NAMP220.PROD.OUTLOOK.COM>

The 05/01/2024 12:03, Min Li wrote:

Hi Min Li,

> 
> From: Min Li <min.li.xe@renesas.com>
> 
> The main porpose of this series is [PATCH 1/5], which is to support read/write
> to the whole 32-bit address space. Other changes are increamental since
> [PATCH 1/5].

I can see that now you are at version 7, it would be nice to have kept
an history of changes between each version of your patch series so other
people can see what has been changed between versions. Maybe you can do
it from now on.

> 
> 
> Min Li (5):
>   ptp: clockmatrix: support 32-bit address space
>   ptp: clockmatrix: set write phase timer to 0 when not in PCW mode
>   ptp: clockmatrix: dco input-to-output delay is 20 FOD cycles + 8ns
>   ptp: clockmatrix: Fix caps.max_adj to reflect
>     DPLL_MAX_FREQ_OFFSET[MAX_FFO]
>   ptp: clockmatrix: move register and firmware related definition to
>     idt8a340_reg.h
> 
>  drivers/ptp/ptp_clockmatrix.c    | 120 ++++--
>  drivers/ptp/ptp_clockmatrix.h    |  66 +--
>  include/linux/mfd/idt8a340_reg.h | 664 ++++++++++++++++++-------------
>  3 files changed, 482 insertions(+), 368 deletions(-)
> 
> --
> 2.39.2
> 
> 

-- 
/Horatiu