Received-SPF: pass (google.com: domain of linux-kernel+bounces-166088-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <785c080e-c133-40f1-9b15-2854827a0a0d@wolfvision.net>
Date: Thu, 2 May 2024 10:01:20 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] iio: tmag5273: Remove some unused field in struct
 tmag5273_data
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
 Jonathan Cameron <jic23@kernel.org>, Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
 linux-iio@vger.kernel.org
References: <7bd16d7fea12c64b6b3dc3cd32839cfce145bcf3.1714562912.git.christophe.jaillet@wanadoo.fr>
From: Gerald Loacker <gerald.loacker@wolfvision.net>
Organization: WolfVision GmbH
In-Reply-To: <7bd16d7fea12c64b6b3dc3cd32839cfce145bcf3.1714562912.git.christophe.jaillet@wanadoo.fr>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VnJoVDBlOHYxcys4SXVUU3lkZERwRVF5b3M3OVR4RHRFTkkyZTd1SGgvdGhL?=
 =?utf-8?B?dUpqa3BCSUgra2hYYWx3ZmdqbldCU2NENjJybXFxeFE4MGNSZDRVY3FPcm9P?=
 =?utf-8?B?a2FabjhFQWtUakpReDJHTXpqbDNCemx6WHo5TlZRcVdYWGFzVTM4bzNYZEpj?=
 =?utf-8?B?emo4UXprVnp4QlhoV1ZzOWs3dlZvTkR4aC9seTc1ZzlmK2VPdFNwYWdMOG1P?=
 =?utf-8?B?eUdRSXdsaUs1aC9sL0FBVGM2QkRWRk1qWVNoRFZtSm5vaDRHNFA1dXBLNzR1?=
 =?utf-8?B?U3Ztd09mYzZ2SElqZEVKM1VHY3hwdk9tdTlxV21kZXFmUGxwcmcrZkVhcllR?=
 =?utf-8?B?UmdGSHBWYkdBWWRmOEExa0pCb093UmdsSnppRi8ySHJyZStES0FXSVFRQ3FQ?=
 =?utf-8?B?WGpDLzdOZkVpZGRpdmxicWNZdFYrc3FjTVpINlJ5enFSSXhDakJ5aTJ6YkNr?=
 =?utf-8?B?TDBOeVdydC9sV3JCV0NoV1BpWDBEbElESDlUUWorQk9BTXZrTXJ4dGZwZlRQ?=
 =?utf-8?B?a0d1WFVLZ1lrQ3p3NWVnUGljMHhOWmpQb2V4eVVJSTZvblF1UU00WlZKZDFP?=
 =?utf-8?B?cW5WYWtBd2xJTEF3azZ5aEpzMVZ1dmUwWVVodG0rRlpWRWVNZlhwbUUrYm81?=
 =?utf-8?B?UmpBNVhQanBaVSsxRGdHTE9NSkZOWHk5ZVQvUkdva1VnaGx3NENDRjVOcTF4?=
 =?utf-8?B?ZWs3cWVGK1dZVWhpS090S2ZWRlNyTWt0bmhSL2xCSnFIcXAwKzVNL2RsL1RB?=
 =?utf-8?B?YmFjZHEzSmRDQmFFLy93ZTZLbEhzRnpXYXl0eHlXbWRQUTFrbVoxbDVXVUtk?=
 =?utf-8?B?Zis3aXd4TEJ3c05obHZDbDQwMzlsSkg3bk0vRmRiaVJkVG90NG8zOTdGRW9M?=
 =?utf-8?B?eTJwYWZIYVBKUk1rZnpxSzZTWGw3TmIxYk1GZ3Rna0xCZzlkN0k4cEZVK0Vs?=
 =?utf-8?B?bVVoWEZOZ0NjY3hjbnk1WnQ2QW1nVURBeXB5Y3pPT1BwVmdyMTVNeDBYNHVE?=
 =?utf-8?B?dHVtSXFYSVlNME1YbHpMTk9WdnBKNzZ5Z0hOMFE0UGhNUTk0OEh2OVBvTUU0?=
 =?utf-8?B?MU1IcTlJekM3dHdLT09NKzNtdGdRMHhoVlhWbUpiYzdOanJhdkR6N0dmd2xi?=
 =?utf-8?B?aE5tUTdFa1MxUjFxM2lRRXJhdVhpYnZ3amIxc0F0Rjl1UmpHQnpOTEkrNmdH?=
 =?utf-8?B?Vk13VG8yaDlmZmxXVUxlS2RCRlpCSWlsQjQwYU9ydFRwWUhZUmhNenZ4ZVRX?=
 =?utf-8?B?SUd2U1lYZ1FQNnoyUUVZVUtydmNWaFdoY2pPWVgwOE0rL0s4RmEvMStoMzIy?=
 =?utf-8?B?aTZnMTE5UG5pM1E4VXRrWUlvdTFjQmNFRlgyN2lQQnlvM1NJZkdzWlY4ZDE5?=
 =?utf-8?B?UHNWL1hrcmM3TkV0LzFXMTJtanJvb2JTMGJTMlU2ZlppaXlDNVBIaThOMkNq?=
 =?utf-8?B?eElmYXdoUFRmcWZJRmtRTlBtdERoalRScWVzWU8yYlNHeHJPTGdhb2pzeG5o?=
 =?utf-8?B?V3l2QkN0YnFrOVRPZjl4V3dCOTVKdjg1ZUZoY0QwYXdzYkN2KzZjNDBnckpw?=
 =?utf-8?B?M0FaajRxaE0vczRGaUZDeko4NnlXSGlhQ3VSZkRNWUNtSmh4enJIc1JsK0J1?=
 =?utf-8?B?NloxeW9sWERtSzUvZUZpbFEwb3lySlRFVnVJK1lGQ0ZCRmdMbHVCZjBhQkMr?=
 =?utf-8?B?Mms0d3AvQW4rNnhjalVkaGFhdEVGWDVMRnp2NnVpbFgzT2VNKzJKRGhpdUpz?=
 =?utf-8?B?bmhGRERHYnhSOUdBa1hvTXlnVTJ2NHBqY2RpbGd5M0oyVjJsUnZNbTBId1VM?=
 =?utf-8?B?Q1JHNG5KWUxpRXBrNFM4TGwxTXFiRm9sUlV6S3BHOWloU2pwYmphV2JmQkdQ?=
 =?utf-8?B?ck4xelVYK3hZR3Y1cnlNMEtEMnBheXpvblJHWFllWXBVdURidGtEa043bW5S?=
 =?utf-8?B?QndnU3k3MlhTaXp2Ynd6bm4zYUMySVJOSlZNcmNlMVowOG5KSFNGNVUzeno1?=
 =?utf-8?B?eTVQcDZVVTVBRWc5eExTc25YOVpaQkcybnBqL2FxanBjMXN2OHNNdUVLbGhT?=
 =?utf-8?B?b1pBOFZWZUNFRXBONC9BNHZOaElDQVM0RjI3ZEI4UDk1OFVzUE1UcVpoNlBN?=
 =?utf-8?B?SkJ0YytjelVXWFJ2eDZ6TllLNGIzRUNENGlvTXp6bGVhYkV0NFRIYnV2L3FF?=
 =?utf-8?B?bXc9PQ==?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: ce88a02f-0748-4d0a-eafd-08dc6a7e0de0
X-MS-Exchange-CrossTenant-AuthSource: VI1PR08MB4544.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2024 08:01:21.2361
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FAkUuobaQzMOuTRYGbSPA1MfrGKWI6OcCQrlkBbzU+BUlxN9pV8XqdYW38t8wIlptT2YT5OFE0/AeEzRQ1d0OEHWqoTuBd0aBg2714nUk1U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5505

Hi Christophe,

Am 01.05.2024 um 13:28 schrieb Christophe JAILLET:
> In "struct tmag5273_data", the 'scale' and 'vcc' fields are unused.
> Remove them.
> 
> Found with cppcheck, unusedStructMember.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Compile tested only.
> 
> It was added in the initial commit 866a1389174b ("iio: magnetometer: add
> ti tmag5273 driver") but was never used.
> ---
>  drivers/iio/magnetometer/tmag5273.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/iio/magnetometer/tmag5273.c b/drivers/iio/magnetometer/tmag5273.c
> index 218b1ce076c1..4187abe12784 100644
> --- a/drivers/iio/magnetometer/tmag5273.c
> +++ b/drivers/iio/magnetometer/tmag5273.c
> @@ -118,11 +118,9 @@ struct tmag5273_data {
>  	unsigned int version;
>  	char name[16];
>  	unsigned int conv_avg;
> -	unsigned int scale;
>  	enum tmag5273_scale_index scale_index;
>  	unsigned int angle_measurement;
>  	struct regmap *map;
> -	struct regulator *vcc;
>  
>  	/*
>  	 * Locks the sensor for exclusive use during a measurement (which

Thanks for cleaning up.

Reviewed-by: Gerald Loacker <gerald.loacker@wolfvision.net>

Regards,
Gerald