Received: by 2002:ab2:60d1:0:b0:1f7:5705:b850 with SMTP id i17csp979419lqm; Thu, 2 May 2024 01:16:33 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWToKC19A/QFgesHpcXptbhgq4kiFv2U2L1QT1w4/2pEIpNB63Vc2meOK2o7y5jdmSVWmzkEntBWp0uv7Nk1DzId3gVM0jN1GS39SSJhw== X-Google-Smtp-Source: AGHT+IFO1rr0A9Z7tpu6PMvSXaUv5UZ4eDPhNxKSZnl7DOGnbmbr4CMIBN2lyBjB87mDHNXrVs0F X-Received: by 2002:a17:906:2b06:b0:a58:ea69:3f4f with SMTP id a6-20020a1709062b0600b00a58ea693f4fmr2973417ejg.70.1714637792812; Thu, 02 May 2024 01:16:32 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714637791; cv=pass; d=google.com; s=arc-20160816; b=UtLFO9v0I/TB720MwAhU43n1BW1N+HpgNXxYM7PQHe6xtdb8WzUo8FuYhH10GAs8s0 HDKVFy95ZJA2vPbORht14u4v4SL75LnOo8PLKD9zQnPjQ4a7t7Cf/bO3Q1PxCyD+j3fp DTSiXTCTnrlLXhw4eIu8G3bdu4VReiB+LtpqGfxTpZQbWPWj02tFcHSDk1sP/ndv6QV9 DLiQB7BGpZadDFR1UfI3fL6nZz0zVJuUwEU5QjA201idwUPgiE8oBbOqmAHxToa2dUK2 EPX6irmwEfpYYbBcveavVyyeU/qB2TQRCsk4TGDehiu6Ki8AOEHAcilHLheqG+T+XCdH HTjw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=YmFyvlIHda9NU2gXF06k2ZQ7jALqIM9zqt9BFQX5Bik=; fh=6QxjGZ3hV8I8y20UIXQ0JoGN0b0l6Ud87yQMAazAhdo=; b=fq68ox2FQDP8o3Tlbtk6tKvLT+vQa6Wm2RtnIdHmI+1jBPM1VdXUGjzAiPYUiAq6kx H/CUBhEZf3iVrcrb5mdHBm0a6qFhKDGYSFxc3FGmMamMCKg3R9/AoF6m/xFNeBO9kYaW zsS5Ul4bMViqbeEYspaXrBbeNMAb6jh4hrlOp88AleUYgOkpEg6WHoSK7u98RzsM9MQf YLalz4WiaGrhlOz9MOAirgjcXEtFZMsQfb+iePd7OMtfqkqJh7N3JvGwdbMTbrGCAmFi dS3oGLXBSIBgWTBPWhMRgtT8cVyzXNAuYTS2U+TDOYeuGzhaF5YaL0cJQPkxZIaz7yj/ NqFQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fZUWeJI7; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-166104-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-166104-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id h12-20020a170906260c00b00a58f5eab705si267143ejc.383.2024.05.02.01.16.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 May 2024 01:16:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-166104-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fZUWeJI7; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-166104-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-166104-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id D1EB71F24C5B for ; Thu, 2 May 2024 08:16:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 967032E85E; Thu, 2 May 2024 08:16:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fZUWeJI7" Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 576652D04E for ; Thu, 2 May 2024 08:16:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714637783; cv=none; b=lTkrQqFZU2qAm0ggevC5ICAXKHLTSs78nqmfalkGTY9tKVWN10fHx90qRA/KWHIom+/+1WXgoxqSQaypwJ3VVp7J7jUPHZttVyNkL05J2zby2rCzrb3z32E2AUbjNqI+5oS9ulutfao2+AKAp5w0NHnwdCx8n9I4pozNMtmq7zA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714637783; c=relaxed/simple; bh=sw3n3mAExpJtGyzHD90cvwAbCXAEOmh9mL/3EWKffGE=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=hh1HlQScVs4yYC071vscUKfX7kH4uZqWsyxS46PH62BCLkA7t9VI0m3pOwFXbqTrlaH1DxZcr7HDl5e2fqvdwUWWAt1L5EgPbrfN0Y2veWvBYPCGNlppu3yMiOtg3yC5w2adtfxjtRqzfdckZGNXtIAHTaS1ZXo+ljZNzKQQm2I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=fZUWeJI7; arc=none smtp.client-ip=209.85.219.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-yb1-f171.google.com with SMTP id 3f1490d57ef6-dcd7c526cc0so8363811276.1 for ; Thu, 02 May 2024 01:16:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714637781; x=1715242581; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YmFyvlIHda9NU2gXF06k2ZQ7jALqIM9zqt9BFQX5Bik=; b=fZUWeJI79qjWtFa/NC433F+7iM7wEsFnK1ykA2zU+fOs9KSFPire4UbH6Hvncw8MDc YpB+WFyHnaWLmajXmQhsBJMXIceQjrfy7pk3xpXMTgiE3QLx87fMhShDZOZssUMUAWHx rxx3X6nkwnXICQgWN/bWvusaxGV7EC+ep2sDahAfC7zx4i87SZ4zqd8n/H7pgX2KuU6P vtgBdL6GClXs8ABXJ/Gx+h2q6NsFgdhbSA9DGAeF5tdFjte/c9bDTjkguEBakmpNkf5B q3s5QgmIoKlpG3/c1OZmEj8ZYSLCehmRr6s/Ut4SqzAcDOs/MGg6oolas48xBZfh/Eao VWLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714637781; x=1715242581; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YmFyvlIHda9NU2gXF06k2ZQ7jALqIM9zqt9BFQX5Bik=; b=DDtwr0AI4W14kw222nXJD6dJsZNzSE44Gy5PhLuWgeqhapg+NTJI5kMOkEd9OeKLg8 fFxVX8AHxqY27rRDkWTAghjkeqBM8h/qiIGS7iU04DkcIUuHe0A4myJGKj5qLy7JK6x/ x4GOO8gPYsDxk/vsMU7TdZD/jhQVIByZnPlPXZpBU3ChVP5GaCOTHKK7d9WT6Jfxz/z7 ZaxTfJkKjeMGsJYweCqOQHUYlKxz9xLSMDOhKghF0XwUbwdoowSMR+5rYRklVQue2PTI zUNiStHter2geL4x1gr9ZwLVpWBkecbcQ2/aqDiTgMjE1caEYmY+UGWmjQQ64grYnCuo cO2A== X-Forwarded-Encrypted: i=1; AJvYcCW14bjw/0z1sTvlLLOWsZgF7ZzOoSbXZOxrpi4XGxIzVjByf2yOU6lnrgnwhMGO/Bdk5eKBwWzc+NJqlqwMjvm4lg85lQwmxh5/BAXi X-Gm-Message-State: AOJu0YzSq52Zc21xrhDkqwjugpA77IXUvPXX5Gk50zcSP13pK86/3qny Rf1K0PEmdM07rFgQrCjqY0LK7xe/u7u07uxMq8ZuMomPf4KmNXJtPrz2k4QyqKG6z3kOqQD8UYq brldTAgSWtkHQ0y4cNHc9cTvz/0EZXO9LchcYUg== X-Received: by 2002:a5b:b4a:0:b0:de5:4b71:2d1d with SMTP id b10-20020a5b0b4a000000b00de54b712d1dmr1475592ybr.29.1714637781422; Thu, 02 May 2024 01:16:21 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240501154251.3302887-1-dianders@chromium.org> <20240501084109.v3.3.I9982cd5d8014de7a4513f5619f66f88da49ce4ec@changeid> In-Reply-To: <20240501084109.v3.3.I9982cd5d8014de7a4513f5619f66f88da49ce4ec@changeid> From: Linus Walleij Date: Thu, 2 May 2024 10:16:10 +0200 Message-ID: Subject: Re: [PATCH v3 3/9] drm/mipi-dsi: mipi_dsi_*_write functions don't need to ratelimit prints To: Douglas Anderson Cc: dri-devel@lists.freedesktop.org, Jani Nikula , Dmitry Baryshkov , Cong Yang , Hsin-Yi Wang , Brian Norris , Sam Ravnborg , Neil Armstrong , Javier Martinez Canillas , Joel Selvaraj , lvzhaoxiong@huaqin.corp-partner.google.com, Daniel Vetter , David Airlie , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, May 1, 2024 at 5:43=E2=80=AFPM Douglas Anderson wrote: > We really don't expect these errors to be printed over and over > again. When a driver hits the error it should bail out. Just use a > normal error print. > > This gives a nice space savings for users of these functions: > > $ scripts/bloat-o-meter \ > .../before/panel-novatek-nt36672e.ko \ > .../after/panel-novatek-nt36672e.ko > add/remove: 0/1 grow/shrink: 0/1 up/down: 0/-16760 (-16760) > Function old new delta > nt36672e_1080x2408_60hz_init 17080 10640 -6440 > nt36672e_1080x2408_60hz_init._rs 10320 - -10320 > Total: Before=3D31815, After=3D15055, chg -52.68% > > Signed-off-by: Douglas Anderson OK then! Reviewed-by: Linus Walleij Yours, Linus Walleij