Received-SPF: pass (google.com: domain of linux-kernel+bounces-166105-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 2 May 2024 08:18:04 +0000
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
CC: <alsa-devel@alsa-project.org>, Jaroslav Kysela <perex@perex.cz>,
        "Liam
 Girdwood" <lgirdwood@gmail.com>, <linux-kernel@vger.kernel.org>,
        <linux-sound@vger.kernel.org>, Mark Brown <broonie@kernel.org>,
        <patches@opensource.cirrus.com>, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH 0/4] ASoC: use 'time_left' instead of 'timeout' with
 wait_for_*() functions
Message-ID: <ZjNMPOOFg9myFSz3@opensource.cirrus.com>
References: <20240430115438.29134-1-wsa+renesas@sang-engineering.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240430115438.29134-1-wsa+renesas@sang-engineering.com>

On Tue, Apr 30, 2024 at 01:54:33PM +0200, Wolfram Sang wrote:
> There is a confusing pattern in the kernel to use a variable named 'timeout' to
> store the result of wait_for_*() functions causing patterns like:
> 
>         timeout = wait_for_completion_timeout(...)
>         if (!timeout) return -ETIMEDOUT;
> 
> with all kinds of permutations. Use 'time_left' as a variable to make the code
> obvious and self explaining.
> 
> This is part of a tree-wide series. The rest of the patches can be found here
> (some parts may still be WIP):
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/time_left
> 
> Because these patches are generated, I audit them before sending. This is why I
> will send series step by step. Build bot is happy with these patches, though.
> No functional changes intended.
> 
> Wolfram Sang (4):
>   ASoC: codecs: wm8962: use 'time_left' variable with
>     wait_for_completion_timeout()
>   ASoC: codecs: wm8993: use 'time_left' variable with
>     wait_for_completion_timeout()
>   ASoC: codecs: wm8994: use 'time_left' variable with
>     wait_for_completion_timeout()
>   ASoC: codecs: wm8996: use 'time_left' variable with
>     wait_for_completion_timeout()
> 
>  sound/soc/codecs/wm8962.c | 12 ++++++------
>  sound/soc/codecs/wm8993.c | 12 ++++++------
>  sound/soc/codecs/wm8994.c |  8 ++++----
>  sound/soc/codecs/wm8996.c | 14 +++++++-------
>  4 files changed, 23 insertions(+), 23 deletions(-)
> 

All look good to me.

Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles