Received-SPF: pass (google.com: domain of linux-kernel+bounces-166107-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [PATCH net v2] ipv4: Fix uninit-value access in __ip_make_skb()
From: patchwork-bot+netdevbpf@kernel.org
Message-Id: 
 <171463802995.31501.18180325804062708968.git-patchwork-notify@kernel.org>
Date: Thu, 02 May 2024 08:20:29 +0000
References: <20240430123945.2057348-1-syoshida@redhat.com>
In-Reply-To: <20240430123945.2057348-1-syoshida@redhat.com>
To: Shigeru Yoshida <syoshida@redhat.com>
Cc: davem@davemloft.net, dsahern@kernel.org, edumazet@google.com,
 kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org, syzkaller@googlegroups.com

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Tue, 30 Apr 2024 21:39:45 +0900 you wrote:
> KMSAN reported uninit-value access in __ip_make_skb() [1].  __ip_make_skb()
> tests HDRINCL to know if the skb has icmphdr. However, HDRINCL can cause a
> race condition. If calling setsockopt(2) with IP_HDRINCL changes HDRINCL
> while __ip_make_skb() is running, the function will access icmphdr in the
> skb even if it is not included. This causes the issue reported by KMSAN.
> 
> Check FLOWI_FLAG_KNOWN_NH on fl4->flowi4_flags instead of testing HDRINCL
> on the socket.
> 
> [...]

Here is the summary with links:
  - [net,v2] ipv4: Fix uninit-value access in __ip_make_skb()
    https://git.kernel.org/netdev/net/c/fc1092f51567

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html