Received-SPF: pass (google.com: domain of linux-kernel+bounces-166130-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <b0cd37c3-5465-467d-8074-67fa2fddcc4d@gmail.com>
Date: Thu, 2 May 2024 11:44:15 +0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] staging: pi433: Rename goto label.
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: gregkh@linuxfoundation.org, hverkuil-cisco@xs4all.nl,
 andriy.shevchenko@linux.intel.com, robh@kernel.org, felixkimbu1@gmail.com,
 linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
References: <20240501055820.603272-1-ikobh7@gmail.com>
 <20240501055820.603272-3-ikobh7@gmail.com>
 <3005db51-58f7-4247-a37b-02933767f644@moroto.mountain>
Content-Language: en-US
From: Shahar Avidar <ikobh7@gmail.com>
In-Reply-To: <3005db51-58f7-4247-a37b-02933767f644@moroto.mountain>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 01/05/2024 17:06, Dan Carpenter wrote:
> On Wed, May 01, 2024 at 08:58:20AM +0300, Shahar Avidar wrote:
>> Use destroy_class_and_remove_dbfs instead of unreg_class_and_remove_dbfs.
>>
>> Signed-off-by: Shahar Avidar <ikobh7@gmail.com>
>> ---
>>   drivers/staging/pi433/pi433_if.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
>> index c8c1d296184b..4fffd7007040 100644
>> --- a/drivers/staging/pi433/pi433_if.c
>> +++ b/drivers/staging/pi433/pi433_if.c
>> @@ -1409,11 +1409,11 @@ static int __init pi433_init(void)
>>   
>>   	status = spi_register_driver(&pi433_spi_driver);
>>   	if (status < 0)
>> -		goto unreg_class_and_remove_dbfs;
>> +		goto destroy_class_and_remove_dbfs;
>>   
>>   	return 0;
>>   
>> -unreg_class_and_remove_dbfs:
>> +destroy_class_and_remove_dbfs:
>>   	debugfs_remove(root_dir);
>>   	class_destroy(pi433_class);
> 
> This is cleaning up something which changed in patch 1 so it should have
> been done in patch 1.
> 
Thanks for your input.
I thought of a previous comment you had were you noted Greg preferred 
small patches, so I did my best to keep the first patch the with minimum 
changes without breaking git digest.

This patchset won't be accepted anyway.

> regards,
> dan carpenter
> 
>>   unreg_chrdev:
>> -- 
>> 2.34.1
-- 
Regards,

Shahar