Received: by 2002:ab2:60d1:0:b0:1f7:5705:b850 with SMTP id i17csp1002779lqm; Thu, 2 May 2024 02:12:50 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVgECWyh7G9RaPWLVsSC/56KS3jDL7TSHIRaUIep7G42YyIKlNNGeLqCxMjoADaZOc5WG21Ob2tpI+Ppnh+3NC2DG/6BkmEMaDRvwaWmA== X-Google-Smtp-Source: AGHT+IESRZJmeSNmmnU/B+x4L6KJdDQ0v3B01Py+SUY+Q3aMrIxp36WGSq9ZijNGyGXp8KVS4em8 X-Received: by 2002:a05:6a21:7890:b0:1a7:a067:63e7 with SMTP id bf16-20020a056a21789000b001a7a06763e7mr1541099pzc.27.1714641170200; Thu, 02 May 2024 02:12:50 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714641170; cv=pass; d=google.com; s=arc-20160816; b=r+rZq9JjL2ku2qTO/3k+3NQXh4MkBLJujexf8hwP6hLsL4kTuz++NFe71Wfbx3+ob1 V/cTonfZdSp88lI5skEXhTmmynbTP4qBQchdLFSHYYi1W8X4RUcOJvCkHMt/iu+iRLy/ SknXelxMxWfjhHBdBY4bq8vIgKaO1/lxqSKN2fdoP3cStkAaTP3/tyQw/YVjo63dEywN w1OM1Z7QzKnJIw3fShnwOA6rLPZQ7VxGRpjinbfK4XhL2ePhJ8Yfvx8GJ77HKbZ/HXji jIVYOi0PtZUp4g9NbiYz1ByqOyR3nOFcIawQ4OIFSPEQrr9EflnGsusGnEgUR7dFFnZp helg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :date:message-id:dkim-signature; bh=gV0JLASkbNm/r4o94+gUkgK/LyrTAh8D8GAsALQ3hO4=; fh=C5UU0N35tZeqQGIpB6nvI5RSO0flCrxZeWu71taZLWI=; b=CNi8kVk/zatPEmpjr36TAZhq9CNCVR5oVmEmxHusOZxoDnzBDhCbbftcgx/2EytHob XEwmHD2Og/mf9EynfCgXB6aGs6Cot6SvWbJwL7yGx7cNcNAXtj6/9nef9tyg6Pr0NRxK eFWqT+Dq6SkRd5xGjRvWDup3sOu9pTWB8R9SLsikiywvQvuYjQOCoKDPZ5vNb213R73Z DiOxahGGfVLkXfwyB07nE37QX8/7XinE9a5SWY8ydzSko1b5HyRcx0ewk3ooDv7qahor lLOR4bVt0rjtt8ejrD3yOFQnLtWvpQmPiiAxz4n/xpJucJm9VW3BGdBplXf0KbDRfEdP QHMw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ecbL09G5; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-166185-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-166185-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id b3-20020a17090ae38300b002add21e0c7bsi669379pjz.138.2024.05.02.02.12.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 May 2024 02:12:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-166185-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ecbL09G5; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-166185-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-166185-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id CBD76281DC7 for ; Thu, 2 May 2024 09:12:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7D44154903; Thu, 2 May 2024 09:12:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ecbL09G5" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DA6D53819 for ; Thu, 2 May 2024 09:12:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714641130; cv=none; b=SX/+YMgeew9aio52hquerLZnpGl11oWs6vrQLbRiHjOmdVxf1V4aOuO7UMFmyYGLj6Mh6m7mCxw97g/B0DzYeHzPk5plgAxa84jUnV2HHITdHHnzrRqTSpp1bJBzbfqG3WIkgN8IimqsO5wWBa34VEkgeTjp3oi92s72SIaaLto= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714641130; c=relaxed/simple; bh=vdDTn+uzLBQCtp9MtS2N+CK5sg1wRO8wkuGtNHpBns8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PlZ/PDZoQ/KKgMUvhkDIaDS4M3NKqQhyeWqN/hgoM4Il53UKII2SOWC7+2KD16AQtBepmMCtLItM+if8EgazzHLY8EL1AyxGYVJhgYR4NLNjXYJwW0ZgOaM/QuPu4jdTE2GLc3uET4Ey10PfZKOibtfPsmByXRh0WSzbvRcCE0E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ecbL09G5; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714641128; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=gV0JLASkbNm/r4o94+gUkgK/LyrTAh8D8GAsALQ3hO4=; b=ecbL09G5AU5u9ALikbTRED5/IRJg5XP9DJVZ5unMu6VXEPVWcBEtB2/tDmldFO3boxTVht uan9K+ZoWoLpVMsw58LNaJSlPcfl9yd7ygZmWB2RANP1caYbNWjWNggRk7/moBob/T+nLr peV1PSJIlKv6TLlex7zI7hh6qMRWt0E= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-634-Gv4zYplpPsmCYJXbcmding-1; Thu, 02 May 2024 05:12:06 -0400 X-MC-Unique: Gv4zYplpPsmCYJXbcmding-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2e1e8860a00so3185221fa.0 for ; Thu, 02 May 2024 02:12:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714641125; x=1715245925; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=gV0JLASkbNm/r4o94+gUkgK/LyrTAh8D8GAsALQ3hO4=; b=ANO78xAhkfbyMLVvUIlPH3CwTviXmcAWKzeLzoD8Z0RlXU2Ph+4HfcRod6TUwLdxOM /E+AxyEbJokPq5R9IL3JtB1gSqO8A61VUOlxspAyGMGQrhTnenYCWtkWH30XYR0TI3TV Kn7QNAb7JwDRrrAmk0SyulKz77ze8BfBXzwXAtmL5czEIqrJmBbs9pwQcp8oZPD5o+Ot 09TsT0uYRXSd74aUMhxSqMdbnFjZINXV1kmqqRkXLq+29AyBc1OgcFVWdBjEyV4+1rsr puN2USBEV3dJbci3+cHPmLQZjocFTIt1zWbW5ipImBBQMl6BWI56MVesEDrdCec59Rcl OvhA== X-Forwarded-Encrypted: i=1; AJvYcCXOLulBT3ZgLron84/2sV/erxQy9JPrjwNMjnaRF4ZJA5gO5z6srd5ZDRCaqmdw6KqW04j87gAusKhUsLfh2hGxkZKzTiI/KmGSINaC X-Gm-Message-State: AOJu0YwRPlmm+F/S3nzrRrO47/XAMTOQOF+xegar/TApmSOACVtrLsix oEsSiwaUgiGxv42SuUqjRAlXb0s3wbQC+4vfzIo6mC+/C2boy/oWfUzTt0xxL22RbrmVTHKb44m z5Zr0P50Di77pfaI2vXTmgnzBKhFoEObvjRwkbICMgOyW/1YSZL7TgfdXosdLkA== X-Received: by 2002:a2e:98d2:0:b0:2e1:aa94:cf48 with SMTP id s18-20020a2e98d2000000b002e1aa94cf48mr1695978ljj.20.1714641124940; Thu, 02 May 2024 02:12:04 -0700 (PDT) X-Received: by 2002:a2e:98d2:0:b0:2e1:aa94:cf48 with SMTP id s18-20020a2e98d2000000b002e1aa94cf48mr1695939ljj.20.1714641124299; Thu, 02 May 2024 02:12:04 -0700 (PDT) Received: from ?IPV6:2003:cb:c71e:bf00:eba1:3ab9:ab0f:d676? (p200300cbc71ebf00eba13ab9ab0fd676.dip0.t-ipconnect.de. [2003:cb:c71e:bf00:eba1:3ab9:ab0f:d676]) by smtp.gmail.com with ESMTPSA id i14-20020a05600c354e00b004169836bf9asm4995291wmq.23.2024.05.02.02.12.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 May 2024 02:12:03 -0700 (PDT) Message-ID: <7636ada9-fdf0-4796-ab83-9ac60a213465@redhat.com> Date: Thu, 2 May 2024 11:12:02 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 11/12] mm: drop page_index and convert folio_index to use folio To: Kairui Song , linux-mm@kvack.org Cc: Andrew Morton , "Huang, Ying" , Matthew Wilcox , Chris Li , Barry Song , Ryan Roberts , Neil Brown , Minchan Kim , Hugh Dickins , Yosry Ahmed , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240502084609.28376-1-ryncsn@gmail.com> <20240502084939.30250-4-ryncsn@gmail.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240502084939.30250-4-ryncsn@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 02.05.24 10:49, Kairui Song wrote: > From: Kairui Song > > There are two helpers for retrieving the index within address space > for mixed usage of swap cache and page cache: > > - page_index > - folio_index (wrapper of page_index) > > This commit drops page_index, as we have eliminated all users, and > converts folio_index to use folio internally. The latter does not make sense. folio_index() already is using a folio internally. Maybe a leftover from reshuffling/reworking patches? -- Cheers, David / dhildenb