Received-SPF: pass (google.com: domain of linux-kernel+bounces-166002-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-media@vger.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Bingbu Cao <bingbu.cao@intel.com>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: [PATCH 1/1] media: ipu6: Fix vmalloc memory allocation
Date: Thu,  2 May 2024 09:15:25 +0300
Message-Id: <20240502061525.1004018-1-sakari.ailus@linux.intel.com>
In-Reply-To: <20240501102236.3b2585d1@canb.auug.org.au>
References: <20240501102236.3b2585d1@canb.auug.org.au>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

The driver was calling vmalloc() to allocate memory, something which isn't
available except when particular Kconfig settings are enabled.

Use kvmalloc() instead.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Fixes: 25fedc021985 ("media: intel/ipu6: add Intel IPU6 PCI device driver")
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
Hi Stephen,

Thanks for reporting this. I'm a bit surprised this wasn't catched
earlier. But it seems vmalloc() is defined in some configuration.

- Sakari

 drivers/media/pci/intel/ipu6/ipu6.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/pci/intel/ipu6/ipu6.c b/drivers/media/pci/intel/ipu6/ipu6.c
index 4b1f69d14d71..082b1d6196be 100644
--- a/drivers/media/pci/intel/ipu6/ipu6.c
+++ b/drivers/media/pci/intel/ipu6/ipu6.c
@@ -526,7 +526,7 @@ static int request_cpd_fw(const struct firmware **firmware_p, const char *name,
 	}
 
 	dst->size = fw->size;
-	dst->data = vmalloc(fw->size);
+	dst->data = kvmalloc(fw->size, GFP_KERNEL);
 	if (!dst->data) {
 		kfree(dst);
 		ret = -ENOMEM;
-- 
2.39.2