Received: by 2002:ab2:60d1:0:b0:1f7:5705:b850 with SMTP id i17csp1011157lqm; Thu, 2 May 2024 02:32:32 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX0im/aBiWvsmDyYImOK92InELOA04bC0/aaxHjMx30TrXIkOcjzJpNlREmOe5BRvsEnwM7cmsWbeiKc4KZ+oAMoHGPyk3U5i7eZLJe1w== X-Google-Smtp-Source: AGHT+IEuYX8hPztSEos9+zDxn4GF6COE/Bd14fvlzuou5PiIBqBDEWSBUre93Mtwfg3O+HrrvC6e X-Received: by 2002:a05:6a21:6da1:b0:1a7:63ce:84ce with SMTP id wl33-20020a056a216da100b001a763ce84cemr6742747pzb.49.1714642352158; Thu, 02 May 2024 02:32:32 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714642352; cv=pass; d=google.com; s=arc-20160816; b=QomO/jWN7M5aGO90BsnnDsrUCmKeRGpZ023arG2nKID2ExujdvZdscvwOMF/aw6+qI iBsu8x7ypH91vDuZ99MTuWRi3y3uR0Qtrz4nSFZWD9gNogHdQC2nJuSi4pPjpyloGLx8 6MtumhNwTd1BiIwS5XEGVc6+WuCrRw8E0nVQSAF6GSpy6WDiu93kEHb4BRwTbIwpKF4x UF4b3WABcLpXnUtU07GX/ytMu+py6oCIVx7DeTxVOZHRB/F1XEHKErL7O+Cz9Q1ll5j1 3N18d5QvyM4OTsYTHFzgXlsmaXVIvbM7W0twzy6trf2hPYr12MPraFSRT3YEK7qiAnCt bxeQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:content-transfer-encoding:autocrypt:references :in-reply-to:date:cc:to:from:subject:message-id:dkim-signature; bh=+3K3coq7KFO882RiOjdUhEOAnmzVmTq6nI9Be4OYR64=; fh=OfF+3Zas5fLnI4YooJWTaBN5okx8LWwCsJWkmvrFbNE=; b=zMMNFJVrVTlBf5VZ0PQvIVoJmtULG29m+S1kGdSLGUrj5ipEc1c/vcNKzZTOaeLGRH CaQk81n5u08I4fWzTHRi8vikZqW6Y3zJLQ4ld1osvp622jOJWk3pGOxIisib3aqJs3Gj D+8JAlby+WWuwFemLt89T2ThWoB6Wz3PmEF18fZfKj14TkcPkJxM1RKTMo3NUOjc1oiX HwA8hYHOirqaVkwnVIvfHBQMrAuW81r25z5wIJhdRKUZRnJfsglmni5xq5NKqOH3RsL5 ElSa3/7bZKe/g3smRen5kDlE6N522TjbpJYyHaFGnwdzZ13KvUDQRjPBMXVGzD0MpIMQ TdYQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Mi7D5udu; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-166225-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-166225-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id cb20-20020a056a02071400b005f7fcd32070si693358pgb.23.2024.05.02.02.32.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 May 2024 02:32:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-166225-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Mi7D5udu; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-166225-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-166225-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 3EE372866BF for ; Thu, 2 May 2024 09:31:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EA27F55C3E; Thu, 2 May 2024 09:30:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Mi7D5udu" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B37A854789 for ; Thu, 2 May 2024 09:30:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714642242; cv=none; b=gvDWR4wafHX9T6ZdaKRElZspWHhgRmIMeqZvWcuyfWHtSqYf/ZCyLwJ7//9O8pEkmMZh+Bk7N/TCL1s0WETup684JXtf3W0hbWZCYMVI9G9iskd3A1/5xil0XpotZU5Ph5taBHjLG9RbmdqiTPh68BXIhv/YxeJWulToICVYQ+M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714642242; c=relaxed/simple; bh=g/3wjd+5QLHutuyDd1Om5OYRKNIUQNWqYjNqlG7PDyI=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=UqvMSkxHAX3zlBL7bHLV5isEElKZ2I1aZ8No32vgiZYayOHT6YtyJDuLmCBFeFP87/ufIX7kfhU/dzDWhO+xYd7qfKW6LZTLusopfHNoLwJvIcQBTJnQF/BRRDgj2mJAnYBg1Dg2aoSUiwHcLUpn9NXDF7W9TfNHtAMqTdYldiY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Mi7D5udu; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714642239; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+3K3coq7KFO882RiOjdUhEOAnmzVmTq6nI9Be4OYR64=; b=Mi7D5udunNh47MMLZ+gQB2Kw2HBDoJvPx7f0cUqndxQB7UyeDdHHkDmJ9+dajvjnQx/Iup 6KUeVW7tRtrEKgMGckQEl5gz4jvlVfCIAjoycxNrCAXy/HQ+1JUQM59ZoxJVOYR+1OUKOV n/rwPWM8IwLfX/0Oz3uQka8w/j3LD08= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-423-iHNCnCLDPXqYNszwmzx39g-1; Thu, 02 May 2024 05:30:36 -0400 X-MC-Unique: iHNCnCLDPXqYNszwmzx39g-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-34daf593302so245623f8f.1 for ; Thu, 02 May 2024 02:30:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714642235; x=1715247035; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+3K3coq7KFO882RiOjdUhEOAnmzVmTq6nI9Be4OYR64=; b=u9lKel6zr3lRItJ2f3cZ4HSDzgMQYQmm6pqOh93mSXsYs7zRXmW7EDyVv9Kwx3cc9Z kQxeBX/B8r7VsGFRM+QJiszHGuOcRChyFvQCo409GTPx89MrbMx33UUoUFl5hOznP9kW ifESDAp5Y0PYJUYkXRq+NZwoqUmxpHnTkAck4vu9Res6Fa6q4NlsMrJhJjipNgTLPfYF c2xwakFEZvMVoYfxupuqNMS3Zckq1zBCX9vXnCyPbSLw5lPwrcOx8yQZftkvt3N0extA KdYxcOkqgb81dUzlnVEfNHkZyiytT6Hw5mji4ysgUSQaOsO9l0OO0/SmE6z752TFJuvL V2Jw== X-Forwarded-Encrypted: i=1; AJvYcCWbW4slWPOCmoH7dPvGeK4o3+GCvD14f1wdVB+JFDlF9oGVaayDhy2/gduTSHnK9jgd0+PYRdKcLRsHHODRGMhgw4qtkV77Fs4Xjgpk X-Gm-Message-State: AOJu0Yw79rnKzh4TsukcYx2d9VFnKtfip9hvPzKMWxBNAWyBoFTvuKXX RoiiVZzYUihSwnofg9EWwmeAz0Mp+xhLE9pHJKfkwoqLPFr+hpa+jQviN2xEwhhjT7j/qS+YTz2 W/FTbnNoOBKodJG5s+MZXaaiDghYuai3gHia7Lgo1faCgzwAM2CsjLI+4Q/z6Sg== X-Received: by 2002:a05:600c:1ca4:b0:418:1303:c3d1 with SMTP id k36-20020a05600c1ca400b004181303c3d1mr3596485wms.3.1714642235196; Thu, 02 May 2024 02:30:35 -0700 (PDT) X-Received: by 2002:a05:600c:1ca4:b0:418:1303:c3d1 with SMTP id k36-20020a05600c1ca400b004181303c3d1mr3596466wms.3.1714642234785; Thu, 02 May 2024 02:30:34 -0700 (PDT) Received: from gerbillo.redhat.com ([2a0d:3344:1b52:6510:426c:715f:ad06:c489]) by smtp.gmail.com with ESMTPSA id g20-20020a05600c311400b0041bf685921dsm1319393wmo.0.2024.05.02.02.30.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 May 2024 02:30:34 -0700 (PDT) Message-ID: Subject: Re: [PATCH net] ax25: Fix refcount leak issues of ax25_dev From: Paolo Abeni To: Dan Carpenter , duoming@zju.edu.cn Cc: linux-hams@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kuba@kernel.org, edumazet@google.com, davem@davemloft.net, jreuter@yaina.de, lars@oddbit.com, Miroslav Skoric Date: Thu, 02 May 2024 11:30:32 +0200 In-Reply-To: <8767454a-2d5a-4c6d-b887-440047c9bc5b@moroto.mountain> References: <20240501060218.32898-1-duoming@zju.edu.cn> <7fcfdc9a-e3f3-49a1-9373-39b5ad745799@moroto.mountain> <1402dfc8.20a4b.18f37963e87.Coremail.duoming@zju.edu.cn> <8767454a-2d5a-4c6d-b887-440047c9bc5b@moroto.mountain> Autocrypt: addr=pabeni@redhat.com; prefer-encrypt=mutual; keydata=mQINBGISiDUBEAC5uMdJicjm3ZlWQJG4u2EU1EhWUSx8IZLUTmEE8zmjPJFSYDcjtfGcbzLPb63BvX7FADmTOkO7gwtDgm501XnQaZgBUnCOUT8qv5MkKsFH20h1XJyqjPeGM55YFAXc+a4WD0YyO5M0+KhDeRLoildeRna1ey944VlZ6Inf67zMYw9vfE5XozBtytFIrRyGEWkQwkjaYhr1cGM8ia24QQVQid3P7SPkR78kJmrT32sGk+TdR4YnZzBvVaojX4AroZrrAQVdOLQWR+w4w1mONfJvahNdjq73tKv51nIpu4SAC1Zmnm3x4u9r22mbMDr0uWqDqwhsvkanYmn4umDKc1ZkBnDIbbumd40x9CKgG6ogVlLYeJa9WyfVMOHDF6f0wRjFjxVoPO6p/ZDkuEa67KCpJnXNYipLJ3MYhdKWBZw0xc3LKiKc+nMfQlo76T/qHMDfRMaMhk+L8gWc3ZlRQFG0/Pd1pdQEiRuvfM5DUXDo/YOZLV0NfRFU9SmtIPhbdm9cV8Hf8mUwubihiJB/9zPvVq8xfiVbdT0sPzBtxW0fXwrbFxYAOFvT0UC2MjlIsukjmXOUJtdZqBE3v3Jf7VnjNVj9P58+MOx9iYo8jl3fNd7biyQWdPDfYk9ncK8km4skfZQIoUVqrWqGDJjHO1W9CQLAxkfOeHrmG29PK9tHIwARAQABtB9QYW9sbyBBYmVuaSA8cGFiZW5pQHJlZGhhdC5jb20+iQJSBBMBCAA8FiEEg1AjqC77wbdLX2LbKSR5jcyPE6QFAmISiDUCGwMFCwkIBwIDIgIBBhUKCQgLAgQWAgMBAh4HAheAAAoJECkkeY3MjxOkJSYQAJcc6MTsuFxYdYZkeWjW//zbD3ApRHzpNlHLVSuJqHr9/aDS+tyszgS8jj9MiqALzgq4iZbg 7ZxN9ZsDL38qVIuFkSpgMZCiUHdxBC11J8nbBSLlpnc924UAyr5XrGA99 6Wl5I4Km3128GY6iAkH54pZpOmpoUyBjcxbJWHstzmvyiXrjA2sMzYjt3Xkqp0cJfIEekOi75wnNPofEEJg28XPcFrpkMUFFvB4Aqrdc2yyR8Y36rbw18sIX3dJdomIP3dL7LoJi9mfUKOnr86Z0xltgcLPGYoCiUZMlXyWgB2IPmmcMP2jLJrusICjZxLYJJLofEjznAJSUEwB/3rlvFrSYvkKkVmfnfro5XEr5nStVTECxfy7RTtltwih85LlZEHP8eJWMUDj3P4Q9CWNgz2pWr1t68QuPHWaA+PrXyasDlcRpRXHZCOcvsKhAaCOG8TzCrutOZ5NxdfXTe3f1jVIEab7lNgr+7HiNVS+UPRzmvBc73DAyToKQBn9kC4jh9HoWyYTepjdcxnio0crmara+/HEyRZDQeOzSexf85I4dwxcdPKXv0fmLtxrN57Ae82bHuRlfeTuDG3x3vl/Bjx4O7Lb+oN2BLTmgpYq7V1WJPUwikZg8M+nvDNcsOoWGbU417PbHHn3N7yS0lLGoCCWyrK1OY0QM4EVsL3TjOfUtCNQYW9sbyBBYmVuaSA8cGFvbG8uYWJlbmlAZ21haWwuY29tPokCUgQTAQgAPBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEoitAhsDBQsJCAcCAyICAQYVCgkICwIEFgIDAQIeBwIXgAAKCRApJHmNzI8TpBzHD/45pUctaCnhee1vkQnmStAYvHmwrWwIEH1lzDMDCpJQHTUQOOJWDAZOFnE/67bxSS81Wie0OKW2jvg1ylmpBA0gPpnzIExQmfP72cQ1TBoeVColVT6Io35BINn+ymM7c0Bn8RvngSEpr3jBtqvvWXjvtnJ5/HbOVQCg62NC6ewosoKJPWpGXMJ9SKsVIOUHsmoWK60spzeiJoSmAwm3zTJQnM5kRh2q iWjoCy8L35zPqR5TV+f5WR5hTVCqmLHSgm1jxwKhPg9L+GfuE4d0SWd84y GeOB3sSxlhWsuTj1K6K3MO9srD9hr0puqjO9sAizd0BJP8ucf/AACfrgmzIqZXCfVS7jJ/M+0ic+j1Si3yY8wYPEi3dvbVC0zsoGj9n1R7B7L9c3g1pZ4L9ui428vnPiMnDN3jh9OsdaXeWLvSvTylYvw9q0DEXVQTv4/OkcoMrfEkfbXbtZ3PRlAiddSZA5BDEkkm6P9KA2YAuooi1OD9d4MW8LFAeEicvHG+TPO6jtKTacdXDRe611EfRwTjBs19HmabSUfFcumL6BlVyceIoSqXFe5jOfGpbBevTZtg4kTSHqymGb6ra6sKs+/9aJiONs5NXY7iacZ55qG3Ib1cpQTps9bQILnqpwL2VTaH9TPGWwMY3Nc2VEc08zsLrXnA/yZKqZ1YzSY9MGXWYLkCDQRiEog1ARAAyXMKL+x1lDvLZVQjSUIVlaWswc0nV5y2EzBdbdZZCP3ysGC+s+n7xtq0o1wOvSvaG9h5q7sYZs+AKbuUbeZPu0bPWKoO02i00yVoSgWnEqDbyNeiSW+vI+VdiXITV83lG6pS+pAoTZlRROkpb5xo0gQ5ZeYok8MrkEmJbsPjdoKUJDBFTwrRnaDOfb+Qx1D22PlAZpdKiNtwbNZWiwEQFm6mHkIVSTUe2zSemoqYX4QQRvbmuMyPIbwbdNWlItukjHsffuPivLF/XsI1gDV67S1cVnQbBgrpFDxN62USwewXkNl+ndwa+15wgJFyq4Sd+RSMTPDzDQPFovyDfA/jxN2SK1Lizam6o+LBmvhIxwZOfdYH8bdYCoSpqcKLJVG3qVcTwbhGJr3kpRcBRz39Ml6iZhJyI3pEoX3bJTlR5Pr1Kjpx13qGydSMos94CIYWAKhegI06aTdvvuiigBwjngo/Rk5S+iEGR5KmTqGyp27o6YxZy6D4NIc6PKUzhIUxfvuHNvfu sD2W1U7eyLdm/jCgticGDsRtweytsgCSYfbz0gdgUuL3EBYN3JLbAU+UZpy v/fyD4cHDWaizNy/KmOI6FFjvVh4LRCpGTGDVPHsQXaqvzUybaMb7HSfmBBzZqqfVbq9n5FqPjAgD2lJ0rkzb9XnVXHgr6bmMRlaTlBMAEQEAAYkCNgQYAQgAIBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEog1AhsMAAoJECkkeY3MjxOkY1YQAKdGjHyIdOWSjM8DPLdGJaPgJdugHZowaoyCxffilMGXqc8axBtmYjUIoXurpl+f+a7S0tQhXjGUt09zKlNXxGcebL5TEPFqgJTHN/77ayLslMTtZVYHE2FiIxkvW48yDjZUlefmphGpfpoXe4nRBNto1mMB9Pb9vR47EjNBZCtWWbwJTIEUwHP2Z5fV9nMx9Zw2BhwrfnODnzI8xRWVqk7/5R+FJvl7s3nY4F+svKGD9QHYmxfd8Gx42PZc/qkeCjUORaOf1fsYyChTtJI4iNm6iWbD9HK5LTMzwl0n0lL7CEsBsCJ97i2swm1DQiY1ZJ95G2Nz5PjNRSiymIw9/neTvUT8VJJhzRl3Nb/EmO/qeahfiG7zTpqSn2dEl+AwbcwQrbAhTPzuHIcoLZYV0xDWzAibUnn7pSrQKja+b8kHD9WF+m7dPlRVY7soqEYXylyCOXr5516upH8vVBmqweCIxXSWqPAhQq8d3hB/Ww2A0H0PBTN1REVw8pRLNApEA7C2nX6RW0XmA53PIQvAP0EAakWsqHoKZ5WdpeOcH9iVlUQhRgemQSkhfNaP9LqR1XKujlTuUTpoyT3xwAzkmSxN1nABoutHEO/N87fpIbpbZaIdinF7b9srwUvDOKsywfs5HMiUZhLKoZzCcU/AEFjQsPTATACGsWf3JYPnWxL9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2024-05-02 at 10:56 +0300, Dan Carpenter wrote: > On Thu, May 02, 2024 at 12:35:44PM +0800, duoming@zju.edu.cn wrote: > > On Wed, 1 May 2024 20:43:37 +0300 Dan Carpenter wrote: > > > I'm always happy to take credit for stuff but the Reported by should = go > > > to Lars and Miroslav. > > >=20 > > > Reported-by: Lars Kellogg-Stedman > > > Reported-by: Miroslav Skoric > >=20 > > This patch is not related with the problem raised by Lars Kellogg-Stedm= an > > and Miroslav Skoric, it only solves the reference counting leak issues = of > > ax25_dev in ax25_addr_ax25dev() and ax25_dev_device_down(). So I think > > there is no need to change the "Reported by" label. > >=20 >=20 > Ah... I was really hoping it was related to the other bugs. >=20 > Okay, what about we separate this into different patches one for each > bug? The changes to ax25_addr_ax25dev() and ax25_dev_free() are > obvious and could go in as-is but as two separate patches. I agree it would be better to split this up, the changelog itself hints at 2 separated issues and fixes. Thanks, Paolo