Received: by 2002:ab2:60d1:0:b0:1f7:5705:b850 with SMTP id i17csp1012699lqm; Thu, 2 May 2024 02:35:50 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWQpdMTdaV11Ca3rojvYu5oWIJ/3rD7AytCOKS0mG9TKioO9CU1XAU8qSRGaY/O88T6cu6keaiahTQy7sy2LbP/fc0RzNnYACodnH9whw== X-Google-Smtp-Source: AGHT+IEkDRpgM/RpBuUJrLZCRnvKC/inkkHuw3P/R1MJEVIbekBYPzd04zE9ZydpwatzmO5LKSQe X-Received: by 2002:a17:903:11d1:b0:1ea:c7a4:7e8 with SMTP id q17-20020a17090311d100b001eac7a407e8mr6193847plh.17.1714642550116; Thu, 02 May 2024 02:35:50 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714642550; cv=pass; d=google.com; s=arc-20160816; b=QFVSga8XbYoe1IfEzJ4srOvpsnO/b7r3DXQa11GTSvMnwV1XpECpgLW1BIy20vWYRy K4m8KEYx2DUhPBiGEkbP2tum64cMlPuVHnT4N2vdDdCR/VyuKIfxL26e6PPeCaI7A7lH uIOrbLurmKtZBMzCbkiThqkxZQ/zDNq0KRfgF8ZIGTbKtTDkMQc3+Uf4mKMv4xKRXYCO xIUBucNcm9Gfyg1ZtOWpsvQqeWl30e6Pd/p7IAVhe7zWJ9XnUb6Lha/sBu8UMjWHNUDr 4qH1SxJfQmfZeK6LFUvsGzFQK3Sx3N4V41z97ZQ91sUpB5E6I9plt/8pD9qGUh5bi8o8 iQ5w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=lMAHLByFFJca6Bkpar8TdnkWM0cdcHjkiG1WGbqxIV0=; fh=I33HJ3JnIf2S52t76+QyTSWH2k+gyzrAHbcgbwBcb2o=; b=nxEFtL6zp9cZfr3Q04fizu/FOqXTQvn8gGOA9qu/S2EgE3EJXvsraWp7uJ+Hn42vdq 7hxEmLHLeAtc033m1Iy/pmCy0nwVBMqozhdlDfWDDfnQT/YGFoNiFF9DP3JyqGXPDlaC afmg8+A1sqacIOaFzz1DwAtqA02ZwOccC180y91QVJErfdSBvYJ9g0TnOSaPMgdqTl8w yGKdG4xQthd+Iw8LAXCIOf7n1ix/Yq8ceuolSmZ62kBKFaItRY4JJ1oz+9KdF14V6ZU1 fuLBKNjph5MLL+GAfuexzfmbqrZUPftFClg3jnKL61zTKXNjoE0gdri54USKtIepM8Wf iJsw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=K7eDk5ZE; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-166230-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-166230-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id w12-20020a170902ca0c00b001eb7d579646si647626pld.135.2024.05.02.02.35.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 May 2024 02:35:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-166230-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=K7eDk5ZE; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-166230-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-166230-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4EDC1282318 for ; Thu, 2 May 2024 09:33:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2D3B555C29; Thu, 2 May 2024 09:33:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="K7eDk5ZE" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 562305380F; Thu, 2 May 2024 09:33:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714642401; cv=none; b=dXJOKRRIs8QiImMNHzViGDTAN/+sHyVeXbvYbjVy+cUHp9EnAxIx32blgdk/hZGops5qOVWw8h1rXsG7FwrPX7ehP4AVe/CLBdvyhCU7ByivFpu74fmy9vg5rOGzVXsJWrt+O/be1jH7ccK+6w/za4DPh31DOVf4DGffyNtLwS0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714642401; c=relaxed/simple; bh=QlsdmKpd21bpE2nPFn1lTOkv/zm66ev9mTVi+iaa42U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cKDEP7XjmLJLKmpsYtrLbLAKIrofBLfXo3wquznl0kq/ZrHYnG2tde4rLY/s9pcp85EbwaFi4wnkGIl0L8u1pO3D9Wx+UvUi+vzrMoCUefbdHi5vbSRE7j+WdA2+P7VsaiWkw1DiKNz9KCdoI5CtxB0WeSzpG7guqbO478NRw7U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=K7eDk5ZE; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F52AC113CC; Thu, 2 May 2024 09:33:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714642400; bh=QlsdmKpd21bpE2nPFn1lTOkv/zm66ev9mTVi+iaa42U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=K7eDk5ZEubI7BxmvceOMCCQa++3rEHZqXYDnHndm3urWNZfplWyWJr+p17L/DKOm3 gxeYK6jkryX1VijxmLGufbVDcVd1X7P+2AzmNI5SXvPQLXnEA6O7UiTwqHY7BSkthS ixnfWcz/27nbYHGPtJACwT3YE137o1xvuEDNsEAOc0+vbQfj72dZ66Bv4OmWttOlxS YnHqje7VX22PFfFeik2DdS7hTV5cSRf535frmEChJIeuk6rIybj444QkdFdpJdGw2A s1X37Gu/KHuw4Y2u6DcN1Wuem8A+YKCBty5NGHI53fk+94jjzALjg9LlmeCoe8/e4a yAHvXTueBidvw== Date: Thu, 2 May 2024 10:33:16 +0100 From: Lee Jones To: Markus Elfring Cc: wangkaiyuan@inspur.com, kernel-janitors@vger.kernel.org, Chen-Yu Tsai , LKML Subject: Re: [PATCH] mfd: axp20x: convert to use maple tree register cache Message-ID: <20240502093316.GI5338@google.com> References: <20240429024547.27724-1-wangkaiyuan@inspur.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, 29 Apr 2024, Markus Elfring wrote: > > The maple tree register cache is based on a much more modern data structure > > than the rbtree cache and makes optimisation choices which are probably > > more appropriate for modern systems than those made by the rbtree cache. > > Please choose another imperative wording for an improved change description. > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc5#n94 This review comment is seldom helpful. You may as well stop using it. -- Lee Jones [李琼斯]