Received: by 2002:ab2:60d1:0:b0:1f7:5705:b850 with SMTP id i17csp1013017lqm; Thu, 2 May 2024 02:36:37 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWcXTMl92GvFp+pKfxboy5e+lQJ18g3wCJyOgcabttnpT1lW/jBHWo1OOVstykiiwF1L1Og95lQMA6PUccF18Vf5gaxFHSAB3LTf1V0ug== X-Google-Smtp-Source: AGHT+IHm3YC1KeJwC9cU2XFnwv2vTCsDNeg4ZHREz2355IE73LtWoA/vcq6Yg24Mi8c61MEwamhF X-Received: by 2002:a17:907:bb98:b0:a51:ddc6:f9c0 with SMTP id xo24-20020a170907bb9800b00a51ddc6f9c0mr1096485ejc.45.1714642597085; Thu, 02 May 2024 02:36:37 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714642597; cv=pass; d=google.com; s=arc-20160816; b=k8W9LQfzVDQbWgAuFghaStGYFLnbk/eS6Dupn1pTbIgQQ2xkr9yZjg6gV69MPwfhbB 8n9Jg2BU3fq+HBiVm75QsIgJg6O55HtaiyvyeoEKGljBPAWiJrs5OAsg/os1aCgvz9As Z5Q2f3OoRXUUKL3EP3llTcAf1eU20pg6VQHhaL+8dMOEH2F1SIPFgQ+0hSgxiknPmjfz AtnLIbqq7yVkSm1y8/8GUXjpaLFwDm1X7HOlCMciQvhkNFZgbOV9NKqa9b4rIhBWrSz7 mlaKMTCVdO2nG4S/IIQuPqM03pZUNe8+ARTHk//Ubtp/uxQyv2S7kqANxQ41cR0uN5Ms yxuw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=6t+xGFEye0atqio65JT6PIitLTa+AeZeBsHriCvvtuY=; fh=6EMyAhjWIqbyw4IwPUmLGvsuJJyXQCz8s/vVR55Npew=; b=XUC0M+meYKu9jtxIOmOIWrYpWmDRVtI78wbRvU0UvDBhkRtzPgOAWPPiw3Dw/RlXV2 PRJHR/vgFqYL+CbJY8Aysr/G2l4xmps7xW4C5BQuWCVqFpCeR4hGq8lnuOBUa4Q5Xkos WK6uFkQ6KXkX0GD7wH7o5jehzsVVDHlyg7T+/hyRe+Q53dJzIs7eG4YaWKBn6FD0lm7e UNNRF20WIfz6TP/CFn43Y2N+FqNXNcBqC7SyQ+NvG8zfEAkBGOMWBwkQqqJyDVkG6ye/ JWExm6FPxiTFTtKoYP8kzjhO7aqQOdBt0CySuQxSN8iLPOwiIQF0dOQs017OsegXBEkA 2wYA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AHHbkWFY; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-166233-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-166233-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id gs24-20020a170906f19800b00a580302d546si324309ejb.878.2024.05.02.02.36.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 May 2024 02:36:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-166233-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AHHbkWFY; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-166233-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-166233-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id CAF721F21639 for ; Thu, 2 May 2024 09:36:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0D08055C1A; Thu, 2 May 2024 09:36:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AHHbkWFY" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33872548E7; Thu, 2 May 2024 09:36:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714642589; cv=none; b=n1trFi6N/JTC+K0awBYQJv3i8CUfNo8mmGc9biwxdggG9oXRkM1eibaaFInnE1bcvzODuyT/jvksZj+7C28Qjv0PyxNGxFUbmrYwRTPgm5R+hJ6reaKSdbWSyRTpjOEhvJPJJvBB0X3wfB675Pnmbk50BkHsnJPu2h7YQo+Lv60= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714642589; c=relaxed/simple; bh=92VZfd5MbP7gUyNvWNYUCKmDjm4qFnwsQ27VX0zyuGw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qdUSqgIMiZl/i7qHVgrxfXUAWHolTpKyw5vTltcQ1CIGKd/VQgJvJab13y+BtOSeDCZ2rekxMpf3rrDbNuC+wT6sCO6wkzp4ZwWBT53BjTVn5B5GtSBce2QRqFGm9gi1PFgE5OLWjN9VMO7JmjLJPJPWpKo1Y0bJ24+6C/BKaFg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AHHbkWFY; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8AA35C113CC; Thu, 2 May 2024 09:36:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714642588; bh=92VZfd5MbP7gUyNvWNYUCKmDjm4qFnwsQ27VX0zyuGw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AHHbkWFYGXuKehF59l+08AI4Ps88TEcMSkY5b2JwplXbRYC7gIY1D6ZWr84d6t56B jCTzvLnx9p4fwUhRoag62QB/CW/5VMWljKphY2RdvDD1kjb964RR4n19/N7wtc5aVN 8Nvk4qyP2ikeIGPVGMt+Ff2ZbZxjMiAqhJZrzfiwpvezO34waWIJNdhnTSmvETahLG CuBI1373h1TJeDQEU2li3Hke0JdDH5Po3vivXdjUdKoNPPsFw/rsmFnC3sNhJH0F2X +lX5WN2yhfCUMtdmaQsiG77RyEh45cOPuCyHWmp4Dyr4DXNLqsz8uEGQJgIwxk+hwc 61Mx0v1nKNPrw== Date: Thu, 2 May 2024 10:36:23 +0100 From: Lee Jones To: Shresth Prasad Cc: daniel.thompson@linaro.org, jingoohan1@gmail.com, deller@gmx.de, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, javier.carrasco.cruz@gmail.com, skhan@linuxfoundation.org, julia.lawall@inria.fr Subject: Re: [PATCH v3][next] backlight: sky81452-backlight: Remove unnecessary call to of_node_get Message-ID: <20240502093623.GJ5338@google.com> References: <20240502063621.65687-2-shresthprasad7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240502063621.65687-2-shresthprasad7@gmail.com> On Thu, 02 May 2024, Shresth Prasad wrote: > `dev->of_node` already has a reference to the device_node and calling > of_node_get on it is unnecessary. All conresponding calls to > of_node_put are also removed. > > Reviewed-by: Daniel Thompson > Signed-off-by: Shresth Prasad > --- > Changes in v3: > - Remove unnecessary braces > > drivers/video/backlight/sky81452-backlight.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) No idea what you're talking about. This patch/version doesn't exist in either my inbox or LORE: https://lore.kernel.org/all/?q=%22%5BPATCH+v3%5D%5Bnext%5D+backlight%3A+sky81452-backlight%3A+Remove+unnecessary+call+to+of_node_get%22 -- Lee Jones [李琼斯]