Received-SPF: pass (google.com: domain of linux-kernel+bounces-166237-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240502084609.28376-1-ryncsn@gmail.com> <20240502084939.30250-4-ryncsn@gmail.com>
 <7636ada9-fdf0-4796-ab83-9ac60a213465@redhat.com> <CAMgjq7CD=r9TP4PSe2MqR=r-+PnMB-N6yYbFRr9U=B5ZBvTPtA@mail.gmail.com>
In-Reply-To: <CAMgjq7CD=r9TP4PSe2MqR=r-+PnMB-N6yYbFRr9U=B5ZBvTPtA@mail.gmail.com>
From: Kairui Song <ryncsn@gmail.com>
Date: Thu, 2 May 2024 17:38:04 +0800
Message-ID: <CAMgjq7CPkHLauHfaDweoGUHxLxvkj4Vb1hEbw==oWa6aGgSTpg@mail.gmail.com>
Subject: Re: [PATCH v4 11/12] mm: drop page_index and convert folio_index to
 use folio
To: David Hildenbrand <david@redhat.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>, 
	"Huang, Ying" <ying.huang@intel.com>, Matthew Wilcox <willy@infradead.org>, Chris Li <chrisl@kernel.org>, 
	Barry Song <v-songbaohua@oppo.com>, Ryan Roberts <ryan.roberts@arm.com>, Neil Brown <neilb@suse.de>, 
	Minchan Kim <minchan@kernel.org>, Hugh Dickins <hughd@google.com>, 
	Yosry Ahmed <yosryahmed@google.com>, linux-fsdevel@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, May 2, 2024 at 5:32=E2=80=AFPM Kairui Song <ryncsn@gmail.com> wrote=
:
>
> On Thu, May 2, 2024 at 5:12=E2=80=AFPM David Hildenbrand <david@redhat.co=
m> wrote:
> >
> > On 02.05.24 10:49, Kairui Song wrote:
> > > From: Kairui Song <kasong@tencent.com>
> > >
> > > There are two helpers for retrieving the index within address space
> > > for mixed usage of swap cache and page cache:
> > >
> > > - page_index
> > > - folio_index (wrapper of page_index)
> > >
> > > This commit drops page_index, as we have eliminated all users, and
> > > converts folio_index to use folio internally.
> >
> > The latter does not make sense. folio_index() already is using a folio
> > internally. Maybe a leftover from reshuffling/reworking patches?
>
> Hi, David,
>
> folio_index calls swapcache_index, and swapcache_index is defined as:
>
> #define swapcache_index(folio) __page_file_index(&(folio)->page)
>
> Where it casts the folio to page first, then call __page_file_index,
> __page_file_index is a function and works on pages.
>
> After this commit __page_file_index is converted to
> __folio_swap_cache_index. This change is a bit of trivial but we get
> rid of the internal page conversion.
>
> I can simplify the commit message, just say drop page_index to make
> the code cleaner, if this is confusing.

Ah, you are right folio_index is not a simple wrapper of page_index
indeed, that sentence in the commit message doesn't make sense, so it
should be deleted, my bad for this leftover.