Received-SPF: pass (google.com: domain of linux-kernel+bounces-166247-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240501233201.work.732-kees@kernel.org>
In-Reply-To: <20240501233201.work.732-kees@kernel.org>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Thu, 2 May 2024 12:45:33 +0300
Message-ID: <CAHp75VetkKYhnOaoM880D+VTR96NscQfBGddgAwKz681Uk5ZJg@mail.gmail.com>
Subject: Re: [PATCH] string: Add additional __realloc_size() annotations for
 "dup" helpers
To: Kees Cook <keescook@chromium.org>
Cc: Andy Shevchenko <andy@kernel.org>, linux-hardening@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, May 2, 2024 at 2:32=E2=80=AFAM Kees Cook <keescook@chromium.org> wr=
ote:
>
> Several other "dup"-style interfaces could use the __realloc_size()
> attribute. (As a reminder to myself and others: "realloc" is used here
> instead of "alloc" because the "alloc_size" attribute implies that the
> memory contents are uninitialized. Since we're copying contents into the
> resulting allocation, it must use "realloc_size" to avoid confusing the
> compiler's optimization passes.)
>
> Add KUnit test coverage where possible. (KUnit still does not have the
> ability to manipulate userspace memory.)

Makes sense to me,
Reviewed-by: Andy Shevchenko <andy@kernel.org>

..

> +               checker(len, kmemdup_array(test_phrases[idx], len, 1,   \
> +                                          gfp), kfree(p));             \

Despite being longer, I would put gfp on the previous line for the
sake of logical split (and additionally to be consistent with the
below).

> +               checker(len, kmemdup(test_phrases[idx], len, gfp),      \
> +                       kfree(p));                                      \

--=20
With Best Regards,
Andy Shevchenko