Received: by 2002:ab2:60d1:0:b0:1f7:5705:b850 with SMTP id i17csp1025466lqm; Thu, 2 May 2024 03:03:41 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXeILkAnyx+xfar/Bh4VGYSEbi+jVk0USqxmlnGf77ICFO1et7RIxCKFfESXBRNhMwlET+CMZWSR+A4Mu2MtKs8XaqQs+bJpoE0mX03uQ== X-Google-Smtp-Source: AGHT+IEfyzJVPivu0sKxjXmzPnv4fD+QmbfJoImWakFM6qr9UBiG9YzB6oUTuOQUB7GxUU5nXwRe X-Received: by 2002:a17:906:f743:b0:a52:143c:1901 with SMTP id jp3-20020a170906f74300b00a52143c1901mr995686ejb.22.1714644221255; Thu, 02 May 2024 03:03:41 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714644221; cv=pass; d=google.com; s=arc-20160816; b=ZrFj4ZxGbJXtGS1vZ+E5vo+xPlMk2iP8pWBdBxTPBdxZ2uUqg5Lp5NCJGYfOnSGbEK ovie8d91ve9YP15V98IVfTQpOydGKfWjx0ICUGGveWQ2OyUrwuWpmjpfa062lWdjlnqQ DX5qHH0nj2itDWM1SqT7ebhHjDvLlVvohaKvTboGwrddRbWK5r40uZovS6/Ho0Ddi6sS nF4mmjoI6S99xCVNVURZ3iVc6kWOHRYZfBf3soWH9p1fqLKCapJyS83fclK8j7v4JZIF LUz0GTAUIX6bqBGAc4YzzBMjhfY/W7oV/QDeVdILt7qatKfky8CYqet5f1/qbInWJmzv s/qA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=3jlTYG9vHv+Kk/nSExLseCcWYaSQ+I1BuCKbKEGymUY=; fh=KaOkeYukQPoPWqEKpP6YZ4lEkZbvEgbbQq4zunMA7bk=; b=ra8S+MJetc4AJ9Yi0giROIOeq3jCKUNBvrhSrmN7/JTZ6JtsZb2jJeA0wPtAYdoye4 kO/CAeiEpRjriSoBZwsN6+EPWs5cA9DJ3Sj26BZO4CIPN07Hq7FScyjOun+XJsblN5tp OAnTeauX+A2XgGc4oFw1E5KqYYHOnQ0THRZZeW1XoNqo56DBcdoXLA/Au/N+VimPESrw NVh1wCLW8YB4pT4DSfrI+4YEGpG4QypksR4E0tG99PxUeQjTpaGT41jo+0WPtw50kQcB 9SNr7aMCPiZGnCC7up5MJOvRxjeK9NvhL6JESCMY0O7EWOai6jgeuwD38v7pDoggMkuN gdKg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=YRvn94sq; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-166276-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-166276-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id k15-20020a170906a38f00b00a592e0da1dcsi351449ejz.556.2024.05.02.03.03.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 May 2024 03:03:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-166276-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=YRvn94sq; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-166276-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-166276-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id C12DA1F26023 for ; Thu, 2 May 2024 10:02:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7F89981AAA; Thu, 2 May 2024 10:00:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YRvn94sq" Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 593027E78B; Thu, 2 May 2024 10:00:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714644016; cv=none; b=TNSyRL5UyB4RXEdMO0OrI7bNCri8f1mxjA61tZPENOfF5uvvR9CUHcSpL881VvSdh7uuGjfm1YjwJhorGOdyk0kg64O0o6/d4WQsUpjaoT2E1stghos6DEyxxIpSLDJVkUW0/o4lEtnLetzW1F2jeLDukxCjWWMaHLrFAeWAd28= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714644016; c=relaxed/simple; bh=fJvZHbOPkBkkNJqfU75CqmF54s9MzQdiRJ33DhOwPoA=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=k7fpAmcZNjFg5DAvZpdFH1E9iTGwwgQyPvbxU7x2FkUCDJdKZgMEQ9jYhODoQxFCrrtdAiN5JjnlY2qvpRVGmcnvjVTGwsqLzzlcwc8/tRVBMXvw2jxf15oo51wY0STNRCF27JGKcHbtfE15mbcqE/IiVTuCNMfaGGHFPfkyGxU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YRvn94sq; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-2b239b5fedaso2833068a91.0; Thu, 02 May 2024 03:00:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714644015; x=1715248815; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=3jlTYG9vHv+Kk/nSExLseCcWYaSQ+I1BuCKbKEGymUY=; b=YRvn94sq1U1eGSKGcY0/8d0sdBTrjf4LU4MoCHKDb7Ytyio6I8ZlhvmGLKqcEcvRwW 9NvIpXNcFF5qTnD4rqTfHz3EdIxb6OyPKgihpvJ79wMmTVZkl05Sm3jL36M7ZC4gQ+d6 /5Aul9fWCv1SkvHBFfxxib/XoMP0ZAJ5fzK0PDfN0SiDGDuUYdagEB49oRTqomDw0GrA DWUOJpcqoFkYMp/qvmUG5HpFWl7RtnRvuAUPCdG2pHqf9zG6pfMe3Ms3H1Jl3zrDEiqn temYLCrrpAbx8DVPRztWHYxEjDX723kJ92k+CqBqNCpvBJpS/s/IVX2Mq/JJPuVtOFx/ yi7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714644015; x=1715248815; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3jlTYG9vHv+Kk/nSExLseCcWYaSQ+I1BuCKbKEGymUY=; b=IcqsdWHHvxB8sPWY3ZQOejgsb8GyQikTgPt+NCSnTkeK1W23mqHuk2uFQkmVbVVUCZ KizuLngm8Xvm+qin2402lWbU/8B1j5JdY47DAIIrE5AyyD4Z7k41DZUcnRnWnxoLFSXk n3DmtQ5KxFELXS7m5n4f1e17iOXnQ30/XUGAaByC8DzdvpL48FbNl67mwPKnvJHL+wg9 s0EvJagcK+MfYu/VBKDtkly6CPx+vsRakfRcykM6kg8JJwHa3ZGbHbkMmW2HTagmw/hH 0otYXp93ZiskfaW3vS/6gqusmkaDgOTbAUBo2EOVYoIexMnWHD9dFY9/6vo9CtepVj8Q dssQ== X-Forwarded-Encrypted: i=1; AJvYcCXazAeTLGOGHUjpujFi+tCJkPVdj0Q9SpX8QncKXTKHYkjiVcT8deckCjlL5K4D6Lg9tQ6MfdQLD7XkloNgku3ewW7cLYt0O9XTrjzSqRrqboQOAg3LjbrNoaSMmI5kqxAqQmG5GSMkOzw= X-Gm-Message-State: AOJu0YwfURdwibVUkpyCmGAqMq7lkk8vqArCTHinVhxHYUuZ/E3S+IPa mHdv6PRpjYqiI8RECc/2HzKyX8cBbq+6AZ60NTVJqbhKFbsZjw++Hj0Gh9HpUilp255vk/O6uC0 M7EhBAU6tMzm3VnfBLKc7mNLDV4E= X-Received: by 2002:a17:90b:3d6:b0:2a6:c503:95f2 with SMTP id go22-20020a17090b03d600b002a6c50395f2mr4930182pjb.16.1714644013879; Thu, 02 May 2024 03:00:13 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240502063621.65687-2-shresthprasad7@gmail.com> <20240502093623.GJ5338@google.com> In-Reply-To: <20240502093623.GJ5338@google.com> From: Shresth Prasad Date: Thu, 2 May 2024 15:30:02 +0530 Message-ID: Subject: Re: [PATCH v3][next] backlight: sky81452-backlight: Remove unnecessary call to of_node_get To: Lee Jones Cc: daniel.thompson@linaro.org, jingoohan1@gmail.com, deller@gmx.de, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, javier.carrasco.cruz@gmail.com, skhan@linuxfoundation.org, julia.lawall@inria.fr Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, May 2, 2024 at 3:06=E2=80=AFPM Lee Jones wrote: > > On Thu, 02 May 2024, Shresth Prasad wrote: > > > `dev->of_node` already has a reference to the device_node and calling > > of_node_get on it is unnecessary. All conresponding calls to > > of_node_put are also removed. > > > > Reviewed-by: Daniel Thompson > > Signed-off-by: Shresth Prasad > > --- > > Changes in v3: > > - Remove unnecessary braces > > > > drivers/video/backlight/sky81452-backlight.c | 8 ++------ > > 1 file changed, 2 insertions(+), 6 deletions(-) > > No idea what you're talking about. > > This patch/version doesn't exist in either my inbox or LORE: > > https://lore.kernel.org/all/?q=3D%22%5BPATCH+v3%5D%5Bnext%5D+backlight%= 3A+sky81452-backlight%3A+Remove+unnecessary+call+to+of_node_get%22 > > -- > Lee Jones [=E6=9D=8E=E7=90=BC=E6=96=AF] I'm not sure what you mean. The patches show up just fine: https://lore.kernel.org/all/?q=3Dbacklight%3A+sky81452-backlight%3A+Remove+= unnecessary+call+to+of_node_get If you mean that the first version doesn't show up, it's because the commit message was changed to better reflect changes. Regards, Shresth