Received-SPF: pass (google.com: domain of linux-kernel+bounces-166281-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <46e4000b-e588-d1b7-153e-047ed565565a@quicinc.com>
Date: Thu, 2 May 2024 15:35:25 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH v3 1/2] dt-bindings: clock: qcom: Add AHB clock for SM8150
Content-Language: en-US
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
CC: Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio
	<konrad.dybcio@linaro.org>,
        Rob Herring <robh@kernel.org>,
        "Krzysztof
 Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley
	<conor+dt@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>,
        "Stephen
 Boyd" <sboyd@kernel.org>,
        Ajit Pandey <quic_ajipan@quicinc.com>,
        Imran Shaik
	<quic_imrashai@quicinc.com>,
        Taniya Das <quic_tdas@quicinc.com>,
        "Jagadeesh
 Kona" <quic_jkona@quicinc.com>,
        <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>
References: <20240501-videocc-sm8150-dt-node-v3-0-2c4bd9ef48bd@quicinc.com>
 <20240501-videocc-sm8150-dt-node-v3-1-2c4bd9ef48bd@quicinc.com>
 <CAA8EJpotvs3AOYO3ct=_JabBdYDops4Yfdutga9KBAbVPoZ5yw@mail.gmail.com>
From: "Satya Priya Kakitapalli (Temp)" <quic_skakitap@quicinc.com>
In-Reply-To: <CAA8EJpotvs3AOYO3ct=_JabBdYDops4Yfdutga9KBAbVPoZ5yw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 5/1/2024 5:36 PM, Dmitry Baryshkov wrote:
> On Wed, 1 May 2024 at 11:32, Satya Priya Kakitapalli
> <quic_skakitap@quicinc.com> wrote:
>> SM8150 videocc needs AHB clock, so update the bindings for sm8150
>> to add the AHB clock.
>>
>> Fixes: 35d26e9292e2 ("dt-bindings: clock: Add YAML schemas for the QCOM VIDEOCC clock bindings")
> The tag is incorrect. The mentioned commit didn't add sm8150 bindings,
> so it didn't have a bug.


Thanks, will correct the tag.


>> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
>> ---
>>   .../devicetree/bindings/clock/qcom,videocc.yaml         | 17 ++++++++++++++++-
>>   1 file changed, 16 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
>> index 6999e36ace1b..68bac801adb0 100644
>> --- a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
>> +++ b/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
>> @@ -75,7 +75,6 @@ allOf:
>>             enum:
>>               - qcom,sc7180-videocc
>>               - qcom,sdm845-videocc
>> -            - qcom,sm8150-videocc
>>       then:
>>         properties:
>>           clocks:
>> @@ -101,6 +100,22 @@ allOf:
>>               - const: bi_tcxo
>>               - const: bi_tcxo_ao
>>
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          enum:
>> +            - qcom,sm8150-videocc
> Could you please extend the sm8250 case instead of defining a new one?
> Also could you please check if there is a clock (like ahb_clk_src)
> that uses bi_tcxo_ao instead of bi_tcxo? If so, we have to add this
> clock to the bindings even if the driver doesn't use/model it at this
> point.


There are no clocks using the bi_tcxo_ao on sm8150. Hence added separate 
case for sm8150 instead of re-using sm8250.


>> +    then:
>> +      properties:
>> +        clocks:
>> +          items:
>> +            - description: AHB
>> +            - description: Board XO source
>> +        clock-names:
>> +          items:
>> +            - const: iface
>> +            - const: bi_tcxo
>> +
>>     - if:
>>         properties:
>>           compatible:
>>
>> --
>> 2.25.1
>>
>