Received: by 2002:ab2:60d1:0:b0:1f7:5705:b850 with SMTP id i17csp1029135lqm; Thu, 2 May 2024 03:10:39 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVwHME7woitic0PZtm5dXL9IMGtpZ6osM/kZfyixr88rL1puM0Aq695M6rRP9EPxF0kAyYWeJOnUYB6hYWYkyhwMqSqtYKcIp4WlkRaOg== X-Google-Smtp-Source: AGHT+IFZb+PyzLIZRY6QGyIbaKPfQPSZWNN6sWD4vR17g2xBh9s11PjZ1WNecIOdbF1a0n/EtTJ9 X-Received: by 2002:a17:902:c185:b0:1eb:e89:62e2 with SMTP id d5-20020a170902c18500b001eb0e8962e2mr1289114pld.39.1714644638929; Thu, 02 May 2024 03:10:38 -0700 (PDT) Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id ju1-20020a170903428100b001e5c6404356si711799plb.139.2024.05.02.03.10.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 May 2024 03:10:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-166284-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b="n/UkU6cg"; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-166284-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-166284-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id F08EE286708 for ; Thu, 2 May 2024 10:10:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AF4A957877; Thu, 2 May 2024 10:10:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel.com header.i=@intel.com header.b="n/UkU6cg" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74D8155C3A; Thu, 2 May 2024 10:10:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714644609; cv=none; b=opwlIE51JLQNzr5sV/hm5UC9CCKC/A/Kf2/FR3UunhDXf969pUkSyzsY1nPbz6XTO4Bs+cm3n6iaV+DKwkVALqa6RqYl9VTUF+CmfEF65q/u0C/Khf6m8FFvFkEN4QSa9afl3noatupOxuuwfp3HNGxzsXFc5ltzcZGoUb9xydQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714644609; c=relaxed/simple; bh=87FHMmdpw7b1gNaTVQbqStrtd0TI+1EIp0z248aiwBY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rL8LvZcJvl/Tw+uTPV3T7UauSzEMXRD6W5RY7TWEmil2HeuGfEHMvlCwepD7WWeAWoD0b3JM8JL/28MxzIG5z2rgM2luoKO9rwHb/B+8WX5hSYyBERngBirqmKPR4SXvnd7o5C7yQvaKeQLPhVjQSioPJg6XoxEif1NnqzrHKBg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=n/UkU6cg; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714644608; x=1746180608; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=87FHMmdpw7b1gNaTVQbqStrtd0TI+1EIp0z248aiwBY=; b=n/UkU6cgDKch9lFCzQnb9VSQGA6dMmldbWv0jpFsjE22AWNlk2wG7Q+j eCb4nA9QUYkEk2XpnsJFDS4V9MHHu187f88oWYQG8zJBS+OpSDGvbaGiR VqmhDvYrqgIubZUUcRmbBes4C2jTK5jLUexdDwrDj3i0uTaFWYL3VKXkc IjeImfg0FlEGhGo72YbUn3PmvHwDkOQ6dXJ6CjmweyXP4ZbSPOPo5tmIl EK09yX3JucOJvF/n8V+F3s4SD/2V2JOU92BrcXqiu50VCo4iUMjEf5TQY eO2+ftiRuY8oQWYJOr/q1NMeqtNyDE0JTd6oJ3WluMYCrAPkcNkFtLRv3 A==; X-CSE-ConnectionGUID: PH8pmPUPRX6v4FrN6k+lhw== X-CSE-MsgGUID: 3wGzZGl/RIy9AB1bdqOIEA== X-IronPort-AV: E=McAfee;i="6600,9927,11061"; a="10561138" X-IronPort-AV: E=Sophos;i="6.07,247,1708416000"; d="scan'208";a="10561138" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 May 2024 03:10:07 -0700 X-CSE-ConnectionGUID: 0RR7KSU8Tby1qIbwmggvCQ== X-CSE-MsgGUID: Rj5lDDuMQi2fWogM38doFQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,247,1708416000"; d="scan'208";a="31743098" Received: from smile.fi.intel.com ([10.237.72.54]) by orviesa003.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 May 2024 03:10:01 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1s2TO1-00000003HAt-11R5; Thu, 02 May 2024 13:09:57 +0300 Date: Thu, 2 May 2024 13:09:57 +0300 From: Andy Shevchenko To: Sunil V L Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, linux-serial@vger.kernel.org, acpica-devel@lists.linux.dev, Catalin Marinas , Will Deacon , Paul Walmsley , Albert Ou , "Rafael J . Wysocki" , Len Brown , Bjorn Helgaas , Anup Patel , Thomas Gleixner , Samuel Holland , Greg Kroah-Hartman , Jiri Slaby , Robert Moore , Conor Dooley , Andrew Jones , Marc Zyngier , Atish Kumar Patra , Andrei Warkentin , Haibo1 Xu , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= Subject: Re: [PATCH v5 17/17] serial: 8250: Add 8250_acpi driver Message-ID: References: <20240501121742.1215792-1-sunilvl@ventanamicro.com> <20240501121742.1215792-18-sunilvl@ventanamicro.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Thu, May 02, 2024 at 03:20:08PM +0530, Sunil V L wrote: > On Thu, May 02, 2024 at 12:17:59PM +0300, Andy Shevchenko wrote: > > On Wed, May 01, 2024 at 05:47:42PM +0530, Sunil V L wrote: .. > > > + * This driver is for generic 16550 compatible UART enumerated via ACPI > > > + * platform bus instead of PNP bus like PNP0501. This is not a full > > > > This has to be told in the commit message. Anyway, we don't need a duplication > > code, please use 8250_pnp. > > Thank you for the review!. Major issue with PNP0501 is, it gets enumerated > in a different way which causes issue to get _DEP to work. > pnpacpi_init() creates PNP data structures which gets skipped if the > UART puts _DEP on the GSI provider (interrupt controller). In that case, > we need to somehow reinitialize such PNP devices after interrupt > controller gets probed. Then fix that code, we don't want a hack driver on top of the existing one for the same. What I might think out of head is that used IRQ core for your case should return a deferred probe error code when it's not ready, then 8250_pnp will get reprobed. > I tried a solution [1] but it required several > functions to be moved out of __init. > This driver is not a duplicate of 8250_pnp. It just relies on UART > enumerated as platform device instead of using PNP interfaces. > Isn't it better and simple to have an option to enumerate as platform > device instead of PNP? Ah, then extract platform driver first from 8250_core.c. > [1] - https://patchwork.kernel.org/project/linux-pci/patch/20240415170113.662318-14-sunilvl@ventanamicro.com/ -- With Best Regards, Andy Shevchenko