Received-SPF: pass (google.com: domain of linux-kernel+bounces-166288-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 2 May 2024 11:11:30 +0100
From: Mauro Carvalho Chehab <mchehab@kernel.org>
To: Ricardo Ribalda <ribalda@chromium.org>
Cc: Florian Fainelli <florian.fainelli@broadcom.com>, Ray Jui
 <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>, Broadcom
 internal kernel review list <bcm-kernel-feedback-list@broadcom.com>, Sakari
 Ailus <sakari.ailus@linux.intel.com>, Bingbu Cao <bingbu.cao@intel.com>,
 Tianshu Qiu <tian.shu.qiu@intel.com>, linux-media@vger.kernel.org,
 linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org,
 linux-kernel@vger.kernel.org, Hans Verkuil <hverkuil@xs4all.nl>
Subject: Re: [PATCH v2 1/5] media: bcm2835-unicam: Fix build with !PM
Message-ID: <20240502111130.769402fa@sal.lan>
In-Reply-To: <20240501-fix-ipu6-v2-1-a5629a37a0fb@chromium.org>
References: <20240501-fix-ipu6-v2-0-a5629a37a0fb@chromium.org>
	<20240501-fix-ipu6-v2-1-a5629a37a0fb@chromium.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Em Wed, 01 May 2024 13:08:09 +0000
Ricardo Ribalda <ribalda@chromium.org> escreveu:

> The driver can only match the device vide the DT table, so the table
> should always be used, of_match_ptr does not make sense here.
>=20
> Fixes:
> drivers/media/platform/broadcom/bcm2835-unicam.c:2724:34: warning: =E2=80=
=98unicam_of_match=E2=80=99 defined but not used [-Wunused-const-variable=
=3D]

Be careful here: Fixes: <patch> is a tag used by stable people to
identify if a patch needs to be backported. Using a Fixes: may cause
such scripts to break.

(it caused a problem on my apply patch script, as it does reorder
fixes tag).

No need to resend it, as I can fix it when applying, but next time
please use something like:

	It fixes this warning:
	drivers/media/platform/broadcom/bcm2835-unicam.c:2724:34: warning: =E2=80=
=98unicam_of_match=E2=80=99 defined but not used [-Wunused-const-variable=
=3D]

(or some other similar word that won't be using a defined meta tag
with a different meaning).

Regards,
Mauro

>=20
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> ---
>  drivers/media/platform/broadcom/bcm2835-unicam.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/media/platform/broadcom/bcm2835-unicam.c b/drivers/m=
edia/platform/broadcom/bcm2835-unicam.c
> index bd2bbb53070e..c590e26fe2cf 100644
> --- a/drivers/media/platform/broadcom/bcm2835-unicam.c
> +++ b/drivers/media/platform/broadcom/bcm2835-unicam.c
> @@ -2733,7 +2733,7 @@ static struct platform_driver unicam_driver =3D {
>  	.driver =3D {
>  		.name	=3D UNICAM_MODULE_NAME,
>  		.pm	=3D pm_ptr(&unicam_pm_ops),
> -		.of_match_table =3D of_match_ptr(unicam_of_match),
> +		.of_match_table =3D unicam_of_match,
>  	},
>  };
> =20
>=20