Received-SPF: pass (google.com: domain of linux-kernel+bounces-166308-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <016902d9-3858-4c65-b3ec-f7a5103af63c@amd.com>
Date: Thu, 2 May 2024 05:33:28 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: Early boot regression from f0551af0213 ("x86/topology: Ignore
 non-present APIC IDs in a present package")
To: Thomas Gleixner <tglx@linutronix.de>, Lyude Paul <lyude@redhat.com>,
 Borislav Petkov <bp@alien8.de>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org
References: <3d77cb89857ee43a9c31249f4eab7196013bc4b4.camel@redhat.com>
 <20240418082703.GCZiDZVyra7qOQbyqn@fat_crate.local>
 <fd040809d95b3e12b2fdc78a2409e187716bc66f.camel@redhat.com>
 <87plumxz4x.ffs@tglx>
 <abbb7d7ca781f6c664e4c5b1dffc19394ac79691.camel@redhat.com>
 <87le59vw1y.ffs@tglx>
 <3a0afe545747e5314a9cb6bbaa9ce90b259ddfac.camel@redhat.com>
 <87edautcmz.ffs@tglx>
 <3b1d16e357c1f9badeef405366492f05af26c085.camel@redhat.com>
 <878r11t8zu.ffs@tglx>
Content-Language: en-US
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <878r11t8zu.ffs@tglx>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UjdwOS9GQWVVS0c2cXZjR0NCM04zYkVZcFRxOHhUQ3NPTkg2c2RjU080K0Q1?=
 =?utf-8?B?MUZWSzdwc01NZ0lTdzVXVUlJbFlWanBrbmlQR3BHVWMyZXdxQmJ0dVB6cDVB?=
 =?utf-8?B?SFNPQTlsMTJXUXRDRUNDN2ZQbTh0d3RULzFXbGkrT0xGbmJyTmxRTWYzOHYx?=
 =?utf-8?B?Vm8vbGltL1krbURlZ2lKQThHd21HMzR2YTdvRGxEV1NPSndJT2cyNTBiTndi?=
 =?utf-8?B?SkhtTGJQb1N2TXprVWQ4Y1E2UFJlVVpUUTQwMVZRZkoraE8rYldERlQxVnA5?=
 =?utf-8?B?YXBoT2JZWFVyZ3Z6ZkVkSU1QMjloTEZUYll0cTBaL010enRJM0I0YWc5dk56?=
 =?utf-8?B?bWs3dHZFOUNGQ1NsL29zRGhHTnI5bDdIVEdKYWNuRjBuU0R4MDRjRms4SG5s?=
 =?utf-8?B?Mmd5K3hwbnNVK2NZYlRuRmI4Y1hxTlgzbFNaaTBZSEl0d0dYTFJrN250b1JY?=
 =?utf-8?B?NXQ0KzRkZWNoWFBkMWRIdGNac1pSZndDSUVJeVUwdXY2c2JNKzF0M3JUbm9x?=
 =?utf-8?B?b1VSYzF2OWVWUWhuY3M1ZVRWVUlUdkcraGhoN3BKMUlyTDhFdkhvc09kWFhC?=
 =?utf-8?B?T3gzQXdybERtZWsyMUx5czQzb1J6M1pQUWFMdzA4Tk15RWxqb0RUaENLUHA4?=
 =?utf-8?B?RDlla3pSVDlYVDlEZzlRSlJOL29QdmdNT09raTRKUG5oa0xuYXhYT255V0Na?=
 =?utf-8?B?V3dNZjhuakJRRUFReFRqV3dCSVNVTTJnZGZHMmo3Mm5DZXgzQkR5WVVoY29H?=
 =?utf-8?B?S29qYlQ2RktXNmwwZExkdXkxbHpDS25ZTWlyQmllcHJ2RGxVK0pjU1J3MlhP?=
 =?utf-8?B?OWVZRkRPd01VVG1YUVlkK0s4SzhtVGd4VU8vUzZFYnhvZ2FFdVR6Qk5jNmQr?=
 =?utf-8?B?aCtMZ08xeTdrdlBXdktPL1M0MENYdXlNSktla3gyV29xM3lyZVU2T2cvN0hD?=
 =?utf-8?B?Mys2ZUVDRVlDT2tyeENmczkxbWJJZ2tIdnJUbTlNbjhlbFhOYjJnQTdhc3dJ?=
 =?utf-8?B?N21QZ2kzS1RZNnMzQmhESEJueTNXVVRnMGlkNGJvaHU5Qjh5elBXV2Jpd2pY?=
 =?utf-8?B?RHZkYnJmb3JLVFg5QVJnNmI0aVhnN245N0wzNFRyaW94aUhBSituME55elBG?=
 =?utf-8?B?b3Yrc2VRSU9WdUdxajg4N1lQNGF1WUdoSTRjR3FTL3llQjMvVko5NVZualJ3?=
 =?utf-8?B?cXZSMEJSSHMzOGhnYlZiVGJucG83RE5VTy9iSXFQVmVXZVpFODZUdmNzcGgw?=
 =?utf-8?B?REhFc215eFRUWU9zZUFLZk5oOXpya3hoVmNxM2tzM3ViUVhmV2I1cWtuQjUz?=
 =?utf-8?B?cWxibGtSM3NtSmxSK2lHbHZXSVFBdVRMczYxVmw5RlZVL0NlZUJZajluZ09u?=
 =?utf-8?B?ZnN1S2FFbjdEczkrM0ZJWnVjUzA0T2l3RjROYTdZVVNNZnp4bm5Fa3E0YWRZ?=
 =?utf-8?B?MXFiZ2VzUGhwY0dnWDhXcHFqNGNycnM2WmJrTk5xcGVSMkZWakN3dU9zMVJD?=
 =?utf-8?B?RnNFbXErTEhjTXF3RVArUmtyZnQ4dGh4WGFYVHo1SXM5bmQvdW8ydGFPVWsz?=
 =?utf-8?B?U1NLcSszM3laM1N1dThMUlhucEtiSHJGQ3ROeGJVOGU3aU9ZUG8yRlV6dDY0?=
 =?utf-8?B?amp4WWRVU1ZkanBLQURDRElGR2Y2d0RTVFRSYVNKbjFLRDBFYitkc3YzcEFQ?=
 =?utf-8?B?TjB5c24vQ2t1Rm01K1NiTTNnY1ZmMWhzamFHOXB6N293UXFGSVpuSnlLcjBq?=
 =?utf-8?B?aTRDNGpIaVhkRnVEOVB5NGk3L0MvUUREdW51djl1UzRUaXBnZk9PaFhBZ2JO?=
 =?utf-8?B?NDJDa2laa3pqVWtXTG9DbldadHlRbGNrZW9ZSWc2QnhyVDhZZVZYT1REcXJM?=
 =?utf-8?B?VTltNTI2dVg4dkdHMmxrajQyWjBwN0hYd05qS0dFMzlOd202R3J6RndkTE5D?=
 =?utf-8?B?ZDJ6RlNORml0S1I1RnAyaFhTUGlPbStZeEMxR284Tm5kblg1RkVpejlTZG1U?=
 =?utf-8?B?WG9Ib1l5VG93WXVmR0MrejFGWHdreThsNUxWYlAxNTRDcE5wTkEwNmxHTUd1?=
 =?utf-8?B?eGFpMElrSGpTcFpDQktYZHRtN2RxNmlGQjBQZEM0ZEVrUjlxcVYwL1hhMlcw?=
 =?utf-8?Q?4ShLhLqfEmFxkZTu2oLD+Bwqz?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 16a70b46-4538-4c46-9a8e-08dc6a934ff7
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2024 10:33:31.5771
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IwiRyIx6G23VFGofMc0kKsXoh+ZRABRfksKGSziRl8qlJvnmmUHByn1emFSRSn0OhwjX0fWrFSDYAeVwmpCwQQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6942

On 4/25/2024 16:42, Thomas Gleixner wrote:
> Lyude!
> 
> On Thu, Apr 25 2024 at 11:56, Lyude Paul wrote:
>> On Thu, 2024-04-25 at 04:11 +0200, Thomas Gleixner wrote:
>>>
>>> Can you please boot a kernel with the commit in question reverted and
>>> add 'possible_cpus=8' to the kernel command line?
>>>
>>> In theory this should fail too.
>>
>> Yep - tried booting a kernel with f0551af0213 reverted and
>> possible_cpus=8, it definitely looks like that crashes things as well
>> in the same way.
> 
> Good. That means it's a problem which existed before but went unnoticed.
> 
>> Also - it scrolled off the screen before I had a chance to write it
>> down, but I'm -fairly- sure I saw some sort of complaint about "16 [or
>> some double digit number] processors exceeds max number of 8". Which
>> is quite interesting, as this is definitely just a quad core ryzen
>> processor with hyperthreading - so there should only be 8 threads.
> 
> Right, that's what we saw with the debug patch. The ACPI/MADT table
> is clearly bonkers. The effect of it is that it pretends that the system
> has 16 possible CPUs:
> 
>      [    0.089381] CPU topo: Allowing 8 present CPUs plus 8 hotplug CPUs
> 
> Which in turn changes the sizing of the per CPU data and affects some
> other details which depend on the number of possible CPUs.

At least this aspect of this I suspect is caused by commit 
fed8d8773b8ea68ad99d9eee8c8343bef9da2c2c.

If you try reverting that I expect the "hotplug CPUs" disappear.

> 
> But that should not matter at all because the system scaling should be
> sufficient with 8 CPUs, but it does not for some completely non-obvious
> reasons.
> 
> Can you please try to increase possible_cpus=N on the command line one
> by one and check when it actually starts to "work" again.
> 
> One other thing to try is to boot with 'possible_cpus=8' and
> 'intremap=off' and see whether that makes a difference.
> 
> I really have no idea where to look and not having the early boot
> messages in case of the fail is not helpful as I can't add meaningful
> debug to it.
> 
> I just checked: the motherboard has a serial port, so it would be
> extremly helpful to hook up a serial cable to this thing and enable
> serial console on the kernel command line. That way we might eventually
> see information which is emitted before it fails to validate the timer
> interrupt.
> 
> Thanks,
> 
>          tglx
>