Received-SPF: pass (google.com: domain of linux-kernel+bounces-166310-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 2 May 2024 11:35:48 +0100
From: Lee Jones <lee@kernel.org>
To: Shresth Prasad <shresthprasad7@gmail.com>
Cc: daniel.thompson@linaro.org, jingoohan1@gmail.com, deller@gmx.de,
	dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, javier.carrasco.cruz@gmail.com,
	skhan@linuxfoundation.org, julia.lawall@inria.fr
Subject: Re: [PATCH v3][next] backlight: sky81452-backlight: Remove
 unnecessary call to of_node_get
Message-ID: <20240502103548.GU5338@google.com>
References: <20240502063621.65687-2-shresthprasad7@gmail.com>
 <20240502093623.GJ5338@google.com>
 <CAE8VWiLP-QR_KaHBPYjA=UVJ8SShpKseB5Xp9Hpkd1RMcvt-qw@mail.gmail.com>
 <20240502100822.GS5338@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240502100822.GS5338@google.com>

On Thu, 02 May 2024, Lee Jones wrote:

> On Thu, 02 May 2024, Shresth Prasad wrote:
> 
> > On Thu, May 2, 2024 at 3:06 PM Lee Jones <lee@kernel.org> wrote:
> > >
> > > On Thu, 02 May 2024, Shresth Prasad wrote:
> > >
> > > > `dev->of_node` already has a reference to the device_node and calling
> > > > of_node_get on it is unnecessary. All conresponding calls to
> > > > of_node_put are also removed.
> > > >
> > > > Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> > > > Signed-off-by: Shresth Prasad <shresthprasad7@gmail.com>
> > > > ---
> > > > Changes in v3:
> > > >     - Remove unnecessary braces
> > > >
> > > >  drivers/video/backlight/sky81452-backlight.c | 8 ++------
> > > >  1 file changed, 2 insertions(+), 6 deletions(-)
> > >
> > > No idea what you're talking about.
> > >
> > > This patch/version doesn't exist in either my inbox or LORE:
> > >
> > >   https://lore.kernel.org/all/?q=%22%5BPATCH+v3%5D%5Bnext%5D+backlight%3A+sky81452-backlight%3A+Remove+unnecessary+call+to+of_node_get%22
> > >
> > > --
> > > Lee Jones [李琼斯]
> > 
> > I'm not sure what you mean.
> > The patches show up just fine:
> > https://lore.kernel.org/all/?q=backlight%3A+sky81452-backlight%3A+Remove+unnecessary+call+to+of_node_get
> > 
> > If you mean that the first version doesn't show up, it's because the
> > commit message
> > was changed to better reflect changes.
> 
> Those are v2
> 
> You replied to a non-existent v3 which started a new thread.

Something funky is going on.  Your pokey emails are coming through
disconnected from the patches which is causing confusion.

The best thing going forward is to submit [RESEND]s instead of
contentless pokes.

Please submit a [RESEND] for v3 and we can start again.

-- 
Lee Jones [李琼斯]