Date: Mon, 28 Jan 2008 19:51:24 -0800 (PST)
Message-Id: <20080128.195124.188485009.davem@davemloft.net>
To: paul.moore@hp.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
       selinux@tycho.nsa.gov, stable@kernel.org, bunk@kernel.org,
       jmorris@namei.org
Subject: Re: [PATCH] SELinux: Fix double free in
 selinux_netlbl_sock_setsid()
From: David Miller <davem@davemloft.net>
In-Reply-To: <20080129022026.7930.18782.stgit@flek.lan>
References: <20080129022026.7930.18782.stgit@flek.lan>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1076
Lines: 27

From: Paul Moore <paul.moore@hp.com>
Date: Mon, 28 Jan 2008 21:20:26 -0500

> As pointed out by Adrian Bunk, commit 45c950e0f839fded922ebc0bfd59b1081cc71b70
> caused a double-free when security_netlbl_sid_to_secattr() fails.  This patch
> fixes this by removing the netlbl_secattr_destroy() call from that function
> since we are already releasing the secattr memory in
> selinux_netlbl_sock_setsid().
> 
> Signed-off-by: Paul Moore <paul.moore@hp.com>

Applied, and I'll queue this up for -stable too.

Please, when mentioning specific commits please also provide
the changelog headline along with the SHA1 hash.

The reason is that when this fix is moved over to another
tree where the SHA1 of the causing change is different people
studying your fix won't be able to find it without more stable
contextual information.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/