Received-SPF: pass (google.com: domain of linux-kernel+bounces-166372-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240430202928.1143802-3-robh@kernel.org>
In-Reply-To: <20240430202928.1143802-3-robh@kernel.org>
From: Masahiro Yamada <masahiroy@kernel.org>
Date: Thu, 2 May 2024 20:06:32 +0900
Message-ID: <CAK7LNATnr-L0Xwi2xCy1hcuPV=H=11+1bR=D0ji21exhprXRXg@mail.gmail.com>
Subject: Re: [PATCH] dt-bindings: kbuild: Fix dt_binding_check for arch
 without dts directory
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: Nathan Chancellor <nathan@kernel.org>, Nicolas Schier <nicolas@fjasle.eu>, linux-kbuild@vger.kernel.org, 
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, May 1, 2024 at 5:30=E2=80=AFAM Rob Herring (Arm) <robh@kernel.org> =
wrote:
>
> Commit 1d06c77d93da ("dt-bindings: kbuild: Add separate
> target/dependency for processed-schema.json") placed setting CHECK_DTBS
> for 'dt_binding_check' target within the section that depends on having
> arch/$ARCH/boot/dts/ which x86 doesn't have for example. That results in
> the schema checks not running for the examples. Move setting it back out
> of the conditional section as it was (CHECK_DT_BINDING is still
> replaced).
>
> Fixes: 1d06c77d93da ("dt-bindings: kbuild: Add separate target/dependency=
 for processed-schema.json")
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> Cc: devicetree@vger.kernel.org
>
> Masahiro, Please take this as the above commit is in your tree.


I squashed this to the original commit.

Thanks.


>
>  Makefile | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index f4fe5b0ea931..43a2a630436a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1403,7 +1403,7 @@ dtbs: dtbs_prepare
>  # dtbs_install depend on it as dtbs_install may run as root.
>  dtbs_prepare: include/config/kernel.release scripts_dtc
>
> -ifneq ($(filter dt_binding_check dtbs_check, $(MAKECMDGOALS)),)
> +ifneq ($(filter dtbs_check, $(MAKECMDGOALS)),)
>  export CHECK_DTBS=3Dy
>  endif
>
> @@ -1422,6 +1422,10 @@ endif
>
>  endif
>
> +ifneq ($(filter dt_binding_check, $(MAKECMDGOALS)),)
> +export CHECK_DTBS=3Dy
> +endif
> +
>  PHONY +=3D scripts_dtc
>  scripts_dtc: scripts_basic
>         $(Q)$(MAKE) $(build)=3Dscripts/dtc
> --
> 2.43.0
>


--=20
Best Regards
Masahiro Yamada