Received-SPF: pass (google.com: domain of linux-kernel+bounces-166402-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <a17206389b075a30fc0b8536f982aae80ee62da5.camel@gmail.com>
Subject: Re: [PATCH v2 4/4] iio: common: scmi_iio: convert to dev_err_probe()
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, nuno.sa@analog.com
Cc: Petr Mladek <pmladek@suse.com>, Chris Down <chris@chrisdown.name>, John
 Ogness <john.ogness@linutronix.de>, Greg Kroah-Hartman
 <gregkh@linuxfoundation.org>,  Jonathan Cameron <jic23@kernel.org>,
 Lars-Peter Clausen <lars@metafoo.de>, Olivier Moysan
 <olivier.moysan@foss.st.com>, Andi Shyti <andi.shyti@kernel.org>, Jyoti
 Bhayana <jbhayana@google.com>, linux-kernel@vger.kernel.org,
 linux-iio@vger.kernel.org
Date: Thu, 02 May 2024 13:33:38 +0200
In-Reply-To: <ZifYwxjNxfM1LwW7@smile.fi.intel.com>
References: <20240423-dev-add_dev_errp_probe-v2-0-12f43c5d8b0d@analog.com>
	 <20240423-dev-add_dev_errp_probe-v2-4-12f43c5d8b0d@analog.com>
	 <ZifYwxjNxfM1LwW7@smile.fi.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Tue, 2024-04-23 at 18:50 +0300, Andy Shevchenko wrote:
> On Tue, Apr 23, 2024 at 05:20:33PM +0200, Nuno Sa via B4 Relay wrote:
> > From: Nuno Sa <nuno.sa@analog.com>
> >=20
> > Make use of dev_err_probe() and dev_err_ptr_probe() to simplify error p=
aths
> > during probe.
>=20
> ...
>=20
> > +		return dev_err_ptr_probe(&iiodev->dev, ret,
> > +					 "Error in registering sensor update
> > notifier for sensor %s err %d",
>=20
> \n

sure...

>=20
> > +					 sensor->sensor_info->name, ret);
>=20
> ...
>=20
> > +			return dev_err_probe(dev, -EINVAL,
> > +					=C2=A0=C2=A0=C2=A0=C2=A0 "SCMI sensor %d has missing
> > info\n", i);
>=20
> One line? (It's 99 if you use relaxed limit).

Being this IIO, Jonathan prefers to stick the old limit unless readability =
is hurt...
>=20
> ...
>=20
> > +			return dev_err_probe(dev, PTR_ERR(scmi_iio_dev),
> > +					=C2=A0=C2=A0=C2=A0=C2=A0 "failed to allocate IIO device for
> > sensor %s: %ld\n",
> > +					=C2=A0=C2=A0=C2=A0=C2=A0 sensor_info->name,
> > PTR_ERR(scmi_iio_dev));
>=20
> Please, be sure you remove double error code printing, dev_err_probe() do=
es it
> for you already. (This applies to all places like this, if any, in the en=
tire
> series.)

Up... blind conversion. Thanks!

- Nuno S=C3=A1