Received-SPF: pass (google.com: domain of linux-kernel+bounces-166410-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Peng Fan <peng.fan@nxp.com>
To: Andrew Jeffery <andrew@codeconstruct.com.au>, "Peng Fan (OSS)"
	<peng.fan@oss.nxp.com>, Linus Walleij <linus.walleij@linaro.org>, Thierry
 Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>,
	Dvorkin Dmitry <dvorkin@tibbo.com>, Wells Lu <wellslutw@gmail.com>, Maxime
 Coquelin <mcoquelin.stm32@gmail.com>, Alexandre Torgue
	<alexandre.torgue@foss.st.com>, Emil Renner Berthing <kernel@esmil.dk>,
	Jianlong Huang <jianlong.huang@starfivetech.com>, Hal Feng
	<hal.feng@starfivetech.com>, Orson Zhai <orsonzhai@gmail.com>, Baolin Wang
	<baolin.wang@linux.alibaba.com>, Chunyan Zhang <zhang.lyra@gmail.com>, Viresh
 Kumar <vireshk@kernel.org>, Shiraz Hashim <shiraz.linux.kernel@gmail.com>,
	"soc@kernel.org" <soc@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>, Alim Akhtar
	<alim.akhtar@samsung.com>, Geert Uytterhoeven <geert+renesas@glider.be>,
	Patrice Chotard <patrice.chotard@foss.st.com>, Heiko Stuebner
	<heiko@sntech.de>, Damien Le Moal <dlemoal@kernel.org>, Ludovic Desroches
	<ludovic.desroches@microchip.com>, Nicolas Ferre
	<nicolas.ferre@microchip.com>, Alexandre Belloni
	<alexandre.belloni@bootlin.com>, Claudiu Beznea <claudiu.beznea@tuxon.dev>,
	Aisheng Dong <aisheng.dong@nxp.com>, Fabio Estevam <festevam@gmail.com>,
	Shawn Guo <shawnguo@kernel.org>, Jacky Bai <ping.bai@nxp.com>, Pengutronix
 Kernel Team <kernel@pengutronix.de>, Chester Lin <chester62515@gmail.com>,
	Matthias Brugger <mbrugger@suse.com>, "Ghennadi Procopciuc (OSS)"
	<ghennadi.procopciuc@oss.nxp.com>, Sean Wang <sean.wang@kernel.org>, Matthias
 Brugger <matthias.bgg@gmail.com>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>, Sascha Hauer
	<s.hauer@pengutronix.de>, Joel Stanley <joel@jms.id.au>, Dan Carpenter
	<dan.carpenter@linaro.org>
CC: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-stm32@st-md-mailman.stormreply.com"
	<linux-stm32@st-md-mailman.stormreply.com>,
	"linux-samsung-soc@vger.kernel.org" <linux-samsung-soc@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org" <linux-renesas-soc@vger.kernel.org>,
	"linux-rockchip@lists.infradead.org" <linux-rockchip@lists.infradead.org>,
	"linux-riscv@lists.infradead.org" <linux-riscv@lists.infradead.org>,
	"linux-mediatek@lists.infradead.org" <linux-mediatek@lists.infradead.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>, "linux-aspeed@lists.ozlabs.org"
	<linux-aspeed@lists.ozlabs.org>, "openbmc@lists.ozlabs.org"
	<openbmc@lists.ozlabs.org>
Subject: RE: [PATCH 20/21] pinctrl: aspeed: g5: Use scope based of_node_put()
 cleanups
Thread-Topic: [PATCH 20/21] pinctrl: aspeed: g5: Use scope based of_node_put()
 cleanups
Thread-Index: AQHam8aaaSsA7ukUMEKRJbR3/u/LvLGDHuAAgAC3pIA=
Date: Thu, 2 May 2024 11:52:35 +0000
Message-ID:
 <DU0PR04MB9417870C10E47E1AF8557ECD88182@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20240501-pinctrl-cleanup-v1-0-797ceca46e5c@nxp.com>
	 <20240501-pinctrl-cleanup-v1-20-797ceca46e5c@nxp.com>
 <eda5b1da03d4adfa5761c49527a9232ec7facae3.camel@codeconstruct.com.au>
In-Reply-To:
 <eda5b1da03d4adfa5761c49527a9232ec7facae3.camel@codeconstruct.com.au>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?Bc5jUGsgYHqzOvX+49kv1vg8rkGxOqmxB19PbkLxadanRzcC4hyxC81OQzJA?=
 =?us-ascii?Q?uImQSJvjYauT9dWSJ49e7zG76oDLPhHGbfo3cPzY08RtQ7aBYh8vHzMLbImd?=
 =?us-ascii?Q?X476mh3XTky/N8WZMW8MGVx2Hbs2hoovM7DkVrvA4z+u1LYMxShcYlMVg4Au?=
 =?us-ascii?Q?FG7JtKVJyU2ZxMPoTwZHhxeOM7s/FWyqzxXNyBxWNNe8NsTIbanSpYEwuQyD?=
 =?us-ascii?Q?OLAfgYqz5N1PMs9+x4D8+OYSQpb6+5n+OaReIufJl2SLT7XrrFP6trYxe6Fb?=
 =?us-ascii?Q?aA1FASzHDXowbzrMaJf10vFepK2Gas6YK4lAgYzjrRGWRk3r2hBsHvVdMcMF?=
 =?us-ascii?Q?fG038CoxkgxU8eTqZwNMaasd9FVqH6wb9o28ZL3iIjE8tftRPTyndGMguFDv?=
 =?us-ascii?Q?bLSV3n3SU5IuSGAvRMvBRzMlEpK4NGCjRtSm235hrwHHSSpHHieZJvwUIPYj?=
 =?us-ascii?Q?Aae/2TA1PaipQgCEKCujF75CFEdmrf/tQbYXEGHaVeCjlfd8i4A/++VLzZBp?=
 =?us-ascii?Q?sP69CX9E+B/EA33+33l1RynEAjQPzwxmOAuQP1u7pEh9UDoqkrA6EUPNCFB6?=
 =?us-ascii?Q?ZfunHuJdBH8D7UNGWwtvb60cPAEGYC835qiHpoDKo9lWgkns08ewycKtxvNS?=
 =?us-ascii?Q?lII6aFfmqjSHTjc4uvGPPXOk7tFpTKHZyr2R5tvvG0O0miBcZgOy9GEHYpAp?=
 =?us-ascii?Q?MSE/ry1PDN3lcCvifLRjye7cEOkPjypYq+MJH9Nrbb5fFyGfQHRPDhuOaMQM?=
 =?us-ascii?Q?iDCbeBKztne7LVXW4HAuiiNWVC54QLJVsk71xIl5U3/8q92OziQJdvOHplwB?=
 =?us-ascii?Q?ZBArbj2C/yh/nuTwSixJUN/kPEZmHnIBZLOUM3vH8GcOn7b3wbUCje8zSKx0?=
 =?us-ascii?Q?0HYhWd1eoDQwpkZmlJ8pLdZBRayrP3FDIkTEmTZVrDDgPawYgLHqfcJ4ANpr?=
 =?us-ascii?Q?w+ty81gFHx5DkLwi15SAVmVJ7d+oLD/b3apTpVsUD9nYdfM7Zt49KOOhVJ/O?=
 =?us-ascii?Q?s+cMEr8pGxzMOEvAqzxtU7LE87I7kvo9Xg1zmbNGrbckcoAO7bTyhH8f8BRX?=
 =?us-ascii?Q?rOGKf8Kl2VbBpJrc5vBZyjUu6aTlPuTjvbUNA74LRMPnTcIB1cBs9LlZzYQK?=
 =?us-ascii?Q?7mBmSalX0XW8G9AzZFQDj8+UyxQn5Jt32vlgbv88yL7QsiGaA8gD1fRpaaxK?=
 =?us-ascii?Q?L7wepYAzDaxnqHFj5jVWmUfGHAFuD1mwm8YrGm68OXz/r3rQ2pTSEteB2MYI?=
 =?us-ascii?Q?vwkAfTNV7GWDMMaQ6W7eH3m477jmVxe+kotSwQuVtBD867UbehPZC9MUTqDz?=
 =?us-ascii?Q?PzKWN+HdX54Hc674QVdEaBYOaYZ48TvydoD8cA9flM8d5E5B4p63/ChMLLp2?=
 =?us-ascii?Q?DCfZ2ZIptoD8TLXWRIaKtNeR+nnCsKtPOEr9afosVgCAFxC0PVroBcUJu9wo?=
 =?us-ascii?Q?zUxTG4lBb16Qz4Lb6cw6DxoQe7CEY6jMvCRRd4dt4LNIujGXNuNRxPAKpYGu?=
 =?us-ascii?Q?xo713XexTSR/P5c33sNiL9rp5a++XYj8jgKNb2LFn99HqSvE9ojYTNZSPpcq?=
 =?us-ascii?Q?RHZ6yXiNJrAM+Gupl8c=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f5bda49-263b-41d0-4907-08dc6a9e5b87
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 May 2024 11:52:35.2518
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: C2ftlX9BDVLp0UwX6Z6D0XfhGfpFPf+aQRsjHzlhDpcxVKPCMIZpR6rEx5g577LBG62VsxhF59Y+gj+QBvuicA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8431

> Subject: Re: [PATCH 20/21] pinctrl: aspeed: g5: Use scope based
> of_node_put() cleanups
>
> On Wed, 2024-05-01 at 20:56 +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Use scope based of_node_put() cleanup to simplify code.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c | 6 ++----
> >  1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c
> > b/drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c
> > index 5bb8fd0d1e41..61fbfddb5938 100644
> > --- a/drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c
> > +++ b/drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c
> > @@ -2629,14 +2629,13 @@ static struct regmap
> *aspeed_g5_acquire_regmap(struct aspeed_pinmux_data *ctx,
> >             return ctx->maps[ip];
> >
> >     if (ip =3D=3D ASPEED_IP_GFX) {
> > -           struct device_node *node;
> > +           struct device_node *node __free(device_node) =3D NULL;
> >             struct regmap *map;
> >
> >             node =3D of_parse_phandle(ctx->dev->of_node,
> >                                     "aspeed,external-nodes", 0);
> >             if (node) {
> >                     map =3D syscon_node_to_regmap(node);
> > -                   of_node_put(node);
> >                     if (IS_ERR(map))
> >                             return map;
> >             } else
> > @@ -2648,7 +2647,7 @@ static struct regmap
> *aspeed_g5_acquire_regmap(struct aspeed_pinmux_data *ctx,
> >     }
> >
> >     if (ip =3D=3D ASPEED_IP_LPC) {
> > -           struct device_node *np;
> > +           struct device_node *np __free(device_node) =3D NULL;
> >             struct regmap *map;
> >
> >             np =3D of_parse_phandle(ctx->dev->of_node,
> > @@ -2660,7 +2659,6 @@ static struct regmap
> *aspeed_g5_acquire_regmap(struct aspeed_pinmux_data *ctx,
> >                             return ERR_PTR(-ENODEV);
> >
> >                     map =3D syscon_node_to_regmap(np->parent);
> > -                   of_node_put(np);
> >                     if (IS_ERR(map))
> >                             return map;
>
> I think I agree with Krzysztof's feedback on the Samsung patch[1], and th=
at I
> prefer the existing approach for the Aspeed driver. My reasoning suggests=
 the
> existing implementation does the right thing. That said, the code could b=
e
> adjusted to use early returns and consistent variable names, which might
> make it easier to reason about.

No problem, let's keep the code as it is.

Thanks,
Peng

I'll consider a follow-up patch to address that.
>
> Regardless, thanks for taking the time to explore the cleanup.
>
> Andrew
>
> [1]:
> https://lore.ke/
> rnel.org%2Flkml%2F34193501-5b7b-4ffd-8549-
> a04c6930d02d%40kernel.org%2F&data=3D05%7C02%7Cpeng.fan%40nxp.com
> %7C44ef77e479264eccd73f08dc6a4263c6%7C686ea1d3bc2b4c6fa92cd99c5
> c301635%7C0%7C0%7C638502080600849943%7CUnknown%7CTWFpbGZs
> b3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn
> 0%3D%7C0%7C%7C%7C&sdata=3DtuUu1IeqM5sQjqiN1fwzPAbSoZw%2FUNEd2
> u%2BzpaBhJ4M%3D&reserved=3D0
>
> >             } else
> >