Received-SPF: pass (google.com: domain of linux-kernel+bounces-166424-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 2 May 2024 14:11:05 +0200
From: Robert Richter <rrichter@amd.com>
To: Alison Schofield <alison.schofield@intel.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
	Andy Lutomirski <luto@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Dan Williams <dan.j.williams@intel.com>, linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org,
	Derick Marks <derick.w.marks@intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Len Brown <lenb@kernel.org>
Subject: Re: [PATCH v6 1/7] x86/numa: Fix SRAT lookup of CFMWS ranges with
 numa_fill_memblks()
Message-ID: <ZjOC2bTWMO6NnSOk@rric.localdomain>
References: <20240430092200.2335887-1-rrichter@amd.com>
 <20240430092200.2335887-2-rrichter@amd.com>
 <ZjEZeHOlCSUMvMoD@aschofie-mobl2>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZjEZeHOlCSUMvMoD@aschofie-mobl2>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?RRIDWrkCOMZ0FVeAb8105tdLwCUTkCXUXMBFoqZU3zZDa1C10trcszphwvMm?=
 =?us-ascii?Q?MSp7R0oc3iY7WyoSDP7AFQpixTAwcidMytsir40N3PxLxM/mmNTXBHRCKKXp?=
 =?us-ascii?Q?dYcCbuZXDAQHemjeY979fly9DHqATjRWrAhEaaBj9z+ghvJaCA4c8EXgL3MH?=
 =?us-ascii?Q?asSNIFsOO5kL0giFxOfm5nRKQox6NHRxRF4n7l8yCRrJCBBSc3hKBKN71Pzh?=
 =?us-ascii?Q?lmzBjho3FFtzUR3vjYuoW7QTwm1uGhS8Rbu8eGm9w3dqz6Gxdnr6ReWy/zEc?=
 =?us-ascii?Q?ENDSjt3rG+wAlkwFneRfnBCIixy4CHpw8YpPTAZVQ8ST/8F0YR7c4HsczaXC?=
 =?us-ascii?Q?Tf/QSdKGOO0pN6RwL+lMA6JwnzoLTM4+T4PuIT5AGTmT5FBc4sMpS4mE73kF?=
 =?us-ascii?Q?FAkSSQMltgMb07PrFY3LhUT8U7b1ap/y7s0rGoAormF2Dy70tpvpOhb6yzSe?=
 =?us-ascii?Q?NlHzBt4zdvG+FbRXf41tmvusf6tj4LTQetJXSr5MRu3Em4lKD/1JGgUjeHbD?=
 =?us-ascii?Q?oJQgV+FB4oDoswV/Cl1wHoSzgqXZlj2RIVt4AOhPjBSjYb9j4DBWcvfzUoSC?=
 =?us-ascii?Q?0RY3AdXAtVaS8+aT9u8EMn8kOlhXU3o7yBzR2Quc7EHSo/yP++XE7MVGDIMF?=
 =?us-ascii?Q?c0INj6lvEkS9mR8c+nzQyPVckLvvRleLG+Qi2I8/HvkdcZWQgxkGb5So6fEm?=
 =?us-ascii?Q?OExS6z1wyuysXz5hiekQ3X+zNT5dzoUgEnyXBmL1uRSjHcPn1LCrw5MiicCJ?=
 =?us-ascii?Q?CZSnDd/ktnlabEly5KXMpQ/NAQqkLX3rEYpjt0/MWUBPhjUaMka6LJkG3jRe?=
 =?us-ascii?Q?53QR68Ah+gvATHWf3U7rAw6laa2kYQRSI8nX5DAGm7kiZ+spHSmoU42mw/GD?=
 =?us-ascii?Q?4mdOsHvN4GX5MNLHxdwt8VmgA9o0sRdGcA6Ll5cH8WsDyCSyzU8XVX77nBXs?=
 =?us-ascii?Q?KQPcZY2HuR233ePWu81EGce6XnYyQVM59O5vN/IYpQDwmipoYpxtraHfLRiE?=
 =?us-ascii?Q?HAcFrytupfuZM7yFsH2NA+LEclHN/sYORTQNmmdEeAQlAPWWxRKbSSfimFO8?=
 =?us-ascii?Q?wGs2P7Mf7aKl5Epp39roNlqJ+QJ/M5zViid9srvEm052jnZyzUkw7kVOmqSB?=
 =?us-ascii?Q?tr3io6vqWGU5fdpGp45Ljo9eQe9/oEaOUpWM+3QDrEKpXexTzklQNn7msTEX?=
 =?us-ascii?Q?qGwz2ap5PrlQRoIclRyTwQiThWri9lEPeQ8VptGWNvp64UQv7fdDxvjfP0Ob?=
 =?us-ascii?Q?Bx16NVQNmV9CAPB6Hld8icCBao3oXGMh9fuf1sNqckgrKucdLEbvjqT5QqLJ?=
 =?us-ascii?Q?0PzUKkoGKAa/50Fa8NKCP2Z8F+pyUm5HKGUSr5Xv6zLzG2TQwu4xjt8jPmjr?=
 =?us-ascii?Q?zbQn0uuboD4InJ1OzjeLRNH/AAeVTH7up6puo6vKyNk5s20F+rf56rC/Lhii?=
 =?us-ascii?Q?cLhaTVWAsgSM5dApM14u29Pe+m56jXNcpTGsGairw0+2yTIrLzDiuS+90wU8?=
 =?us-ascii?Q?2HrgxsGR2Lp1B5KFiIfN8AhNadOCx8Rd7afIzj0BbNkfnY9yZFzDLad4+vyg?=
 =?us-ascii?Q?nKDKSIGMVgu4LQUFMOi9xtYbyAQ6gXJlGIk8o5bx?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 26bb8949-8423-423d-57dc-08dc6aa0f566
X-MS-Exchange-CrossTenant-AuthSource: CYYPR12MB8750.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2024 12:11:12.5577
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IZ6LS36JvsyhTufiCTrZwEGDEqZqJTn7wa/UVgFGGM1tFSLFuA54C0/nYVDbg5OH2tBLgGZ1aSk7MOQl9cJCvg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7661

On 30.04.24 09:16:56, Alison Schofield wrote:
> On Tue, Apr 30, 2024 at 11:21:54AM +0200, Robert Richter wrote:
> > For configurations that have the kconfig option NUMA_KEEP_MEMINFO
> > disabled numa_fill_memblks() only returns with NUMA_NO_MEMBLK (-1).
> > SRAT lookup fails then because an existing SRAT memory range cannot be
> > found for a CFMWS address range. This causes the addition of a
> > duplicate numa_memblk with a different node id and a subsequent page
> > fault and kernel crash during boot.
> > 
> > Fix this by making numa_fill_memblks() always available regardless of
> > NUMA_KEEP_MEMINFO.
> > 
> > The fix also removes numa_fill_memblks() from sparsemem.h using
> > __weak.
> > 
> > From Dan:
> > 
> > """
> > It just feels like numa_fill_memblks() has absolutely no business being
> > defined in arch/x86/include/asm/sparsemem.h.
> > 
> > The only use for numa_fill_memblks() is to arrange for NUMA nodes to be
> > applied to memory ranges hot-onlined by the CXL driver.
> > 
> > It belongs right next to numa_add_memblk(), and I suspect
> > arch/x86/include/asm/sparsemem.h was only chosen to avoid figuring out
> > what to do about the fact that linux/numa.h does not include asm/numa.h
> > and that all implementations either provide numa_add_memblk() or select
> > the generic implementation.
> > 
> > So I would prefer that this do the proper fix and get
> > numa_fill_memblks() completely out of the sparsemem.h path.
> > 
> > Something like the following which boots for me.
> > """
> > 
> > Note that the issue was initially introduced with [1]. But since
> > phys_to_target_node() was originally used that returned the valid node
> > 0, an additional numa_memblk was not added. Though, the node id was
> > wrong too, a message is seen then in the logs:
> > 
> >  kernel/numa.c:  pr_info_once("Unknown target node for memory at 0x%llx, assuming node 0\n",
> > 
> > [1] commit fd49f99c1809 ("ACPI: NUMA: Add a node and memblk for each
> >     CFMWS not in SRAT")
> > 
> 
> For the commit log above -
> Perhaps the Dan quote can be reduced to a note about the implementation
> choice. Folks can look up the Lore thread if history is needed.
> 
> For the code -
> Reviewed-by: Alison Schofield <alison.schofield@intel.com>

Adjusted description, thanks.

-Robert