Received: by 2002:ab2:60d1:0:b0:1f7:5705:b850 with SMTP id i17csp1120358lqm; Thu, 2 May 2024 06:04:44 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCURHHZKXc0hZ8t/U689GNquv7HUnzIZ4MhKMTj0tr9en5FI0h+aJZ+n9Fu79z9Zi24tU2lrPSxhbYrJHjXF6Ozs0m4w4vso6o/RUfN55A== X-Google-Smtp-Source: AGHT+IG/XxfeKBgBqQouk8mFvbarXtELU/kCW7Um0/P0aehBGggIkgNnmtgdA2fWVk/JfsSzQnUh X-Received: by 2002:a05:622a:4e96:b0:43a:8248:26f with SMTP id dj22-20020a05622a4e9600b0043a8248026fmr6038362qtb.27.1714655083697; Thu, 02 May 2024 06:04:43 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714655083; cv=pass; d=google.com; s=arc-20160816; b=Oo8KtmMy8cocf4wybR367i/eEgn86k8A2ELBkOSI02hnIuU1zfkDu7ZLmeUt0FaWXe 2JcmuBXmAHO/hUGmSo9fyM3E0eDPj7LMIexrrlSkU2Ae9yrlSnWs5Exgu0gWcIMRk88j hFcM0LJNEoXrPdwNdNvIHNJBf+slsYrR6MOcfp8tOXnpkCPSh9FwQJEbTU217deNG5Jy pzN7JZQjKet65427pYe0gcNbFevCfs/FIEtYJ6o9VCMhdSqxgWQLp1N6RyFufUWtRoVT sOBv2U8KxDyuUMWyo7gwO3XAkof40WYB3ABeo/KcKeMcM1uwY7zxXOWhvXscIlRxWj95 a+eg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=H5oAKcVOK2DFwrUyUpEDH3Ies9gPXcmXIZr5ImGktgA=; fh=J6vpzgumLFf2UJePoEcA/ZnKx7sK2aY9e461gS3oM8Q=; b=GjlAxIr3ou0POfECmURlTvn47s8Okex9OJZP/RohC+zeauvCk3Px15MpBlILWJY3M5 3QSLakEErwfpVZffJ0LqchFg3OWLUqxJjMtlS57aTx0zk6R3vifG4CC7H0KrZrF9sLeP tl7z0GsxBjOgeH3eCehgYoInPzmXzV12rP2NCJTmbgna+O94+sH27NdVBfn1pjINMgOV KJDCYa3GNvZs/cgDkwaMKvU67H0OVKxnRsG5U3cVwo33IEXKE9ZMIhI72d8GnczrS7qU H4NfpEogsUkA7NRdxZsdpAl5csF9hYcmeIHi8/ux25CLkz8PPdJwzJen9w2AbHsJSYgl TvTQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="iC/n65fl"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-166481-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-166481-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id u18-20020a05622a14d200b0042aaa53f36dsi899406qtx.573.2024.05.02.06.04.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 May 2024 06:04:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-166481-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="iC/n65fl"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-166481-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-166481-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 5EFD01C20F85 for ; Thu, 2 May 2024 13:04:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C7BB984A24; Thu, 2 May 2024 13:04:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iC/n65fl" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EADCD32C60; Thu, 2 May 2024 13:04:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714655073; cv=none; b=CMMvVAO1weEEPKIAJjF9bXzfdcO1VchZusAzMfIaVkYMTqKDYvSAni5mV8OfvV0OUoZbzlK1hcc+acfuSxncc3PN0qp/mMKD/YpmOwky2OhRf2Gw/vNLhUCE4jxLDmirIKsv9gQdjaY5sCN+sZD1bX6kfj2qCDycoX2jSbAPn6Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714655073; c=relaxed/simple; bh=LxYoy5aryNP2HMhsf2xv0naIvXnZbLmH+o8waQE0UrY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kWD5SlOC25PN080cxgouhoC8R17s7t+i+foj04XMnt+tuFKfIqQj+BJYAmj/AxzMIhAmnlwr/5ZvWOupH5doRCbGgh+dF/jkP4G0c4EPn59nJBlww7GfE6PIT0Tra3d0ZxihHLETKQm2g86YVwKWYHEIWRgzDH8E5AQzAl1z4so= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iC/n65fl; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1FFD2C113CC; Thu, 2 May 2024 13:04:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714655072; bh=LxYoy5aryNP2HMhsf2xv0naIvXnZbLmH+o8waQE0UrY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iC/n65flUWWkvVzlWCRqHhOK18rapNIuK5TRG/60Hb4VkQXdaXhjcSKi45tYurzXB QYxWML007PwZWEYaYC5JoKXVbpDce+u5GoYgOZE0SB7ENfrm6za00f8roLirVb1LZ2 Ed5nKsebg88bbdxqn0+wtWQv00XkjpiY3aUBactJVBXkEmZs916WErcTaPTL6ZXc/Y vLeU2lJk/uHNzbaFk5bqxi0Bj/LKMSfbi5KmylDzMX+PScS9S3Nx7y39QHfXx9U74V qykma9KTEkX+aTgm91VfnSQOKKwOqen6N6WIBBZyofgr0nbg9NQWQd/khkmpQBBeza mvfQlsROA9dWg== Date: Thu, 2 May 2024 15:04:26 +0200 From: Christian Brauner To: Jan Kara Cc: cgzones@googlemail.com, Jan Kara , Alexander Viro , Arnd Bergmann , Thomas Gleixner , Kees Cook , Geert Uytterhoeven , Casey Schaufler , "peterz@infradead.org" , Sohil Mehta , Miklos Szeredi , Mark Rutland , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH] fs/xattr: unify *at syscalls Message-ID: <20240502-wegweisend-hippen-75aae5b9da3f@brauner> References: <20240430151917.30036-1-cgoettsche@seltendoof.de> <20240502103716.avdfm6r3ma2wfxjj@quack3> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240502103716.avdfm6r3ma2wfxjj@quack3> On Thu, May 02, 2024 at 12:37:16PM +0200, Jan Kara wrote: > On Tue 30-04-24 17:19:14, Christian Göttsche wrote: > > From: Christian Göttsche > > > > Use the same parameter ordering for all four newly added *xattrat > > syscalls: > > > > dirfd, pathname, at_flags, ... > > > > Also consistently use unsigned int as the type for at_flags. > > > > Suggested-by: Jan Kara > > Signed-off-by: Christian Göttsche > > Thanks! The change looks good to me. Christian, do you plan to fold this > into the series you've taken to your tree? Yep, that's the plan.