Received-SPF: pass (google.com: domain of linux-kernel+bounces-166500-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Zi Yan <ziy@nvidia.com>
To: Alexander Gordeev <agordeev@linux.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
 "Matthew Wilcox (Oracle)" <willy@infradead.org>,
 Yang Shi <shy828301@gmail.com>, Ryan Roberts <ryan.roberts@arm.com>,
 Barry Song <21cnbao@gmail.com>, David Hildenbrand <david@redhat.com>,
 Lance Yang <ioworker0@gmail.com>, linux-kernel@vger.kernel.org,
 linux-s390@vger.kernel.org
Subject: Re: [PATCH v5] mm/rmap: do not add fully unmapped large folio to
 deferred split list
Date: Thu, 02 May 2024 09:20:28 -0400
Message-ID: <0151832A-388A-40AF-8ABE-304C25B43E30@nvidia.com>
In-Reply-To: <ZjOSkPc8f5u5J6m5@li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com>
References: <20240426190253.541419-1-zi.yan@sent.com>
 <ZjJCdodEf4CBa1N7@li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com>
 <5FAD7FB6-4AC0-4427-B56E-4942A95DB68C@nvidia.com>
 <ZjOSkPc8f5u5J6m5@li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_A41DE513-9D3A-4B0F-95C2-9F2389B85FBD_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?KcoQ71B35zjfiZ0QgCxdJr0lmRE8iLIvdNRCwVd58Or3e+E0fMYqrOI7dDQI?=
 =?us-ascii?Q?iWBBclj/9QRQc/Xq3cA6ToZmxhjP7u6ypr/gGKxq67glCU1261Gpgk8aJ+0z?=
 =?us-ascii?Q?88tlo/zuV79VBcPnSXUpqoV+YJ2PK4T89TJyOLoJMwR+0bwZPe6qbAO0nNkc?=
 =?us-ascii?Q?qCSkji6h11K7XhLyPJgebkC/LSuWTPoPZGGIPpXbF23dRAUbR66rYL7O3QEt?=
 =?us-ascii?Q?+KIiArohP9PxPmR537JpuDJegCvBr29VeOqR+vRm0Xq40chr9mCvXfSQnmEZ?=
 =?us-ascii?Q?mDFHi/vn/zu3Q90Grt8SaJ9jou0WoX2aSzm572lqdEsUMMqnPaXIhABFEDDC?=
 =?us-ascii?Q?v9ZIeux3eP8EKiuF3plyUnUwX5KpHM7grx4GnexLQrmsGOhjbEiRTdHZWGmr?=
 =?us-ascii?Q?xoZzHx3Myj/qbsA6s0g9TnfvDDM9ob8pgJEXuQr3g5lHkU6DRdjzAQOo3zV3?=
 =?us-ascii?Q?WxSZVLyVd/pxBSlhvYR3HRGOpfXCB4j7M7d446PttZbVSAscMEZ1pflj+DiC?=
 =?us-ascii?Q?pmvY+j3Ua+Krm5bLgNIUEOX4K3qb202TofbNeCzXSG1npczbMwcX0J52Bh9Q?=
 =?us-ascii?Q?UcKnCf7i/xCbdiIamtgwBphhtMEB6qve2/WY/ubHZptMo/gS0MNJk6YvP/Oh?=
 =?us-ascii?Q?SOvv+lGdMzR+oI5QMOe58KWehmgANZzxvvNP2SrVs+YL7BxtcTotKGCgQk1h?=
 =?us-ascii?Q?+Tqux/EqauCkgQgyLVZfu7eQXCOI38hT0X+P5GDuMCLYATrDte4XV7ByQLIt?=
 =?us-ascii?Q?SgE9V9li43yqEM2N/aPrXGMhNYdDOFRn8y8cdxfqiWXN/h029odDVvsX9NqX?=
 =?us-ascii?Q?vfJvGOpWvBuR0PfOy29V9JX6YNv+FXzLTDZIXKa+0JQ8ByrnmBSE+70yRnW4?=
 =?us-ascii?Q?A2pjZtXzv3eqgx2KmbCDjJSWn0Ae4fvLF6Vdv9bktFY1ssTGQs0xkGqeYp27?=
 =?us-ascii?Q?ALaMwp7Zd+Ul/FzHxlgiubWXU8v0Ja08I+p/mfZA7UNKuz+ksHUKiIUaMJvY?=
 =?us-ascii?Q?awYS2ToyucznYGp3s//1oaGhBSQGS1QT8kuICDrCW6IDMZYwbSOOQiFwhtly?=
 =?us-ascii?Q?1i15ggbUnxt1FokQQxjbmqwA5chwCU/Roc3Y6F7qwrBAncgXEuCafD+yUXil?=
 =?us-ascii?Q?7Du72L5RLxNdw866CnXw/erxs/Z9skRA2xRtPCjo2JNFZ5F9OZkB/WRmGVJE?=
 =?us-ascii?Q?X0qZWzCIs4ENm58LEAjVZ7V04fpFWK/kr8mmxIu7H/gyNChh/nwrScaEvQ2P?=
 =?us-ascii?Q?XE7nDyRGhOxLtZJN6jt4aTPDAxMxKWjT4WUs/2n//MBwBDk59wUAE3avHS4M?=
 =?us-ascii?Q?xbfgJ1krhLGghGIpTmAyVFrigwa1okEpFuLmLhyDKOElMucXE6LFMvUftSsY?=
 =?us-ascii?Q?WMcmHoLKa5WAFSljTb7WRq/XIXssShgLrJYIACysVBEV6jqWSN/1GdKAK7Me?=
 =?us-ascii?Q?aisZPJnOtsI/amJeptg0agmw2bEdfgYpGMVnsIE45WT8cX5n474KIoNY1J6O?=
 =?us-ascii?Q?0R2XUEyl/sduFRLIAsdnRCwgyI4aPri/2tZmMoQYHqiZaSXgN7GbbM8n0fbw?=
 =?us-ascii?Q?judSRm7FDEsFXZnJaSiNpUW1/SIgurUr5WaoJiA0?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d034cf49-0fd1-4ed7-c35e-08dc6aaaa3ef
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2024 13:20:30.8284
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fVGAnUuKPA7duLtNKAiapdC8MgxawQkHi5ra6YrRjZdv92nEaR0RCedKn7/hh2A/
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8202

--=_MailMate_A41DE513-9D3A-4B0F-95C2-9F2389B85FBD_=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On 2 May 2024, at 9:18, Alexander Gordeev wrote:

> On Wed, May 01, 2024 at 09:38:24AM -0400, Zi Yan wrote:
> Hi Zi,
>> @@ -1557,9 +1557,8 @@ static __always_inline void __folio_remove_rmap(=
struct folio *folio,
>>                  * page of the folio is unmapped and at least one page=

>>                  * is still mapped.
>>                  */
>> -               if (folio_test_anon(folio) &&
>> -                   list_empty(&folio->_deferred_list) &&
>> -                   partially_mapped)
>> +               if (folio_test_anon(folio) && partially_mapped &&
>> +                   list_empty(&folio->_deferred_list))
>>                         deferred_split_folio(folio);
>>         }
>
> That helps.
>
>> Best Regards,
>> Yan, Zi
>
> Thanks!

Great! I will send a v6.

--
Best Regards,
Yan, Zi

--=_MailMate_A41DE513-9D3A-4B0F-95C2-9F2389B85FBD_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmYzkxwPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUF08P/AppBhA7R/l0drHEjiAItav9kVWfrMsjLOZi
gWdoUd9c5bdD0wZLF+j+70iarYx0VBooCu8XJDKMmYzuDLyQs71q6ypZuK2Xlpd1
qgrBu6pQITOJzZLtkJZUt7vDJmF9sG32YtR4wCeQa1M5xgePFPd4+EuFGG1C6O0m
ai0ydAOORmC8NeEOhVypLNBmwimiJCim7x7+GYuo+WOtacYRblAe+175aWZaUjHx
Thf19iArKnhgYMGOWE3WywtE/GlyZsQfxnUIp8uCNLtGaGjHooOdmzZMy7uB6Z5Y
2E8agGl0zeWQipoNHd17Xe9ZTemWlv+QCtprfyskYZFd1xEbycI9gFmG00dlU23F
z/J8KUMt6TOv4pPOqQuinKYuPSgvtlOgpwOubHlp29CdDyCowlBPesR3PEwTbj2o
ZGrq5wPasEQPWswmLga/KVJ++vNOB89PjFQfeA5yZmSPaaGYEOM9YIhMNTm8oPmX
ghXF/sQkoXDiCpcv+eibVn7uK/omDmhQ6aIjbQVM/ajfVGl2COek+OrLKE1WkCsR
41Ia+YC357PdPdWg7B2UdJbIKmJ6Ro/Ti9xKivn9krCvDBnBve8IdGErWG3xUR6z
+hwyBR6FetwCJOOrndwMyhhjPrc9xs9HRdtMXsUZ7ZKvewDeRvwYoCI9ti2pAN6k
LsRyIre2
=1xnh
-----END PGP SIGNATURE-----

--=_MailMate_A41DE513-9D3A-4B0F-95C2-9F2389B85FBD_=--