Received-SPF: pass (google.com: domain of linux-kernel+bounces-166517-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240501154251.3302887-1-dianders@chromium.org> <20240501084109.v3.7.Ib5030ab5cd41b4e08b1958bd7e51571725723008@changeid>
In-Reply-To: <20240501084109.v3.7.Ib5030ab5cd41b4e08b1958bd7e51571725723008@changeid>
From: Linus Walleij <linus.walleij@linaro.org>
Date: Thu, 2 May 2024 15:41:49 +0200
Message-ID: <CACRpkdYiND3uLAbFqyGEYgi5+ycOTYoncmSYGTsYtTZ7Ox=4DQ@mail.gmail.com>
Subject: Re: [PATCH v3 7/9] drm/panel: boe-tv101wum-nl6: Don't use a table for
 initting panels
To: Douglas Anderson <dianders@chromium.org>
Cc: dri-devel@lists.freedesktop.org, Jani Nikula <jani.nikula@linux.intel.com>, 
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, 
	Cong Yang <yangcong5@huaqin.corp-partner.google.com>, Hsin-Yi Wang <hsinyi@google.com>, 
	Brian Norris <briannorris@chromium.org>, Sam Ravnborg <sam@ravnborg.org>, 
	Neil Armstrong <neil.armstrong@linaro.org>, Javier Martinez Canillas <javierm@redhat.com>, 
	Joel Selvaraj <jo@jsfamily.in>, lvzhaoxiong@huaqin.corp-partner.google.com, 
	Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@gmail.com>, 
	Jessica Zhang <quic_jesszhan@quicinc.com>, 
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, 
	Thomas Zimmermann <tzimmermann@suse.de>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, May 1, 2024 at 5:43=E2=80=AFPM Douglas Anderson <dianders@chromium.=
org> wrote:

> Consensus on the mailing lists is that panels shouldn't use a table of
> init commands but should instead use init functions. With the recently
> introduced mipi_dsi_dcs_write_seq_multi() this is not only clean/easy
> but also saves space. Measuring before/after this change:
>
> $ scripts/bloat-o-meter \
>   .../before/panel-boe-tv101wum-nl6.ko \
>   .../after/panel-boe-tv101wum-nl6.ko
> add/remove: 14/8 grow/shrink: 0/1 up/down: 27062/-31433 (-4371)
> Function                                     old     new   delta
> inx_hj110iz_init                               -    7040   +7040
> boe_tv110c9m_init                              -    6440   +6440
> boe_init                                       -    5916   +5916
> starry_qfh032011_53g_init                      -    1944   +1944
> starry_himax83102_j02_init                     -    1228   +1228
> inx_hj110iz_init.d                             -    1040   +1040
> boe_tv110c9m_init.d                            -     982    +982
> auo_b101uan08_3_init                           -     944    +944
> boe_init.d                                     -     580    +580
> starry_himax83102_j02_init.d                   -     512    +512
> starry_qfh032011_53g_init.d                    -     180    +180
> auo_kd101n80_45na_init                         -     172    +172
> auo_b101uan08_3_init.d                         -      82     +82
> auo_kd101n80_45na_init.d                       -       2      +2
> auo_kd101n80_45na_init_cmd                   144       -    -144
> boe_panel_prepare                            592     440    -152
> auo_b101uan08_3_init_cmd                    1056       -   -1056
> starry_himax83102_j02_init_cmd              1392       -   -1392
> starry_qfh032011_53g_init_cmd               2256       -   -2256
> .compoundliteral                            3393       -   -3393
> boe_init_cmd                                7008       -   -7008
> boe_tv110c9m_init_cmd                       7656       -   -7656
> inx_hj110iz_init_cmd                        8376       -   -8376
> Total: Before=3D37297, After=3D32926, chg -11.72%
>
> Let's do the conversion.
>
> Since we're touching all the tables, let's also convert hex numbers to
> lower case as per kernel conventions.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>

Wow that's a *VERY* nice patch.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

The metrics surprisingly reports more compact object code,
I wasn't expecting this, but it's nice.

Yours,
Linus Walleij