Received-SPF: pass (google.com: domain of linux-kernel+bounces-166531-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <44f47927-52aa-5248-6ae4-21028076fd51@axentia.se>
Date: Thu, 2 May 2024 15:49:03 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: Supporting a Device with Switchable Current/Voltage Measurement
Content-Language: sv-SE
To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>,
 =?UTF-8?Q?Jo=c3=a3o_Paulo_Gon=c3=a7alves?= <jpaulo.silvagoncalves@gmail.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
 joao.goncalves@toradex.com
References: <20240501233853.32y4ev7jvas5ahdz@joaog-nb>
 <20240502133623.0000463e@Huawei.com>
From: Peter Rosin <peda@axentia.se>
In-Reply-To: <20240502133623.0000463e@Huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cUFkbzNhZVlmaXpLVUtrQVBQeVdiZFFqbGZlZlJuRFhTUTc1TnRJZTFSNU84?=
 =?utf-8?B?dnpUekZvazl1ZEZ5bndhdjNVSFE4UnU3U1hQZXA1SFJxcUwyV29rbmV1VmdZ?=
 =?utf-8?B?WHdBb3hySnllQXB0ZktyV3BOSFg4YzBwenJRTHJ4SG1NYnZvR0htOUpoNTQ4?=
 =?utf-8?B?dUpZbjJxbU5mSS94WnorcEFiRk9vWkR3dG1KNEtGV1kva2d3dW5LL2t5MUdF?=
 =?utf-8?B?UVNGTllUR0JOOVRPSHhNQlk2d0llb1pLKzNkMCtvYUdwT2l6RWVrS0JmNVpQ?=
 =?utf-8?B?QTRwc0tiMURWNlFkSGNlWGovUHA1dlBneWNkRXdzM3pBNVJ1Ymc2VHZZc3Rt?=
 =?utf-8?B?dVppR0pZbEE3bVBsbEluZTNOTmRPYTdaRDYwZTh3UktWQVlTN3Uvb2toSFlJ?=
 =?utf-8?B?eEhxemtsbVhOSyszbEt1dlJLdWVNQ3NRTE0vM1hQVW8xejBMTDB4RVpldHBM?=
 =?utf-8?B?ZmpyTW1VOTkybnBFNFdGQnZWTlB6ZzcwYW1GektJcjFJemxTbUQ4UkFpNmZZ?=
 =?utf-8?B?ejBOMTZNVUt3VjlsbXo3Yk9DWGwvNFJkQW5ZU3NIVGMxSnoySmVjZ3NOQzBY?=
 =?utf-8?B?cGt0aDdtTVJqNml3RDZrVFVTazFwV0lvbEtnMnNsTE5tbDZqUDN0REhhVUJw?=
 =?utf-8?B?N0cyWWRGYnRYRWhXTlluUVhRdWg1NTU5K2RyTmhRcmtBMFpIT2NYNUNUMzVH?=
 =?utf-8?B?Y2k3RGxmOGZKdk5lVk5qZEtpVU9FaVY4TWxqQ0RQUlZ1R3FoM1N4eWRnQ1JO?=
 =?utf-8?B?anVoT3cwWVBNc3VJWStHdlpPeHcxQ01Lc21sOFJsT2t2c2doMnNJbkROampw?=
 =?utf-8?B?bldISWhKdjdRUi9YQVRVYjVuKzRTekFpeDFkVzd3MFVEemZONXNKSzV3TWNJ?=
 =?utf-8?B?eUZDNWIrdDQ3c2JLUzl5TkZTR2liS3ladmFNRTVOa1Y2MUNYQjRJcEhjNzR6?=
 =?utf-8?B?K2hPQUNoNHp5ejFOVEgwdjhQcVlxNFFiRjVwSUwrU0E0WWVVd1BIYytPeUxh?=
 =?utf-8?B?aWxlc1lFME8vc2hPaHlmUXZHQm1kRnlkNlcvd1ZlTFI3Ulk1NUtoK093L2RN?=
 =?utf-8?B?dEdzMlova2pKQ0dVVS9IRkxpMGNQUGVrN0VUTEhqZ0VTMWF3REd5UVdhMkg1?=
 =?utf-8?B?ZVVpV0FhVDNoajhmTXVlYm8xVmVMN2hLWWZXczRlTmFPMjJoL0NERzF1WmJL?=
 =?utf-8?B?dDRWWHhXdlJFUDR5dExkNzkrZkkyWml5L3dZYXYvZGIwekllZnEzRkZ3aUF6?=
 =?utf-8?B?QkY5NC92NHY1NnR6RTFheVVGN2JBZ1dBbTlEK2MwKzQ4Wjk1bDI4cG96azRk?=
 =?utf-8?B?b1l4Y1J1ZytFdGhPNzZXK1ZzWGkycUo1REhWRnNOLzhYdXNaTy94UHVVQjZV?=
 =?utf-8?B?b2RYKzdmdmtORE9FTGhQclNyYy9hejhzeWlXQjE4RllkdTR3MEhNdHBJT0My?=
 =?utf-8?B?NGU4Uk1OME9tQUNqblVHcU5qQWo4dGZDeXVJcStsYkRLZkMrcC9URHdNZGtL?=
 =?utf-8?B?OVgrL0hDT09PN3NHdWtYai80Q2wwTU8yQU12Y3lKVTNBTUJaTHBONWZUUHlC?=
 =?utf-8?B?S3hNN3J6Wlh0UEQ5OUdzZVd2NzhGNjJBWCs4Z05wanJmVng1MitML3lwYVN4?=
 =?utf-8?B?UFFsd3NYOTJwTEVQUTRiS1JNNGwrVlk5RFFxOXpaV3krSVAyUkFIdnRUbVBn?=
 =?utf-8?B?WHpGckM3Sm4zSVQ5eStUR1dia2hScVJhd3Rqc2sxK2xnMGVUT05leGRaYXU2?=
 =?utf-8?B?S0szc2tlWUJObWM2YVFIdzZmSUxNWElVNXJKdnFScFUvSllPTVgxdmJEM3J4?=
 =?utf-8?B?Z3dzRE5HN090VWYwMjIvVFRsMFFHMnV6c0RVL294bHF2L0llN1dnUVM0bDdu?=
 =?utf-8?B?cWVTQVNlcjZGRjhBb3QwRUpYaXpHV3pDRHkxeFBmUDIxQ25XajdSNEQxR2hZ?=
 =?utf-8?B?anFDemxLVlRFL0VlVERLNVlnTFZ2RGpMUVM2QUo5QW42V2hrVm5HRGlWMHdw?=
 =?utf-8?B?SEVhUmN6ZXd0NTdtWFpWeDF1MlJoNU91VkNPeGJwRnZvcG1KeTZPWHhnZXlN?=
 =?utf-8?B?bGtmYW5MZTJtYkd1Z3JFdko4UVh2alh0bkhyY2NpbzBtV3ZjQlU0ZHlqREw1?=
 =?utf-8?Q?uyMLWKufk5S1RdGzmUVKnhinP?=
X-OriginatorOrg: axentia.se
X-MS-Exchange-CrossTenant-Network-Message-Id: a9ed68ce-d6ef-442b-7091-08dc6aaea1e4
X-MS-Exchange-CrossTenant-AuthSource: DU0PR02MB8500.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2024 13:49:05.5321
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: E8jE3M6SAaL/eZ+6jJJwLWB6FrB/Lyv1MKVPqPcZWi/DYBzWBW6p8xkZZALpkSgT
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR02MB8457

Hi!

2024-05-02 at 14:36, Jonathan Cameron wrote:
> On Wed, 1 May 2024 20:38:53 -0300
> João Paulo Gonçalves <jpaulo.silvagoncalves@gmail.com> wrote:
> 
>> Hello all,
>>
>> We need to support a hardware that can measure current and voltage on
>> the same differential analog input, similar to a multimeter. The mode
>> of measurement is controlled by a GPIO switch and goes to different
>> ADC inputs depending on the mode. If the switch is enabled, a current
>> loop with a shunt is enabled for current measurement; otherwise, voltage
>> is measured. From the software point of view, we are considering using
>> the iio-rescale driver as a consumer of an ADC IIO parent device. One
>> of the problems is that we need to change the mode of measurement at
>> runtime, but we are trying to avoid using some userspace "hack". The
>> other is that for a minimal solution to enable the mode from boot, we
>> can use a gpio-hog and control it with overlays. However,
>> still would be better that this was done by the kernel. Do you know
>> or have some guidance on how to properly support this in the kernel?
>>
>> For the in kernel gpio solution, this is a draft of DT we are thinking:
>>
>> current-sense {
>>       compatible = "current-sense-shunt";
>>       io-channels = <&adc 0>;
>>       gpio = <&main_gpio0 29 GPIO_ACTIVE_HIGH>;
>>       shunt-resistor-micro-ohms = <3300000>;      
>> };
>>
>> voltage-sense {
>>         compatible = "voltage-divider";
>>         io-channels = <&adc 1>;
>>         gpio = <&main_gpio0 29 GPIO_ACTIVE_LOW>;
>>         output-ohms = <22>;
>>         full-ohms = <222>;
>> };
>>
>> Regards,
>> João Paulo Gonçalves
>>
> +CC Peter Rosin who wrote all the relevant parts you need I think.
>>
> 
> Superficially sounds like you want a mixture of appropriate analog front ends
> and a Mux.  I haven't tried the combination but it should be possible to do
> something like this with 
> 
> An IIO mux via this binding
> https://elixir.bootlin.com/linux/v6.9-rc6/source/Documentation/devicetree/bindings/iio/multiplexer/io-channel-mux.yaml
> (that includes a gpio-mux example).
> 
> Consumed in turn by a pair of AFE devices.
> 
> Then you should be able to just read from which ever of the AFE device you want.
> A sysfs read from
> /sys/bus/iio/devices/iio\:deviceA/in_voltage_raw
> will switch the mux to appropriate place then request the
> voltage from the iio-mux, which in turn requests it from the ADC IIO driver.
> 
> /sys/bus/iio/devices/iio\:deviceB/in_current_raw
> switches the mux the other way and otherwise the flow as above.

Since you appear to need to change both the gpio pin and the io-channel, the
mux isn't a perfect fit. The closest you can get with the current code is to
create a gpio mux, I think. You would then use that mux twice to fan out both
io-channels, but only expose the "left leg" on the first fan-out and only the
"right leg" on the other. Something like this (untested, probably riddled with
errors, use salt etc etc):

rcs: raw-current-sense {
	compatible = "current-sense-shunt";
	io-channels = <&adc 0>;
	io-channel-name = "raw-current";
	#io-channel-cells = <1>;

	shunt-resistor-micro-ohms = <3300000>;
};

rvs: raw-voltage-sense {
	compatible = "voltage-divider";
	io-channels = <&adc 1>;
	io-channel-name = "raw-voltage";
	#io-channel-cells = <1>;

	output-ohms = <22>;
	full-ohms = <222>;
};

mux: gpio-mux {
	compatible = "gpio-mux";
	#mux-control-cells = <0>;

	gpios-mux = <&main_gpio0 29 GPIO_ACTIVE_HIGH>;
};

current-sense {
	compatible = "io-channel-mux";
	io-channels = <&rcs 0>;
	io-channel-names = "parent";

	mux-controls = <&mux>;

	channels = "current", "";
};

voltage-sense {
	compatible = "io-channel-mux";
	io-channels = <&rvs 0>;
	io-channel-names = "parent";

	mux-controls = <&mux>;

	channels = "", "voltage";
};

What the mux solves is exclusion, so that the gpio pin is locked while
measurement is made on either current-sense or voltage-sense.

However, the channels from the raw-{current,voltage}-sense nodes are exposed
to user space, and it will be possible to make "raw" measurements without
regard to how the gpio pin is set. That will of course not yield the desired
results, but is also a user error and might not be a big problem?

Cheers,
Peter