Received-SPF: pass (google.com: domain of linux-kernel+bounces-166137-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Thu, 2 May 2024 10:45:04 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Daniel Bristot de Oliveira <bristot@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>, Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
	Valentin Schneider <vschneid@redhat.com>,
	linux-kernel@vger.kernel.org,
	Luca Abeni <luca.abeni@santannapisa.it>,
	Tommaso Cucinotta <tommaso.cucinotta@santannapisa.it>,
	Thomas Gleixner <tglx@linutronix.de>,
	Joel Fernandes <joel@joelfernandes.org>,
	Vineeth Pillai <vineeth@bitbyteword.org>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Phil Auld <pauld@redhat.com>,
	Suleiman Souhlal <suleiman@google.com>,
	Youssef Esmat <youssefesmat@google.com>,
	Daniel Bristot de Oliveira <bristot@kernel.org>
Subject: Re: [PATCH V6 2/6] sched/deadline: Deferrable dl server
Message-ID: <20240502084504.GX30852@noisy.programming.kicks-ass.net>
References: <cover.1712337227.git.bristot@kernel.org>
 <7b9c206e914ef257a2534199f25938ffafa3e59e.1712337227.git.bristot@kernel.org>
 <20240410174749.GC30852@noisy.programming.kicks-ass.net>
 <c4c6575d-5ea0-44ba-bbdc-eadad77dea81@redhat.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c4c6575d-5ea0-44ba-bbdc-eadad77dea81@redhat.com>

On Thu, May 02, 2024 at 10:35:02AM +0200, Daniel Bristot de Oliveira wrote:
> On 4/10/24 19:47, Peter Zijlstra wrote:
> >> +static enum hrtimer_restart dl_server_timer(struct hrtimer *timer, struct sched_dl_entity *dl_se)
> >> +{
> >> +	struct rq *rq = rq_of_dl_se(dl_se);
> >> +	enum hrtimer_restart restart = 0;
> >> +	struct rq_flags rf;
> >> +	u64 fw;
> >> +
> >> +	rq_lock(rq, &rf);
> > 	guard(rq_lock)(rq, &rf);
> 
> this is the way I found to get the &rf... inspired on sched_rr_get_interval():
> 
>         scoped_guard (rq_lock, rq) {
>                 struct rq_flags *rf = &scope.rf;
> 
> is that right?
> 
Yeah, it's a bit ugly, but yes.