Received-SPF: pass (google.com: domain of linux-kernel+bounces-166538-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <ad190ae3-48d2-a5db-dd36-d52b1c4cf460@axentia.se>
Date: Thu, 2 May 2024 16:05:45 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: Supporting a Device with Switchable Current/Voltage Measurement
Content-Language: sv-SE
From: Peter Rosin <peda@axentia.se>
To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>,
 =?UTF-8?Q?Jo=c3=a3o_Paulo_Gon=c3=a7alves?= <jpaulo.silvagoncalves@gmail.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
 joao.goncalves@toradex.com
References: <20240501233853.32y4ev7jvas5ahdz@joaog-nb>
 <20240502133623.0000463e@Huawei.com>
 <44f47927-52aa-5248-6ae4-21028076fd51@axentia.se>
In-Reply-To: <44f47927-52aa-5248-6ae4-21028076fd51@axentia.se>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VkdnZWRhMVljaTFNdWxnNTdnVDU3Rkg0cXN2b1hTcERYSnhOOWVBVTQ1NXVz?=
 =?utf-8?B?bW1QcWM0Z0hVTEFDVVJ2ZW9ZS2daMG16cXUxMGcyRG8yVEZMZkVLSEptZWRU?=
 =?utf-8?B?ZSs4bnRHbWlJREgxNk84WnFONGpJWnBmWVhCUHpRelljMTRuaVlITmswSjRW?=
 =?utf-8?B?WGN0UWVrb0ZpQ0dHQ1o0M1BHT0wwNkR4ZkZuemQzV3p3MzJlNm9WWjJkOGJl?=
 =?utf-8?B?Um1qMHlDeEhGeEI2QmxsY2MxeE96K2huNU5xTlNBdEI5R1B3SVBaT01jNXEr?=
 =?utf-8?B?Y3J4MGs4QituRnBXMjlKOWlQcER0bVdLQU5aSWc0RXVDbHpWNXh3Lys5bGFt?=
 =?utf-8?B?Qlh5bmhSQ0d5WDRhb2FFOHJ5YUoySEoyNDZjbXZuSXdFdC9PRVB0N3JRRlhR?=
 =?utf-8?B?SmFwRVdiREJCTzJjWTNHR0RnbHZWdlVXUDJoYThZWVJ4WmpwVUZRUmx1eExS?=
 =?utf-8?B?VGR3blhsVlNmbnVONHl4REdiaUdFVXZaN1hlLzgrY1A5NFA4aHpJd080UzZo?=
 =?utf-8?B?UDFScG4yQWxnN1IwRTFSemkvWGV5a0ZqbnI4VFRaRTMxbzBrY1hEeEtPMjhk?=
 =?utf-8?B?ZUNsNndwNHNvQXF3NWF2NXcvYit6bCtmbWRCcWtScFV6dkZaVEt1ZHpWWDZB?=
 =?utf-8?B?RGFGWlR2d0UvMTcyWlZNRWJTZ1NiUTdPN3ZIV3hDQUJpcWF4SnUyRTJ3V2pW?=
 =?utf-8?B?eVM2UCtmSENmUWkrSzlNNWVzTllCcGNHZ2J2cmY5aWlhM1FvQ1g3dmplTlUv?=
 =?utf-8?B?c3JGSkI5L2Q5UXpoanM1b2hsMXZOMVBTblIvNTlhWEdLcWc4dEpaSTlXUGRv?=
 =?utf-8?B?dzFLRzA4MndtUXFBZWozWWxnZHNvS1BLK3V3eThXbUNUczJ6ZXplMEFnUlZp?=
 =?utf-8?B?UElhNTIyb3NyNmRwWFBhWDdZR244YVp6MlZndncwS3RSUnVxa3BtT09mT0dQ?=
 =?utf-8?B?MWhWc3Z3TDdObVQvTnJRY200TldqZk53TWN6ZnlWeklUcytSNFVrNkw1d0pa?=
 =?utf-8?B?Qmx5THVlSjZmb001cWhObHU3RXFOTXpQZG1GejhBUDltSm11cG1tTlpQTTRZ?=
 =?utf-8?B?aXpPSjdKbEVjWXlpTlh1Q2JhZHFVWG50TENQWkM1bGRKVkpoQ2ZFY2FiR1B2?=
 =?utf-8?B?VmJRRmdPbzBLT0NneENVMXM2YnBqOFFQK2tTdnZGSVE0djg3c0cxcld3QTBI?=
 =?utf-8?B?K2NXMUFRdGp6Y2xBK2Q1OEtWNUJOK3E1NUpqNUVLa0YzUHpaMVdlc3hCMG9V?=
 =?utf-8?B?eUhVKzdhRE8zaG1yWUN3YjV5L1YxQXA2eGk3SGhwZFdRSis4WkVnUW5YQUxy?=
 =?utf-8?B?NHJvN3h6bVJMdUdhOTNtK2lWZnFrem9QelBFY3pnVkg5dE5na2U4NUJiVUZx?=
 =?utf-8?B?TGxDS2E1dCs5OWZhSjFPRlo2YlVtYnF6L2ZJSGE2YTZBVGdETWhqeGQyL2pQ?=
 =?utf-8?B?M0tKZEUxNkc0ZENRcEJiWEo3aHVEb21BYzhUUXFOaFdmUHJJeVZIUGdBR3kz?=
 =?utf-8?B?SlZZbS9Rb0luU3RPdldXQlpjU1pwY0pKdTdRWVNaVmU1RE4wYzRYclRoSHJN?=
 =?utf-8?B?Q2U3NWxpYkRVVU9wTHdoN25TNGNBbHFXS1k1Y0VTRWJIeFhUSzRMZlRtRFBU?=
 =?utf-8?B?Y1gwTDA2bzBYQ0hka1REeHM0WGFSeTdMMGRNcWZTa3NoalQ4ajNDZTNPb3Bv?=
 =?utf-8?B?R1d0VEpCWXpjM1Nzci8rWmQ4TGtreU56bnRVenQrUEtvcVBRTXhmOHdndkkw?=
 =?utf-8?B?RDFHVjJuYW9pNXdUL3NUMFhwR2FzekNKTjJDcGgyVkFWRm9jSWlEWWgrUldi?=
 =?utf-8?B?NDVjcFdnU042eVdvQ09hVGtDeVhiTEpVYVdMaE5Ubm5jS3hsUUxHVk9GQXli?=
 =?utf-8?B?d1Nqdis2T0pjZHYyT2NzQlVpUTZaVkxFZUhMT0V4RGdTQTl1Y1dMSFI2SVlL?=
 =?utf-8?B?L0dNbm9lVUFMdkhtZVY2dUtKVWFQdDRUN3lnS2dPVTV3TElvSlpxelpITGxH?=
 =?utf-8?B?a1dza3crdVE2Y0sxTGJFOWVDVjBzekg5MEJTWGUxTk5NbHVqV2JaMkZpeHhI?=
 =?utf-8?B?OXhTWXFpRWE0WElzL1RvY29JNjBZbCtyc2h5K05MRGd5c3p5bGhBeDkyRzFV?=
 =?utf-8?Q?itv4RP+GQvSUz+Xd3krDHX6/n?=
X-OriginatorOrg: axentia.se
X-MS-Exchange-CrossTenant-Network-Message-Id: a1bb5629-625e-414f-cda5-08dc6ab0f733
X-MS-Exchange-CrossTenant-AuthSource: DU0PR02MB8500.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2024 14:05:47.5456
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vYeQ9mzftDHE5vx7xdfSs8q1/nz+7UCALNPNb4u6uL8Od8RVy/kJZTFqqc52JXuS
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR02MB9125

2024-05-02 at 15:49, Peter Rosin wrote:
> Since you appear to need to change both the gpio pin and the io-channel, the
> mux isn't a perfect fit. The closest you can get with the current code is to
> create a gpio mux, I think. You would then use that mux twice to fan out both
> io-channels, but only expose the "left leg" on the first fan-out and only the
> "right leg" on the other. Something like this (untested, probably riddled with
> errors, use salt etc etc):
> 
> rcs: raw-current-sense {
> 	compatible = "current-sense-shunt";
> 	io-channels = <&adc 0>;
> 	io-channel-name = "raw-current";
> 	#io-channel-cells = <1>;
> 
> 	shunt-resistor-micro-ohms = <3300000>;
> };
> 
> rvs: raw-voltage-sense {
> 	compatible = "voltage-divider";
> 	io-channels = <&adc 1>;
> 	io-channel-name = "raw-voltage";
> 	#io-channel-cells = <1>;
> 
> 	output-ohms = <22>;
> 	full-ohms = <222>;
> };
> 
> mux: gpio-mux {
> 	compatible = "gpio-mux";
> 	#mux-control-cells = <0>;
> 
> 	gpios-mux = <&main_gpio0 29 GPIO_ACTIVE_HIGH>;
> };
> 
> current-sense {
> 	compatible = "io-channel-mux";
> 	io-channels = <&rcs 0>;
> 	io-channel-names = "parent";
> 
> 	mux-controls = <&mux>;
> 
> 	channels = "current", "";
> };
> 
> voltage-sense {
> 	compatible = "io-channel-mux";
> 	io-channels = <&rvs 0>;
> 	io-channel-names = "parent";
> 
> 	mux-controls = <&mux>;
> 
> 	channels = "", "voltage";
> };
> 
> What the mux solves is exclusion, so that the gpio pin is locked while
> measurement is made on either current-sense or voltage-sense.
> 
> However, the channels from the raw-{current,voltage}-sense nodes are exposed
> to user space, and it will be possible to make "raw" measurements without
> regard to how the gpio pin is set. That will of course not yield the desired
> results, but is also a user error and might not be a big problem?

I just realized that it's also possible to do this "the other way around". Maybe
that makes more sense?

Cheers,
Peter

mux: gpio-mux {
	compatible = "gpio-mux";
	#mux-control-cells = <0>;

	gpios-mux = <&main_gpio0 29 GPIO_ACTIVE_HIGH>;
};

rcs: raw-current-sense {
	compatible = "io-channel-mux";
	io-channels = <&adc 0>;
	io-channel-names = "parent";
	#io-channel-cells = <1>;

	mux-controls = <&mux>;

	channels = "raw-current", "";
};

rvs: raw-voltage-sense {
	compatible = "io-channel-mux";
	io-channels = <&adc 1>;
	io-channel-names = "parent";
	#io-channel-cells = <1>;

	mux-controls = <&mux>;

	channels = "", "raw-voltage";
};

current-sense {
	compatible = "current-sense-shunt";
	io-channels = <&rcs 0>;
	io-channel-name = "current";

	shunt-resistor-micro-ohms = <3300000>;
};

voltage-sense {
	compatible = "voltage-divider";
	io-channels = <&rvs 1>;
	io-channel-name = "voltage";

	output-ohms = <22>;
	full-ohms = <222>;
};

Cheers,
Peter