Received: by 2002:ab2:60d1:0:b0:1f7:5705:b850 with SMTP id i17csp1168779lqm; Thu, 2 May 2024 07:12:41 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVDRw3/zaeyBeS98SPAvl+v4VKxyRQglVwQdyMCb47lP4r2h+QVCUELVkw1HUmIx3o3IKIzfN11C+dFb+Ww+EI6DuwiLu2hHZkMeeV5Og== X-Google-Smtp-Source: AGHT+IHCiX+MJVo4Vo89RnLWeVvYznUDHJEz2J326y+0ZLeIacWP5pDwer/RsVmypcYlzo3+8dAs X-Received: by 2002:a05:6a00:b44:b0:6e6:843f:1d05 with SMTP id p4-20020a056a000b4400b006e6843f1d05mr7083855pfo.25.1714659161233; Thu, 02 May 2024 07:12:41 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714659161; cv=pass; d=google.com; s=arc-20160816; b=GweuKTHHXEbtJJgS1QBca+poG8lNNCkRuYk9KfxLO4qgC8b0Tn/BKFoMbn+OdnS2hM QK5JNAehbw9s5tyYeb/CejTm/8VaQkkpPqWMuhSXZn0S23Iv0XOA9QVdWODD7WdTNmDG 3zKwlVikL6Xg/a1j1KwTOnFPDJ+q2BBQY4DEMH5kiYWlW26j1LAF7pf+EibeFsD9z7A3 tvpQICgM4GF2HoJJtTsGQAKkuK0PwlQSR9dsilpakwmVOwXBE4ZxvZtqdlEZDrA9/Is5 oIuyIL4DizF/CN8zDBOsCDMH5UZv++N55t9gdliggM+8wdmIK4svKSKBEzR51nt7CL1Y vfEg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=5d3azp869YJn/WuaigFejBjYigEGdTbM422RXbQMjvI=; fh=3hKz51zTz6VXVdpBaw0JLGowhqkc6rgkvLWD1TAIb28=; b=pqaNm8xBqEeTw2P3ijLyUvkw3ieAccYzbsCXbdcMXUoqeJYAQxKJK14U69FXUz9xAO 2Iu1pPtMFHE9802TY7W/OWd9L2UWfnxz4uWtgQ4TlsPCrh4FZzEfWYZgobLRehPlzj8D Hhka+iHYNKiI39uvhvUJ111kmVw6vMCzct013TiipTSBz5Q9mw/lEVmRsmgf0lQU9QHS 8D4BO1tSEyaS1jarSI6tprjCJIpXrRdpmF6og2/toZzDzD/bUaVeItomi8ZJPB/z6NWT RxIX0fv5rK3Yg80dgbZQdoq0mDpN5ponZbzDcN8EhCDeQLoV9cw0xHW74DKmTDAP3aHD 9eWg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GVMXDmU1; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-166541-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-166541-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id r68-20020a632b47000000b005dc86450fc8si1015707pgr.515.2024.05.02.07.12.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 May 2024 07:12:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-166541-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GVMXDmU1; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-166541-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-166541-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id D6E02281D0F for ; Thu, 2 May 2024 14:12:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D4DA013C699; Thu, 2 May 2024 14:12:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GVMXDmU1" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02F6B12DDBF; Thu, 2 May 2024 14:12:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714659154; cv=none; b=JZIcQ7MZzu/+iRVq34+LrBlF08wj08ai4DJ+Ysya+uaNuwABkrlpNc0FrzOo4I0zJbkPK/ArwrI3ilGF58bYxPvNc6EhA26HVe4XMpoTdrHWj9NT++9e2F6nvND5Uo3zbaFIEeebCYkSzDhxhXxMKIrH/a/O3f3xR9CswpZi+Ac= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714659154; c=relaxed/simple; bh=APYmhw1izKZnLnWSVZlvp9Yc0FRlykckQXCKWnvWuPo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mSAvpSfx4VSMTj6yIvq/CXcbX9qLMLKE/5GUzBXGlarQyyUo6EjntSBpcaW3X7phVBaTJ/GP+0u/LgGIs30AQzUjd0Dh5P8tXy/Rs0c1hFToAXbDsOgUSqLJAU+v+C3t5Pi6YvDk4Ji3zYZY26YbX8taxbfTj1YK1tAeWSz6pEg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GVMXDmU1; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C481C113CC; Thu, 2 May 2024 14:12:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714659153; bh=APYmhw1izKZnLnWSVZlvp9Yc0FRlykckQXCKWnvWuPo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GVMXDmU1RJ+EhWd3nXOR9t3euMFo7lWLAeFcUtDGLEGe6kjYN5WMqknNpFiu3sAhN WIQzcEoX139cAujwDFxwLcErn+d32M/CIbmAfZJ0tbVxlf3Yl0FZUzYAfRtSAEcXFE 1SZW59djndvAjYa3cJKOqUEVso+KnT9rJE/JB48Ds/eSF/F9ngAS7VVaG8M35dXA0G Ec27tN7JMq2IUNmJgyjPxW3fafOUnFpVtFwOGwFXw4c9at0/kPqAwQ/hPGfV+vOkoe 4fAuNZVc2nqJU1/IkJ1ENxQgnHjjNGxfguyr2PVkt1k83TMFrr0LVXucH8N3lgs5/V 0FMwr+LEXuf0Q== Date: Thu, 2 May 2024 16:12:28 +0200 From: Christian Brauner To: =?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?= Cc: Jakub Kicinski , Kees Cook , Mark Brown , Shengyu Li , Shuah Khan , "David S . Miller" , =?utf-8?Q?G=C3=BCnther?= Noack , Will Drewry , kernel test robot , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan Subject: Re: [PATCH v3 7/9] selftests/pidfd: Fix wrong expectation Message-ID: <20240502-leiden-wegnehmen-9ac8f35c7204@brauner> References: <20240429191911.2552580-1-mic@digikod.net> <20240429191911.2552580-8-mic@digikod.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240429191911.2552580-8-mic@digikod.net> On Mon, Apr 29, 2024 at 09:19:09PM +0200, Mickaël Salaün wrote: > Replace a wrong EXPECT_GT(self->child_pid_exited, 0) with EXPECT_GE(), > which will be actually tested on the parent and child sides with a > following commit. > > Cc: Christian Brauner > Cc: Shuah Khan > Reviewed-by: Kees Cook > Signed-off-by: Mickaël Salaün > Link: https://lore.kernel.org/r/20240429191911.2552580-8-mic@digikod.net > --- Looks good to me, Reviewed-by: Christian Brauner