Received-SPF: pass (google.com: domain of linux-kernel+bounces-166577-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 2 May 2024 17:42:58 +0300
From: Leon Romanovsky <leon@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com,
	edumazet@google.com,
	Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
	Jason Gunthorpe <jgg@ziepe.ca>, netdev@vger.kernel.org,
	"open list:HFI1 DRIVER" <linux-rdma@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND net-next v5] IB/hfi1: allocate dummy net_device
 dynamically
Message-ID: <20240502144258.GJ100414@unreal>
References: <20240430162213.746492-1-leitao@debian.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240430162213.746492-1-leitao@debian.org>

On Tue, Apr 30, 2024 at 09:22:11AM -0700, Breno Leitao wrote:
> Embedding net_device into structures prohibits the usage of flexible
> arrays in the net_device structure. For more details, see the discussion
> at [1].
> 
> Un-embed the net_device from struct hfi1_netdev_rx by converting it
> into a pointer. Then use the leverage alloc_netdev() to allocate the
> net_device object at hfi1_alloc_rx().
> 
> [1] https://lore.kernel.org/all/20240229225910.79e224cf@kernel.org/
> 
> Acked-by: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---
> Changelog
> 
> v5:
>        	* Basically replaced the old alloc_netdev() by the new helper
>           alloc_netdev_dummy().
> v4:
>        	* Fix the changelog format
> v3:
>        	* Re-worded the comment, by removing the first paragraph.
> v2:
>        	* Free struct hfi1_netdev_rx allocation if alloc_netdev() fails
>        	* Pass zero as the private size for alloc_netdev().
>        	* Remove wrong reference for iwl in the comments
> ---
>  drivers/infiniband/hw/hfi1/netdev.h    | 2 +-
>  drivers/infiniband/hw/hfi1/netdev_rx.c | 9 +++++++--
>  2 files changed, 8 insertions(+), 3 deletions(-)
> 

Thanks,
Acked-by: Leon Romanovsky <leon@kernel.org>