Received-SPF: pass (google.com: domain of linux-kernel+bounces-166653-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 2 May 2024 11:36:10 -0400
From: Parker Newman <parker@finest.io>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Parker Newman <pnewman@connecttech.com>, linux-kernel@vger.kernel.org,
 linux-serial@vger.kernel.org, Greg Kroah-Hartman
 <gregkh@linuxfoundation.org>, Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH v1 03/13] serial: 8250_exar: Kill CTI_PCI_DEVICE()
Message-ID: <20240502113610.01881f3b@SWDEV2.connecttech.local>
In-Reply-To: <ZjOxQWc1OtGWatKC@smile.fi.intel.com>
References: <20240502144626.2716994-1-andriy.shevchenko@linux.intel.com>
	<20240502144626.2716994-4-andriy.shevchenko@linux.intel.com>
	<20240502111314.63d66b54@SWDEV2.connecttech.local>
	<ZjOxQWc1OtGWatKC@smile.fi.intel.com>
Organization: Connect Tech Inc.
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:V42GeMkZp+U=;g/7zFTFhk+E+9KwKYQBi1S+4mzp
 J5JD3EqF1HW234Ux9zR3huPG3BwknTMczlp8C5f3jVpoxLGuM5H7rjVWNubYzb1gk4YRGLOCo
 lfmgQmx3KiJXNhT0/EsIQVm5zuylrtMIS+cvQrWNPMMioIaDY20IyDwfDY6N3dx0nEeFRM9VQ
 wGdpkL1cxu0KLxf1Sbi5fjg2KRRZMEskBSkCuxYSGU2M0c/2mbN+Ss6T4BVPSk/aB1lpbk/2I
 dIRoOdvLSQVbTDTyIRG1Ivp/hfnuI6ZUWqrPZLKzk+2dL8nQwa/B+QHi8i966sRoHUHSCOG/J
 AJC8uZ68mbV+hqXXrhEsyVNtN5kfjMbmUhFOkSAESuPG3IiRpYvht3omMIWgGE5j7F41D+Fhc
 tjSdk0N4hjPaM2c7Q6tMfwDWKNj5prRzyC/U5qAO4GaQQOlNNHVpFJbZ6NDnF495RA6QBDGS4
 i4IOdO2ikylhHAWwgPUDZo76GbhZuu5pei6gVKJhms6WQeByJnrZjoURWLB7cYHsh6WFrNPZU
 RB9m9KVwtH5iUwjYC6k6gGuD47HClLy+wNp74MLxw9MjlodiyM9DI7Ep5o9MFqb35WMOmkeP1
 NUwXh8qzQopgGzcI3DwdLGIuWcVj02XJ159v7ArpB3R7SUJcTGEmZ7y6EA5e0bbIhQR0hPIEv
 Ads0xAhD+lZQ7xPcStyD+NhQUtYU3B6euvp4wEL9ocef6VYRMcVrphYdJ19popiOQNjPe3tNX
 N5aCdnqik9Co9BqXlhUA0B89oz31U6mSq+rS6QQ+2OPAk8Fx4W8JJc=

On Thu, 2 May 2024 18:29:05 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> On Thu, May 02, 2024 at 11:13:14AM -0400, Parker Newman wrote:
> > On Thu,  2 May 2024 17:43:57 +0300
> > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
> > > The CTI_PCI_DEVICE() duplicates EXAR_DEVICE(). Kill the former.
>
> ...
>
> > > -// For Connect Tech cards with Connect Tech vendor/device PCI IDs (=
FPGA based)
> > > -#define CTI_PCI_DEVICE(devid, bd) {                     \
> > > -	PCI_DEVICE_SUB(                                 \
> > > -		PCI_VENDOR_ID_CONNECT_TECH,             \
> > > -		PCI_DEVICE_ID_CONNECT_TECH_PCI_##devid, \
>
>
> #define PCI_DEVICE_SUB(vend, dev, subvend, subdev) \
>         .vendor =3D (vend), .device =3D (dev), \
>         .subvendor =3D (subvend), .subdevice =3D (subdev)
>
> #define PCI_DEVICE_DATA(vend, dev, data) \
>         .vendor =3D PCI_VENDOR_ID_##vend, .device =3D PCI_DEVICE_ID_##ve=
nd##_##dev, \
>         .subvendor =3D PCI_ANY_ID, .subdevice =3D PCI_ANY_ID, 0, 0, \
>         .driver_data =3D (kernel_ulong_t)(data)
>
>
> > > -		PCI_ANY_ID,                             \
> > > -		PCI_ANY_ID), 0, 0,                      \
> > > -		(kernel_ulong_t)&bd                     \
> > > -	}
> > > -
> > >  #define EXAR_DEVICE(vend, devid, bd) { PCI_DEVICE_DATA(vend, devid,=
 &bd) }
>
> > This is not correct. The CTI_PCI_DEVICE() macro is for cards that have=
 the
> > Connect Tech PCI Vendor ID (not Sub-Vendor ID). EXAR_DEVICE() is for c=
ards with
> > Exar PCI Vendor ID.
>
> Above I added current code of these macros, can you elaborate how it's i=
ncorrect?
>

Sorry, you are correct. I was mixed up.
Thanks,
Parker