Received-SPF: pass (google.com: domain of linux-kernel+bounces-166661-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 2 May 2024 11:46:45 -0400
From: Parker Newman <parker@finest.io>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Parker Newman <pnewman@connecttech.com>, linux-kernel@vger.kernel.org,
 linux-serial@vger.kernel.org, Greg Kroah-Hartman
 <gregkh@linuxfoundation.org>, Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH v1 00/13] serial: 8250_exar: Clean up the driver
Message-ID: <20240502114645.4445b3da@SWDEV2.connecttech.local>
In-Reply-To: <20240502144626.2716994-1-andriy.shevchenko@linux.intel.com>
References: <20240502144626.2716994-1-andriy.shevchenko@linux.intel.com>
Organization: Connect Tech Inc.
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:hUf6SGK8ArE=;8MKunMbe28rzhoUqEhj7QoMoIdz
 sPM/AB57bT1OVXl/N+rx7/BpwPwapdXs03aYt6He3Vmqxcrdff6+EMqz0cxnYWp0d6fVgDIxq
 P9NdJ37dCL3jGyTaeP7XTa5C174vkwFKdmowc1BoNKkSoBQNUk1ti766qIM6+kHTIprbhrIWT
 rc7nFrKodGBpH6hMWq7/aNKfN8I+ZPAU6adHXQdOUCabmh2QNuI+PFC/D/WGJoESiaeFuTzkO
 wDtZq4ocnp70mGKzenVJO7XB/W/4X9Fw3GK+K7tNNSUSamBq4bmNWWOs8fXDU7eNVH1NTuGRO
 VrfNKsbr6NiVL6W69VGrt7cqFfusL/0a+wMq/2PYGj/cVFH1YoG95t1qpyEVUk/DA+13Z4ctr
 d0fBP6/gZE2W4ppBf8iuPIzwbJ2JaaWD7s8eKYgUFZaDarQ8LPcpWSI9wZIJemgTMKq/BPoju
 CeMjAubs3H02sqy9StRTRuCvVgPHBAGieekky8djzX8zIc3mqRUzEjqNTWMfxjnNqhR60VGhH
 2VNMCg5tsiY8gpak5pbexkQOgaYveAeEvhdzL+36I9y0jayh3zw9UD6XQY6UAJdPICciMV22Y
 qB22ii00stbLeyAtfN0miN5CJN1C7J71ZRliKPHHkhf3su0/YVxUFjT/RsQTSEZWgNiigVvJN
 CkRQLW9RqLPbv4kKZLmNLddO8M17+VS8mUby3SwSoswIUACywHNNHGnTiA/2plkWc/67Bvbo/
 8xQvPUpb3NfOQZffMyL9TlmZgCfqZ58IS0iAaROyAMmx8vo/1EfcTE=

On Thu,  2 May 2024 17:43:54 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> After a rework for CONNTECH was done, the driver may need a bit of
> love in order to become less verbose (in terms of indentation and
> code duplication) and hence easier to read.
>
> This clean up series fixes a couple of (not so critical) issues and
> cleans up the recently added code. No functional change indented by
> the cleaning up part.
>

Just an FYI I submitted a patch series that fixed several of these issues =
but I
think it fell through the cracks (I know everyone is very busy!).

Link: https://lore.kernel.org/linux-serial/cover.1713533298.git.pnewman@co=
nnecttech.com/

I believe my previous patch series is no longer required. This one fixes
everything.

Thanks,
Parker

> Andy Shevchenko (13):
>   serial: 8250_exar: Don't return positive values as error codes
>   serial: 8250_exar: Describe all parameters in kernel doc
>   serial: 8250_exar: Kill CTI_PCI_DEVICE()
>   serial: 8250_exar: Use PCI_SUBVENDOR_ID_IBM for subvendor ID
>   serial: 8250_exar: Trivia typo fixes
>   serial: 8250_exar: Extract cti_board_init_osc_freq() helper
>   serial: 8250_exar: Kill unneeded ->board_init()
>   serial: 8250_exar: Decrease indentation level
>   serial: 8250_exar: Return directly from switch-cases
>   serial: 8250_exar: Switch to use dev_err_probe()
>   serial: 8250_exar: Use BIT() in exar_ee_read()
>   serial: 8250_exar: Make type of bit the same in exar_ee_*_bit()
>   serial: 8250_exar: Keep the includes sorted
>
>  drivers/tty/serial/8250/8250_exar.c | 454 ++++++++++++----------------
>  1 file changed, 200 insertions(+), 254 deletions(-)
>