Received: by 2002:ab2:60d1:0:b0:1f7:5705:b850 with SMTP id i17csp1265058lqm; Thu, 2 May 2024 09:29:55 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX8pyTblDN1YVS29hUUds5a4QU5nP5HnfJizU9fCtVI7MSlItelGHB6cX6Aqye01rQXPYC3yiovJNxx3SES+lJ8aHUG1rqLUUs2FGd77A== X-Google-Smtp-Source: AGHT+IH3hidWr9ssEAjKfCYio/QYFGd4zB2NLYlslwb/a5w0b8k8QuLeIfSk51ht18GUENkw4Qu2 X-Received: by 2002:a17:902:f792:b0:1eb:5403:b16 with SMTP id q18-20020a170902f79200b001eb54030b16mr293979pln.0.1714667395583; Thu, 02 May 2024 09:29:55 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714667395; cv=pass; d=google.com; s=arc-20160816; b=OuoZleVx3LgQGuvt76McoGhUNtpBg/cEhW0Kq9zn16he29Rz2kT3BhQ7DWQgtmXlL1 orxLxO/+8rvniv3pPJ1bhzjFa1nbose/USfLUA3gtmaG5hnuJ7AbWuahNpTgHxVun0zG I6BPV4SpCQTjuAYoMUZt3r4jV0mOgIffHtobBX0qGLsOqI7t5QwNeH2JcM5AwxdFJwN8 uJ+SXNBraa+grao10Y6zE8Tvp2AkWHTRY475dJlaQuXz/yml2MTQnPGUc25Mh2GGE/Tg 1ckfrgw7iXT/YFycXS/teyqGHJFnJnC6j/Aj4GvlZW2KiOou7+aNSSgnw/W/1g79wa7N WdKg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=UwDUPv1AAiOUKvX7zgTI/sErI7DdPWlG5HR407q++NM=; fh=Ame3tepqjzbMuLyAkh9r6SpDd15oysnnuRyrkjoSI+8=; b=gnmRK+9MaXao97jg1nBcBUOJqRdz/ZEKnb9ixNbsHVNYdiyhzdl6aqHnRqxFENsp5Q gOgILjQAVAu9splBNQMYo1gIYs0cnyb8ex2ew1NEKxvZVJKuTntiEHUER74Oy5gM2YPM 4sOz/SneFUg2L5pOEjfwcvDVuZLXFuKWlJFL2Ah6Ar7lFD+2YhuCCgYw/um/jF02UTJe vtWrgFtUpYSK0b2rg8VwRmBWfFJaoYIvFxA7HvCvfukFz6bDRwxL/wJay0FYZiMCJBOm Z3QDicfi5P8qwCffgp+RC94jLnxqTiDqP0bqECHpy3aKnHko2024FXhgdhAGfAy84ZQn s3WA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VQ+4jtcF; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-166706-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-166706-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id m2-20020a170902f64200b001ebe5c06450si1311978plg.247.2024.05.02.09.29.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 May 2024 09:29:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-166706-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VQ+4jtcF; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-166706-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-166706-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 560C8289ED8 for ; Thu, 2 May 2024 16:20:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8EFF315E5C2; Thu, 2 May 2024 16:20:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VQ+4jtcF" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4ED715AAC5; Thu, 2 May 2024 16:20:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714666800; cv=none; b=hHaX/oZxX86+RwK4K1JJQ0cKLpvQBPOTx28OP0KaduBHPx3px69uZd/lgCMq9Qfws2AYTIovA5oC0TM9ksSpgwqw/w6zUCWjijYOPVFiB46BQ5eN4yqOFbdij+n3/+vNmVeOR0/UFPx2vp2ILQx83EqDXbcEnZZ/+28iKvluBKc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714666800; c=relaxed/simple; bh=wthRQDYG9peyYfbmJkk/3Lt0EmD/2SFlNx2py7XS71Q=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=BqKtcNFcklkl47YzX9C497fHdmyYhfwzikAXad4EITnwi1dCxdDZhisN+4FWK0NmPCVbSPgXAqS+qMEFAd0hYNqBFLNzFe5Xj/BMTcWNQNpCzaJFt6NefNX3/T7Ye1FHjBZ/SW8eB3xOWV99I9x5iGu2K8ZBgvHVNOOgLa1vJW0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VQ+4jtcF; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63C8EC113CC; Thu, 2 May 2024 16:19:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714666800; bh=wthRQDYG9peyYfbmJkk/3Lt0EmD/2SFlNx2py7XS71Q=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=VQ+4jtcFuH6z70kyMbC3fUfPjAapVbzS/iBsYj7VzhbjGFZjxvlImPgz0yBo4StJL jYDpiE7cKNeG8bbyjAa7j6waclBpLHuLXXqFF3beZcLQ1iTGEq8Na+F10CciZArcMK htUhwsUK4UK7ghci0ppsy/pHozhxGHZGHVjhpJjZLLihmrj2sP1J80Yd4umnK4KCeP Qg7toH+c4tz792EiaZnEfXGfDpaVD5xnrVSPrtyX9fxLEm2HTf3F2Yf+zm4DDMGstt DXUwlNFhGnBSUGQjaaGLDPGal+eTKdE8w+mmr86DNe/c8U0pgqAY346i8o6H6UihT8 Cvxk1Mu6YfFaQ== From: Lee Jones To: Lee Jones , Colin Ian King Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20240415102632.484411-1-colin.i.king@gmail.com> References: <20240415102632.484411-1-colin.i.king@gmail.com> Subject: Re: (subset) [PATCH][next] mfd: timberdale: remove redundant assignment to variable err Message-Id: <171466679912.1192680.16107294908184867521.b4-ty@kernel.org> Date: Thu, 02 May 2024 17:19:59 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.12.4 On Mon, 15 Apr 2024 11:26:32 +0100, Colin Ian King wrote: > The variable err is being assigned -ENODEV and then err is being > re-assigned the same error value via the error exit label err_mfd. > The assignment is redundant and can be removed. > > Cleans up clang scan build warning: > drivers/mfd/timberdale.c:768:3: warning: Value stored to 'err' is > never read [deadcode.DeadStores] > > [...] Applied, thanks! [1/1] mfd: timberdale: remove redundant assignment to variable err commit: 3f2706adbc2b8b6aaf313cc66271642d901d90e0 -- Lee Jones [李琼斯]