Received-SPF: pass (google.com: domain of linux-kernel+bounces-166742-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <00a0aa99-b33e-b3a4-594d-36685d138a05@axentia.se>
Date: Thu, 2 May 2024 18:43:01 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: Supporting a Device with Switchable Current/Voltage Measurement
Content-Language: sv-SE
To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Cc: =?UTF-8?Q?Jo=c3=a3o_Paulo_Gon=c3=a7alves?=
 <jpaulo.silvagoncalves@gmail.com>, linux-iio@vger.kernel.org,
 linux-kernel@vger.kernel.org, joao.goncalves@toradex.com
References: <20240501233853.32y4ev7jvas5ahdz@joaog-nb>
 <20240502133623.0000463e@Huawei.com>
 <44f47927-52aa-5248-6ae4-21028076fd51@axentia.se>
 <ad190ae3-48d2-a5db-dd36-d52b1c4cf460@axentia.se>
 <20240502160938.00007691@Huawei.com>
From: Peter Rosin <peda@axentia.se>
In-Reply-To: <20240502160938.00007691@Huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Rmh4citjcXIvdkVyRGpuZHh5U2VtSG1LY3VlRFlHUW9Vbmp2RStZR0ZGKyth?=
 =?utf-8?B?NE5NOTY0T2JCZTh6UytIQStVYW01ODNVVmkyUDJBOEt2TVlvTEtUVmU0V1R4?=
 =?utf-8?B?NVlRSFFCcHBPOXFxeTQxdmhMak8wMDlBOE5IcG1uaHQzRkFoS052ZlpqdnBT?=
 =?utf-8?B?SlVXMmNHNWk2UE0xb3FOTXNGdTMybTBzVHpJQjg5MHBzcTR2YlhXc242a1Rp?=
 =?utf-8?B?MFFnZlZMSWI4UDRRZzhIcXFYdUJlR0FmRW9tbVUzT2MyNkttbEJ4SWdBZjhJ?=
 =?utf-8?B?SWYxSTR0MnZzNWdIR3oreXZVaUUralBxTUVSRFhvUm1rc0QwMmE3WVk1OEhi?=
 =?utf-8?B?MEFqbzJKTzRxY0liSVJ0Y0FLeFNWem1uN1NoNjhsTHMwVm5FeDBMbCtCbnFs?=
 =?utf-8?B?Y09veUdlTjNhbHIrMVJDUXk5OTVoQWhTdUlmU2J6eU9xS3dCTlBid1k2Ukxv?=
 =?utf-8?B?TWJLSmpYZEtkVzQzZWpBRnFmZEdrWFBpQ1Nvd0NldWtqRXNPbXBld2pJNXZI?=
 =?utf-8?B?ajhNeE12cEEvZ1VHQit3OG5jRGVWaGIvRlhSR0N2cFRuR3ArRFFyaE02aGp5?=
 =?utf-8?B?VVA3MGtnWjZKQkE5a0xSNmtMQkE0UDRhZHVnN3VvUVhJR3Y1c1Y2Uzk5dkNR?=
 =?utf-8?B?UDhJZlgwaUpuSVE1Y0VkaFFqUk1lWUJDQVRvOFpCYW14K1A4cUtTVEVIRzBp?=
 =?utf-8?B?V0h5ZlZPQXNqN0w2QVNKTHU0aG5reGUzbElJK0NRMzBUaTU3UXlkbzVGTjZZ?=
 =?utf-8?B?dWUrbVZjdzZ5NE9kT0NkRjBPYWY1azRmbmJpZWFpeVBpUlJvZW9XdmVxUUVq?=
 =?utf-8?B?MmpnRC96eEhCSzczVmdrQXZZd0ZyM1JlNnQyZE4rLyt3a0hWbG5nM1IvL0Ro?=
 =?utf-8?B?bTNGSHhTQy9QUHNReDFxdGMwcjNtRFBYcTBWalhZNGZITWFoRnZBaVp2cWYx?=
 =?utf-8?B?d3dZb3o1VlkxckQyVG9TOHMzNnRNKzRKU3NxUmJsZTVsVFNDTzdmNlp5Q0J5?=
 =?utf-8?B?UjluTHdWSWRqankzNUVLR1o4bWphMWtFaU53cjhJcmhIalkrdERncFZJbGRy?=
 =?utf-8?B?WnVnTFdvYzdwaEg4QTc4VUlYZXpmbGU3NENSb0hQb2c0WlNSVk0xT3k4SUE1?=
 =?utf-8?B?UFVEZ2ppWkhBVytSY3Z6b25Ednp3cE1xZGNJaGk3MFViVVZ0WUxYTkVqM09q?=
 =?utf-8?B?d01jTzZTc2JibzF0UDcxaTFCMTF6VHErOWtNdUZvSFFlM3JGNmtnbnpQK0ZD?=
 =?utf-8?B?L0kxU0cvVjJTZ0dXVjE2UE1BSEdvaGx5R1pJdDQxeit4cmovc09LZU9kZWpR?=
 =?utf-8?B?Mk9ISWh3cXI4QTcxbWUzQzEzWjF3ODk2NjR1dlgxdENFOWtXQ3NXN1FQRWNR?=
 =?utf-8?B?N3RJSGViNUJENklWTXJCM0pWcS94eis4VXlEOTBmcHppbDlGWVpweUx5VG5X?=
 =?utf-8?B?RzBTM1BIR0FXcUI5S0hSd0MxVUtGcU5FbExQd3pDMElTakkxUFN0Q2FxU3V1?=
 =?utf-8?B?cnJvbnJmRmhqazVzM1hreEcvU1FqRXVXS001M1Vrc2RRalY4aXVQTmc3T1Rs?=
 =?utf-8?B?Zml5S2dtbi9KbW9ocEZnY2cxTDZwSkR4Ymo5bXFONlZjU1NCZmZjY2d1YkRW?=
 =?utf-8?B?enpBeVh3YVFSVmFhSno5eVJMT3Uzay9QMkdndHJIQnJnT3N1cCtCOCtqb3hL?=
 =?utf-8?B?ZHZwaTQyQno4bFBlZUd3UGVONmIvWERjSHRMbkNrcnNIMTB3QzJJRnZvQkwr?=
 =?utf-8?B?SlJvWklTVFAzU084NWFwRlJpais4bmtmNXp0OUo0OThjYnlWV0RiYkdhb1JM?=
 =?utf-8?B?RnprbDdrN0Z3WnAwdVBNVUxyWW9USzZ5NGpPNy92MHh0Z1RVSjNydzdkTUlE?=
 =?utf-8?B?bWovR24wVXRDdFJlVnFNOGdnM3BHTExqd0RicSs2QjZMNlRLaDBXcUNjQU5V?=
 =?utf-8?B?WjZ3bFlUSzgwY0RNSUQ3MEduWFUvVVEvVFdZMmpIOVJRSU9NYTFrRFI4enA5?=
 =?utf-8?B?Tkl1aERETGRHZTRZWWJQRlZIZ05WYno4UFJ1QzR3Q1pTNitjUUIvTWpXVGhC?=
 =?utf-8?B?aDFvMmZSbzlDNzllTzNQS2JpcmNMdUNzVGRIUlNIZmJSVG9QRXorUEtvL1hC?=
 =?utf-8?Q?6rXOxeEdqGcFFrZs6ucZXaGVX?=
X-OriginatorOrg: axentia.se
X-MS-Exchange-CrossTenant-Network-Message-Id: 3c25bf5c-eb7b-448a-95d1-08dc6ac6ef62
X-MS-Exchange-CrossTenant-AuthSource: DU0PR02MB8500.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2024 16:43:03.3702
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3e0B9DO0ewCz0y03acx47Guf04t5Y8QRTUy49NOdn+8ylwhEG/gySfed43w4XjSG
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR02MB10051


2024-05-02 at 17:09, Jonathan Cameron wrote:
> On Thu, 2 May 2024 16:05:45 +0200
> Peter Rosin <peda@axentia.se> wrote:
> 
>> 2024-05-02 at 15:49, Peter Rosin wrote:
>>> Since you appear to need to change both the gpio pin and the io-channel, the
>>> mux isn't a perfect fit. The closest you can get with the current code is to
>>> create a gpio mux, I think. You would then use that mux twice to fan out both
>>> io-channels, but only expose the "left leg" on the first fan-out and only the
>>> "right leg" on the other. Something like this (untested, probably riddled with
>>> errors, use salt etc etc):
>>>
>>> rcs: raw-current-sense {
>>> 	compatible = "current-sense-shunt";
>>> 	io-channels = <&adc 0>;
>>> 	io-channel-name = "raw-current";
>>> 	#io-channel-cells = <1>;
>>>
>>> 	shunt-resistor-micro-ohms = <3300000>;
>>> };
>>>
>>> rvs: raw-voltage-sense {
>>> 	compatible = "voltage-divider";
>>> 	io-channels = <&adc 1>;
>>> 	io-channel-name = "raw-voltage";
>>> 	#io-channel-cells = <1>;
>>>
>>> 	output-ohms = <22>;
>>> 	full-ohms = <222>;
>>> };
>>>
>>> mux: gpio-mux {
>>> 	compatible = "gpio-mux";
>>> 	#mux-control-cells = <0>;
>>>
>>> 	gpios-mux = <&main_gpio0 29 GPIO_ACTIVE_HIGH>;
>>> };
>>>
>>> current-sense {
>>> 	compatible = "io-channel-mux";
>>> 	io-channels = <&rcs 0>;
>>> 	io-channel-names = "parent";
>>>
>>> 	mux-controls = <&mux>;
>>>
>>> 	channels = "current", "";
>>> };
>>>
>>> voltage-sense {
>>> 	compatible = "io-channel-mux";
>>> 	io-channels = <&rvs 0>;
>>> 	io-channel-names = "parent";
>>>
>>> 	mux-controls = <&mux>;
>>>
>>> 	channels = "", "voltage";
>>> };
>>>
>>> What the mux solves is exclusion, so that the gpio pin is locked while
>>> measurement is made on either current-sense or voltage-sense.
>>>
>>> However, the channels from the raw-{current,voltage}-sense nodes are exposed
>>> to user space, and it will be possible to make "raw" measurements without
>>> regard to how the gpio pin is set. That will of course not yield the desired
>>> results, but is also a user error and might not be a big problem?  
>>
>> I just realized that it's also possible to do this "the other way around". Maybe
>> that makes more sense?
> Ah, I'd failed to realize that this is about routing a single wire
> through two different analog circuits that end on 'different' ADC inputs.
> 
> Pictures would help me out btw!  Everyone loves ascii art.

Certainly! :-)

> Anyhow, I 'think' what you have here should work.

Also, on ordinary multimeters it is quite easy to blow the fuse for the current
loop. Assuming that measuring current is more sensitive, the following addition
might be in order?

@mux {
	idle-state = 1;
};

Cheers,
Peter