Received: by 2002:ab2:60d1:0:b0:1f7:5705:b850 with SMTP id i17csp1302381lqm; Thu, 2 May 2024 10:27:41 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV/CCAvoybui5Q3YYNgKYPkpKhQYCP/dKAux8YpWrv8qhM++mn3oDDFA8Xu/6Vs3bZDHzCmr4J5iVWdOsYVk63T/tNpDXe9WUuNOjl3HQ== X-Google-Smtp-Source: AGHT+IF/ntnC7yOrHiCmrgsFvS5wAv0Hm7AAcRPDrw1RhElaIzrH616u1q7N4R/vB4bv9Uig5PxH X-Received: by 2002:a17:906:c40a:b0:a55:a072:1ab6 with SMTP id u10-20020a170906c40a00b00a55a0721ab6mr94226ejz.52.1714670861803; Thu, 02 May 2024 10:27:41 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714670861; cv=pass; d=google.com; s=arc-20160816; b=xzvzODVOiQvVbJvXXdwUNih2mYHJLi4lRgSiVystE2CIrhmWk8m7KPDgi4C1GQoeUF dmZJ2nDltTiCuzopCOvpONYGf9qiBG+5fPRduoGvMcxqWZIwbQ/4btdyWxHkk4IVml1h HTJtGxY4BBopfDaRhT3E0phLuZCShLMYxYHMN/UfQMAX+8CTfqbh7vSnxFlmTSYve3/j 7M2f/J6Sk9AMZSZDGnBdMU7LbCa45zDj3QA//Lt8noPlWwYR1eu7fjfTXC0xW+xHw+Az dfAUdqF/umCp+NJ1kr7eJrgQffBxwdhPoFPWSGj1IB0gaYBYkS4O1CVLXzXB3MzFctU9 ZshA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=w5N+1O1RnpvgtwkjnCfluiLG1wbCmelyiHr/+borMNI=; fh=9H4z7/o7y4OLn0xLmjdSk9Pth53+ED/R+iGnGlnIr7g=; b=RDlCLvjFmktVmvaP2IkiEQbuKIqameet8z6CcedQeOB6N2ooodih8nBmyN2dTnyKID MX97GPhxGBGEB1PjdCDRJ/fY/1N4iYegrXg2mxNbBVbpSwdNLYk6iCE6Sb6e58uPMFNq 0PDXupg4gR123YByGBhJmJX4giUDzk5ONQgKZCGzJlnjRA97wyPUqDTWQvzO7LkZtc7I SfhdWHLTcxeUNnp0LNIerhP3Jj4ZrRUpLrcSiDrTzPD0PS9hI1tuiG5laXk+pZBIpBTQ T7VB3jcVpFCz81hC1v0lVA20IV2qfrltnxvXauhSG8dE3g1mDhkhhs7GGeAkI5NWT3h5 9v0Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=emslM5hH; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-166785-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-166785-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id hq42-20020a1709073f2a00b00a55b58c1428si715163ejc.758.2024.05.02.10.27.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 May 2024 10:27:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-166785-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=emslM5hH; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-166785-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-166785-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 5D91D1F22A72 for ; Thu, 2 May 2024 17:27:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6D52C171065; Thu, 2 May 2024 17:27:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="emslM5hH" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85F8816FF4A; Thu, 2 May 2024 17:27:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714670848; cv=none; b=pHfQeWx2tpJ8EYmEugKis1Y7I8GUdnlM3xVFwMj/AwYJoZrGtaS7ecFJrNQx0qrVtL06+Yy5v3Z/AdmIFr5/dAqoBcO6gdTsySDD+NuIA7BUd/lQ+KGReEBkafAe9pumHTHnxGMSpX4gm2QueVyFVM2maGVqxRyi7Upxw8bSW4A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714670848; c=relaxed/simple; bh=I63TfrbmSoQUarN68hoe/QgcSHNL3XEpjAZInckdvxY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=J4dtsrYVrGxAOeWELjWEUJVYisdeEMu9PO1uMIWUzjpD/WCzue+sZLFEKBq6RFYdmIjW/az/3j0QEv3OyERwQoGBe8Y2h01CYzOa6skzJ2zDbfLK8X8ZubtZYaeB+yPx+kGuyKgDAqqDMTAhrmu6Y0JHCw05mHEqyHPnUvX1QnM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=emslM5hH; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id D968FC116B1; Thu, 2 May 2024 17:27:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714670848; bh=I63TfrbmSoQUarN68hoe/QgcSHNL3XEpjAZInckdvxY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=emslM5hHuculQgVIbvMTNrFTk3RZwSIu8woc1S4l3D/94fuVqnsBkJskI7EjqgWLe nkqk5Lvp5XtUQz4fCj4sY9TesHcQHaXUHNk3/iWeSPhXYfcqNoDvPppp5m1ZbSP4tK RfH5dADAd16/4hgmBvnFlmhsKW+oMVvcNvCbmonxzF3/0LtkHyciHHQ97ZLDLQRP+z CQa0Q9FFYoV87VTLt0yZQSne+eizUoT7nMHcXbUeIIMeOByFQqQVjJTrkAX+sAIY+0 uyBWbxpGRlZhRSZ7OnqdZfF0QbMbLgV50lkih2A2xhxJekKKUl95GTcHPiM1GCgrmx SM/KNBRqSUw9w== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , Shuah Khan , damon@lists.linux.dev, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] selftests/damon/_damon_sysfs: support quota goals Date: Thu, 2 May 2024 10:27:17 -0700 Message-Id: <20240502172718.74166-2-sj@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240502172718.74166-1-sj@kernel.org> References: <20240502172718.74166-1-sj@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The DAMON sysfs test purpose wrapper, _damon_sysfs.py, is not supporting quota goals. Implement the support for testing the feature. The test will be implemented and added by the following commit. Signed-off-by: SeongJae Park --- tools/testing/selftests/damon/_damon_sysfs.py | 84 ++++++++++++++++++- 1 file changed, 83 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/damon/_damon_sysfs.py b/tools/testing/selftests/damon/_damon_sysfs.py index d23d7398a27a..f80fdcef507c 100644 --- a/tools/testing/selftests/damon/_damon_sysfs.py +++ b/tools/testing/selftests/damon/_damon_sysfs.py @@ -70,16 +70,56 @@ class DamosAccessPattern: if err != None: return err +qgoal_metric_user_input = 'user_input' +qgoal_metric_some_mem_psi_us = 'some_mem_psi_us' +qgoal_metrics = [qgoal_metric_user_input, qgoal_metric_some_mem_psi_us] + +class DamosQuotaGoal: + metric = None + target_value = None + current_value = None + effective_bytes = None + quota = None # owner quota + idx = None + + def __init__(self, metric, target_value=10000, current_value=0): + self.metric = metric + self.target_value = target_value + self.current_value = current_value + + def sysfs_dir(self): + return os.path.join(self.quota.sysfs_dir(), 'goals', '%d' % self.idx) + + def stage(self): + err = write_file(os.path.join(self.sysfs_dir(), 'target_metric'), + self.metric) + if err is not None: + return err + err = write_file(os.path.join(self.sysfs_dir(), 'target_value'), + self.target_value) + if err is not None: + return err + err = write_file(os.path.join(self.sysfs_dir(), 'current_value'), + self.current_value) + if err is not None: + return err + return None + class DamosQuota: sz = None # size quota, in bytes ms = None # time quota + goals = None # quota goals reset_interval_ms = None # quota reset interval scheme = None # owner scheme - def __init__(self, sz=0, ms=0, reset_interval_ms=0): + def __init__(self, sz=0, ms=0, goals=None, reset_interval_ms=0): self.sz = sz self.ms = ms self.reset_interval_ms = reset_interval_ms + self.goals = goals if goals is not None else [] + for idx, goal in enumerate(self.goals): + goal.idx = idx + goal.quota = self def sysfs_dir(self): return os.path.join(self.scheme.sysfs_dir(), 'quotas') @@ -96,6 +136,20 @@ class DamosQuota: if err != None: return err + nr_goals_file = os.path.join(self.sysfs_dir(), 'goals', 'nr_goals') + content, err = read_file(nr_goals_file) + if err is not None: + return err + if int(content) != len(self.goals): + err = write_file(nr_goals_file, len(self.goals)) + if err is not None: + return err + for goal in self.goals: + err = goal.stage() + if err is not None: + return err + return None + class DamosStats: nr_tried = None sz_tried = None @@ -361,6 +415,34 @@ class Kdamond: stat_values.append(int(content)) scheme.stats = DamosStats(*stat_values) + def update_schemes_effective_quotas(self): + err = write_file(os.path.join(self.sysfs_dir(), 'state'), + 'update_schemes_effective_quotas') + if err is not None: + return err + for context in self.contexts: + for scheme in context.schemes: + for goal in scheme.quota.goals: + content, err = read_file( + os.path.join(scheme.quota.sysfs_dir(), + 'effective_bytes')) + if err is not None: + return err + goal.effective_bytes = int(content) + return None + + def commit_schemes_quota_goals(self): + for context in self.contexts: + for scheme in context.schemes: + for goal in scheme.quota.goals: + err = goal.stage() + if err is not None: + print('commit_schemes_quota_goals failed stagign: %s'% + err) + exit(1) + return write_file(os.path.join(self.sysfs_dir(), 'state'), + 'commit_schemes_quota_goals') + class Kdamonds: kdamonds = [] -- 2.39.2