Received-SPF: pass (google.com: domain of linux-kernel+bounces-166817-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <6b5571e0-1463-4dd9-9bd8-459d456a6932@wolfvision.net>
Date: Thu, 2 May 2024 19:58:26 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] device property: introduce
 fwnode_for_each_child_node_scoped()
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Daniel Scally <djrscally@gmail.com>,
 Heikki Krogerus <heikki.krogerus@linux.intel.com>,
 Sakari Ailus <sakari.ailus@linux.intel.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 "Rafael J. Wysocki" <rafael@kernel.org>, linux-acpi@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20240502-fwnode_for_each_child_node_scoped-v1-1-868a2b168fa8@wolfvision.net>
 <ZjOybob3wJjisuBL@smile.fi.intel.com>
Content-Language: en-US, de-AT
From: Javier Carrasco <javier.carrasco@wolfvision.net>
In-Reply-To: <ZjOybob3wJjisuBL@smile.fi.intel.com>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UHFqaEtERW5hNGY1aXR4NUlMaGY0TXVkSjZEYTNOU2QxblZxOHJOMk1UdWsw?=
 =?utf-8?B?TCt5cnlMUW9SakRKWWpVK2NYRENBbTJ5WUdUVHd1T1RVY2JGcXd0TS8vUWRa?=
 =?utf-8?B?RExLZ3d5d1I0SW5xQkI5ck9MNmR2NTJjV05OSzMyU0QxakdUNXhudHpGcTZE?=
 =?utf-8?B?dTNvSjdIbHhuSnVZN1NXN0loRU1xNGhZeUlURHluVEVoM0pIa2tPR3FYUUM5?=
 =?utf-8?B?SXVuVldhTWthZmFmR3JBdXgwRzI3ZlJLZ1ptaE9YS1Y5bGVTTWt2dlNzVmpX?=
 =?utf-8?B?dUJSYW9MQU01akVsNnEvR1NacmUrNnhNRjN3Q0tSNGxjSm50czJlQ1lBOWlE?=
 =?utf-8?B?cHMyWVZBckt3c1VHRFdldWk4ZVhtYWcxSzBQaFFoZmhVSHcyTzlhTVc4RGRz?=
 =?utf-8?B?WXd5d1JmYW5pQmpHVUxtdmJGN2g2ZnlJU3VmTktqeGZjeGpTZzF2SlFRd2gw?=
 =?utf-8?B?RVgxNEhWSmlLQ0lPQ1ZZcFIyaFNlNXVmSXdRNzFnZnlwZjdidnpwc1k2b0JY?=
 =?utf-8?B?OG1kWHZ1S3BidmN2NjloOGtublNqczAvY1h2c2U0RGo3R3VZalpJbTJYS09k?=
 =?utf-8?B?NUV0U001em16QWZHNVJjVlhFdS9qWklUQ0hocE1jMTAxbkphTldPTXZicmNv?=
 =?utf-8?B?VjBnN0g5ZVMvdWMvbi94RGthQ29QU092NDErZXdKb2pSdTY1RnFDcVBicXBT?=
 =?utf-8?B?SVJydmZmd1Avd2xqYlFvT0xuZ2ZlTUoxN1ArTCs2UWlMaTFlUjAxZlhBem4r?=
 =?utf-8?B?ay9GSXBkT3l3VStCVS9xYlVmblFvT2Jwcmlnek9PZzdRUDZHTHJydGptaVRp?=
 =?utf-8?B?NTRFOUZFOEVSMEpJaVRBMGVGWS92N0JGcVNTR1hYNmE0dncwRjdQZWFXLzhG?=
 =?utf-8?B?allXYVdoSDhMemtPVFVrZytjSlc3K1I5eTFyMjc1Y3p5b1BKbEp4M0ZQTFR5?=
 =?utf-8?B?Y1RqdldTQ0R2Ujc1MldmTjg2OVNJU0ozbjdtODgwT0ozWVh5Z29WN1p4K2xm?=
 =?utf-8?B?bk1qTVF4TVAwUWhGRjhFa2hRYWRTcndxOTE1VVhDRitSeTlXV2tESGprVTJU?=
 =?utf-8?B?UlJYU3FLYVlFZUV2MkVXbzd0c0xnZ1dzcXJ4RUwwUDRzU0FoZ0c5QWRvLzE4?=
 =?utf-8?B?eDhTMFpPK2V3eXZWVlduc2tDR3djNmN5NGhzdTBmOUZTNkQ3VWppMW1ib1R6?=
 =?utf-8?B?ZUljN2ZKcXkvYUtCMGN5ajMvdDFvcExjNlp6WUQ5UjBGeVYyK2o4UnJVSVVk?=
 =?utf-8?B?RWdjRmZGb0dreEZaODZEM3B2M21wZkVNRGpXK0pTWGM4Q2pSZVlmRVdmeEpI?=
 =?utf-8?B?R1NwNDNWMm83T0RhSmUrd2REYmtwWHhnaXlrUTVRcHpoanB5UzBmVGlGTTZK?=
 =?utf-8?B?R3kwUnR0dVFXQnVhc1FKNnk0alFxcHp4djZucDZnVUpjSXpHOGwxTlRVTmNa?=
 =?utf-8?B?THVQc1hSei9BcjlIZWsvYk0wcnFtOW4yWlo5bjNadG50VXVYSjZsNk9zcFY1?=
 =?utf-8?B?M3hBRC95MFZ4RVN4dUpRWFJTK3M2NWZxditoejUwS0xjczVwbm5rT29ENXl0?=
 =?utf-8?B?dlkrMU1jSXd3NkwwUkRtMnR3OCtjejJaQ2ZyZ3NEcXR5Y1VveGY1aXVsWE5R?=
 =?utf-8?B?ekNkTHE2cGtqMzllV3pKZis5emVaOW5IUnNjKzU3bDVZK3hhdUxPMWVsay8r?=
 =?utf-8?B?dXA5UGw2OFFTUy9ndmQ3Z3VxM0N3YWJXaytScG8veDFubHFBVUVWdzlVRE1D?=
 =?utf-8?B?Ulo4NndHd1lBSkxId083Q3BSb1gwL211MWdtV3ZHZXM4VWtMTWFkcHJLbjRm?=
 =?utf-8?B?c09GY1hKb0ZHVlp1ZThGVmVRMnV5T3FPYlFMalp6cVpqK2RpMGJrOHlxMXE4?=
 =?utf-8?B?VzRsd2c3UFhqeDNZMmpDWHFlNkI3a2RtMkZSVktyT1A3aDQwb0EvVG0zSC9p?=
 =?utf-8?B?SzQ2bmprVDZHSmxSdzNNKzk0eElhbnZTU3BkVHY4RDBPM2RTVzY0NDAydWtJ?=
 =?utf-8?B?ZVMvTy9ueGZ4YVJIMzVnN0hQaXE5Y0EraTBiekpxOXhmaXRMNE43RXMvamtU?=
 =?utf-8?B?YlNlUTZ0UVdUNnBRd1BuSzJmS2hMZVlDYlM5ZnVmeFFCbS9EZVZ0RUVPS1ZX?=
 =?utf-8?B?Ylcya1RpMTEvc0JNY0ZYRDFBS2VKQmNxZ3NxNi9mcVFXOWxwMUJxbmpoYkE0?=
 =?utf-8?Q?eYQkXOMw2N1DehZXrzTSZVg=3D?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c66b761-6025-498d-c2cf-08dc6ad1868f
X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4974.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2024 17:58:51.9192
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iuwGOgW1pf/I5ZBN4skEG9/R41j0craoKSguBUQ+fd6UJozt9X/QjZGHq8wYrlR0OQcOUimeaGJV4pBoQp6tZXYlZdu5uxNj6wbcGYJ4S3o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8086

On 5/2/24 17:34, Andy Shevchenko wrote:
> On Thu, May 02, 2024 at 12:55:40PM +0200, Javier Carrasco wrote:
>> Add a scoped version of fwnode_for_each_child_node() following
>> the approach recently taken for other loops that handle child nodes like
>> for_each_child_of_node_scoped() or device_for_each_child_node_scoped(),
>> which are based on the __free() auto cleanup handler to remove the need
>> for fwnode_handle_put() on early loop exits.
> 
> Why not _available variant? I believe most of the code should use that.
> 

That is a good point. I just took a look at users of the _available
variant and at least the LTC2992 (which I can actually test) does not
call fwnode_handle_put() in one error path, so it could already profit
from a scoped version. I will send a new series with the _available
variant and a first use case for the LTC2992.

>> Signed-off-by: Javier Carrasco <javier.carrasco@wolfvision.net>
>> ---
>> This macro has been tested with a patch series that has not been
>> applied yet and is under discussion in input [1], which makes use of the
>> non-scoped version of the loop.
> 
> So, why should we apply a dead code?
> 

I will add this patch to the series I mentioned, so there is a first use
case. Even if the _available variant is preferred, the other one is more
widely used, and having a scoped version will allow for safer code.

>> Based on linux-next (next-20240502).
> 
> Use --base instead of this. Ah, and you do, so no need to have this comment.
> 

Ack.

>> Link: https://lore.kernel.org/linux-input/20240422-feature-ts_virtobj_patch-v9-0-acf118d12a8a@wolfvision.net/ [1]
> 

Thank you for the review and best regards,
Javier Carrasco