Received-SPF: pass (google.com: domain of linux-kernel+bounces-166820-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 2 May 2024 21:01:54 +0300
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Parker Newman <parker@finest.io>
Cc: Parker Newman <pnewman@connecttech.com>, linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH v1 00/13] serial: 8250_exar: Clean up the driver
Message-ID: <ZjPVEr7D0lEf86kQ@smile.fi.intel.com>
References: <20240502144626.2716994-1-andriy.shevchenko@linux.intel.com>
 <20240502114645.4445b3da@SWDEV2.connecttech.local>
 <ZjO4vYEBzxU3fpzC@smile.fi.intel.com>
 <20240502120840.02c65f30@SWDEV2.connecttech.local>
 <ZjPL5z7ah-Qkct6l@smile.fi.intel.com>
 <20240502134949.5e780635@SWDEV2.connecttech.local>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240502134949.5e780635@SWDEV2.connecttech.local>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Thu, May 02, 2024 at 01:49:49PM -0400, Parker Newman wrote:
> On Thu, 2 May 2024 20:22:47 +0300
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > On Thu, May 02, 2024 at 12:08:40PM -0400, Parker Newman wrote:
> > > On Thu, 2 May 2024 19:01:01 +0300
> > > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > > > On Thu, May 02, 2024 at 11:46:45AM -0400, Parker Newman wrote:
> > > > > On Thu,  2 May 2024 17:43:54 +0300
> > > > > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > > > >
> > > > > > After a rework for CONNTECH was done, the driver may need a bit of
> > > > > > love in order to become less verbose (in terms of indentation and
> > > > > > code duplication) and hence easier to read.
> > > > > >
> > > > > > This clean up series fixes a couple of (not so critical) issues and
> > > > > > cleans up the recently added code. No functional change indented by
> > > > > > the cleaning up part.
> > > > >
> > > > > Just an FYI I submitted a patch series that fixed several of these issues but I
> > > > > think it fell through the cracks (I know everyone is very busy!).
> > > > >
> > > > > Link: https://lore.kernel.org/linux-serial/cover.1713533298.git.pnewman@connecttech.com/
> > > > >
> > > > > I believe my previous patch series is no longer required. This one fixes
> > > > > everything.
> > > >
> > > > I haven't noticed that, if it contains duplicated patches, I may replace mine
> > > > with yours if you insist.
> > > >
> > > > In any case it's better to reply there that you prefer this series to be
> > > > applied, so Greg will not pick it up.
> > > >
> > >
> > > I do not have a preference. I am fine with using yours if it is easier on
> > > the maintainers.
> >
> > Up to you, there is no issue to take your patches in case they are the same
> > (or quite similar) as mine. I can pick them up, just tell me if you want this
> > to happen with a list of the patches (as mail Message-Id).
> 
> Just use yours.

Okay, thanks!

If you are going to test, better to pay attention to the BIT() conversion patch
as Ilpo noted an issue. I believe it's easy to drop (via local git-rebase run)
or move and test separately.

-- 
With Best Regards,
Andy Shevchenko