Received: by 2002:ab2:60d1:0:b0:1f7:5705:b850 with SMTP id i17csp1323596lqm; Thu, 2 May 2024 11:05:00 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWK4p5Yux5m9oVDe3r3+L0kQGF9UCH9kG4EpNsQuWCxaQ3LN/9qt/Dy71gvtP8440ZVyj88g7+DZTO0L4l2P843IChtjGvQVhZhe75Qbg== X-Google-Smtp-Source: AGHT+IHORgaGAhWo7+LRsZW6Jq9Tj12Z7+RAraTboaE4HeKhOBHRfS3Q6bHP/0DdqinyZcWCJMbv X-Received: by 2002:a17:902:cf07:b0:1e4:7adf:b85d with SMTP id i7-20020a170902cf0700b001e47adfb85dmr546159plg.17.1714673100596; Thu, 02 May 2024 11:05:00 -0700 (PDT) Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id k2-20020a170902d58200b001eb3ea8e583si1460676plh.5.2024.05.02.11.04.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 May 2024 11:05:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-166822-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b=QqYTELYs; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-166822-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-166822-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 8CD71B23EF2 for ; Thu, 2 May 2024 18:04:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 30407171E4D; Thu, 2 May 2024 18:04:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel.com header.i=@intel.com header.b="QqYTELYs" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E59EA1553BB; Thu, 2 May 2024 18:04:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714673083; cv=none; b=mmk6wHtEIZ67cmTs4L8QcicmHbLYxjSWnr586eluPkiRtSWqoEgTx4ogGmmIUjSxoXHmh13s4vPu+P+GkXgaEl52cw2yuQckCaVSwyzBU66viNd7xTB6gWrhBgVmdwwDJvMooaRzZjVIm43nUJWiDxaDYcaZAwjJIGBU2QvO5vU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714673083; c=relaxed/simple; bh=5/V5S7wrzoPy8oKMzOoDT2O7s5J/iVanuW6/BCcg29I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QZGvsVxo1Y9L0vgXQLnODDVy5xHjnSYhnsNFJLegw1Gu16txCdckmVRN+axsd3tIxI6wfL/k6N4iafrdhhfiHctgSiG+TN0XShk3S5KsViqzOkNl60Q7PvynGxcd41bfhcszNlLlXFVpny3SDvuCqFTzq5xWJ4Od6DWcnrJiZzs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=QqYTELYs; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1714673082; x=1746209082; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=5/V5S7wrzoPy8oKMzOoDT2O7s5J/iVanuW6/BCcg29I=; b=QqYTELYsoJ1SNO5HP7iKukJ9+HpQfmO3P+DT5N3ybFkLqCZd1ToHM9Zy vfqroK8TXGkIampZz0CEcK2dQBboBmbFhXoK9sKWWuxRcCVbphtmSiFKg 6R/Cf4CWLWkFaYhqFdrA/IvIZoUrDYgAzQJglHBAmoL1VJx3z47kBZoMH B7qZaGTyiKWUFJ8Vvo3oYLylq6UN0pUkJDCBhGZsYRlYeclSdYm++NKqe IPTJHZHqpCpBLQZc581NIkU9wMr4rfpv759BSA2+VRDUcTqOa0Tje2pdE xstIbN0i3nNElJE5C2HTYh2u993bfFB6Z6qauUcU6Vck0VE+csz64tZci Q==; X-CSE-ConnectionGUID: rcMnLXLATQqqpX0W3MGiaw== X-CSE-MsgGUID: mvoHL0JlTcmJOIBgpTlntQ== X-IronPort-AV: E=McAfee;i="6600,9927,11062"; a="10392507" X-IronPort-AV: E=Sophos;i="6.07,247,1708416000"; d="scan'208";a="10392507" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 May 2024 11:04:41 -0700 X-CSE-ConnectionGUID: ZE+KgaoXRZKNW+PlDxac9w== X-CSE-MsgGUID: f+h2FOWAShiH0+3Od4MrAQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,247,1708416000"; d="scan'208";a="27179982" Received: from smile.fi.intel.com ([10.237.72.54]) by fmviesa009.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 May 2024 11:04:38 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1s2anL-00000003PQx-32bI; Thu, 02 May 2024 21:04:35 +0300 Date: Thu, 2 May 2024 21:04:35 +0300 From: Andy Shevchenko To: Javier Carrasco , Jonathan Cameron Cc: Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] device property: introduce fwnode_for_each_child_node_scoped() Message-ID: References: <20240502-fwnode_for_each_child_node_scoped-v1-1-868a2b168fa8@wolfvision.net> <6b5571e0-1463-4dd9-9bd8-459d456a6932@wolfvision.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Thu, May 02, 2024 at 09:03:09PM +0300, Andy Shevchenko wrote: > On Thu, May 02, 2024 at 07:58:26PM +0200, Javier Carrasco wrote: > > On 5/2/24 17:34, Andy Shevchenko wrote: > > > On Thu, May 02, 2024 at 12:55:40PM +0200, Javier Carrasco wrote: .. > > >> This macro has been tested with a patch series that has not been > > >> applied yet and is under discussion in input [1], which makes use of the > > >> non-scoped version of the loop. > > > > > > So, why should we apply a dead code? > > > > I will add this patch to the series I mentioned, so there is a first use > > case. > > Sounds like a good plan. Ah, note that IIO has already some patches against device property APIs. Maybe it's already done by Jonathan. Cc'ed to him. > > Even if the _available variant is preferred, the other one is more > > widely used, and having a scoped version will allow for safer code. -- With Best Regards, Andy Shevchenko