Received-SPF: pass (google.com: domain of linux-kernel+bounces-166836-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 2 May 2024 11:29:23 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: PJ Waskiewicz <ppwaskie@kernel.org>, Dan Williams
	<dan.j.williams@intel.com>, Bjorn Helgaas <helgaas@kernel.org>
CC: <linux-cxl@vger.kernel.org>, <linux-pci@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] cxl/acpi.c: Add buggy BIOS hint for CXL ACPI lookup
 failure
Message-ID: <6633db83a13f1_1384629429@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <ce49c67c24f57ffab166d688a1c9e3139733f412.camel@kernel.org>
 <20240429153138.GA681245@bhelgaas>
 <662fe860eb889_1487294e8@dwillia2-mobl3.amr.corp.intel.com.notmuch>
 <f5078550384a6b9be5a6d05415ea321332c7fb96.camel@kernel.org>
 <6632640bef65a_10c21294e3@dwillia2-mobl3.amr.corp.intel.com.notmuch>
 <6af0488a5d845028978f57e63f3706f8899465cf.camel@kernel.org>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <6af0488a5d845028978f57e63f3706f8899465cf.camel@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?VT0bb/WJ3oo63hh23NwFJpn6qeTz4BWYDocUJmqwtSXY1D/CoJzHa4av/z?=
 =?iso-8859-1?Q?cueHm24A9xWgNoZyai6XGmnn3FmPGONQR/WkgKFbe9Cx1lsEKLuJoqoha3?=
 =?iso-8859-1?Q?6qq8jFbb4I/jQVFpxGRwJ6lfoyc2moBgQ8x8pDkgmfHp10ebVAO4oev3y9?=
 =?iso-8859-1?Q?2e1P6TBi4v/bPcQHRvtQfaVHYfUG/j5KQmI3NPo7VSKS/x34pm4HX8LFnk?=
 =?iso-8859-1?Q?gPiwC5XXb9/oX7ldKIrByfLQYTsiPx1UUu2cCSZqfKS6S+2ck2lCchkSHe?=
 =?iso-8859-1?Q?8DXubxOAfnmPWzQqBfiQBtYfPTuwhj8Bwcb/IKKOmeGuMDmL2dYozuJMi9?=
 =?iso-8859-1?Q?iIQ5Br3WOZ8knQk3hd/QUpMoVtGDEfZyLgE65D58T/aY1DOfY6Yh9JMF1A?=
 =?iso-8859-1?Q?FK++fPG7KIxdb91JRKYOHGEcnt+4igGJw7HpkVZC7w5TAMFZyiq+z1Rr7y?=
 =?iso-8859-1?Q?kMjOf1Azpwkn3mG90XhZfiUAbGlGLtiaLOA5eTWgBMVOoAiDT2frL9veHV?=
 =?iso-8859-1?Q?Z3jKNCDMxknxC3x7+h7rZQ1c8Vps+FwhYRYd6CKB+9O/zg9oBlwujQMakE?=
 =?iso-8859-1?Q?2WlBcb3oGc6QHWg2zbLctA5WqSmWtCab8+qbRV3UTfvNAYhEcEEiHdyFxO?=
 =?iso-8859-1?Q?cynGJgSKTxEhlx4whZYTjLe943T0Vt0sMwasMsilixrPLuWOePlDLJ4Ra+?=
 =?iso-8859-1?Q?4f4IMTtjNA7dZMBbpwaM5ZKtLBWATx1uTC1nTG6JDnju3eFnU64IyPLJWt?=
 =?iso-8859-1?Q?xrdmLt9GKpAKDeDG9cdNxxgbAPoWlKqfdj9F/VIMD+ProgQMOWiGUrBlIi?=
 =?iso-8859-1?Q?XLsplcG708BLnya9ju2Q994xG9HJKUq7wBQlaPFbVsO2lcUo3Feafzuufd?=
 =?iso-8859-1?Q?Qh4uBJ4eSoIGCjZ8BUWiuzaJb6JVHdtzqreX1Ot3/7COLuv/46De3Gi768?=
 =?iso-8859-1?Q?dDbmRRbQpvBSEJm82FPp9VdFHbmzzW/8aguR5ABCHM0Y5USPVuM6pfE/QI?=
 =?iso-8859-1?Q?xRZfXBa5YUyjbSaH7RjY75m0scEiZZt9If+pHrmTlotYcy5Hh4Af91W0r+?=
 =?iso-8859-1?Q?e1p7wXleW7Y7wv1dqiPN/Tyan+0ADRHoKEVVhrVP7cacf2GTHUGCo6gNTL?=
 =?iso-8859-1?Q?iUkVONQNn8Esmp3qs65p6bx1Or78xHCFKdaBbvnmmW4/fCQAQYRhvMu7IE?=
 =?iso-8859-1?Q?3lWX0YHfNzqD1eS+Pmi7FDwQeN1OBRgmpEFuQywYDSK0gXfqQYD4WcANLe?=
 =?iso-8859-1?Q?oQW6yGzdTbgu5Lg10MNViBExKxjoJLlX8s46i0IqVGu9wBoHb8dO6VwQ33?=
 =?iso-8859-1?Q?F/qjGhteL3qBcVaAT1Sb44sno++SE//k6ePXjkhsOSWv/1i4+qlThVy4rB?=
 =?iso-8859-1?Q?pKZRCuK77DusLFzxHg28GFph47wUfKYFIrsWne8LkRg8c50CabdCa1nSE6?=
 =?iso-8859-1?Q?5BbTfOxmRoE+BurNf5dK62eo5aBdHdNcw32mI5o28sIVGfF/I57RWsZ1/t?=
 =?iso-8859-1?Q?Nj8utDqJt+by8dH35nFjWETBmTu3vBZFWRRaF4asmWodLgtphx+Wg9ZsDn?=
 =?iso-8859-1?Q?N3drjdWiS2maCatxg3BWqkHuT8HT4cYCmslpVclPM6nLyuK+iVJDMacUEK?=
 =?iso-8859-1?Q?hyA6ThPwULpWFM2N+jyrhIoxa/nd1ookxEJyBPfkSkAznhNCQZlJI5dg?=
 =?iso-8859-1?Q?=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fc65c641-6669-4bff-e2e9-08dc6ad5cb9b
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2024 18:29:25.7365
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iCwYD6r2T7gRyEbGCbQjqq7J2cRCiolj8WsJsU7iXjK8dHvZDnNKXU75s4PT0h0RmDf+DdCeEnpexvp1T92NT1x93BaDVl0JaLkwgQt0B8I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7538
X-OriginatorOrg: intel.com

PJ Waskiewicz wrote:
> On Wed, 2024-05-01 at 08:47 -0700, Dan Williams wrote:
> > PJ Waskiewicz wrote:
> > > Buggy BIOS, that above value resolves to CX02.? In fact, it
> > > *should* be
> > > 49.? This is very much a bug in the ACPI arena.
> > 
> > Ok, so back to this patch in question, my concern with upgrading:
> > 
> > ??? dev_err(dev, "unable to retrieve _UID\n");
> > 
> > ...to say "potentially buggy BIOS", is that same charge could be
> > levied
> > against all of the dev_warn() and dev_err() instances in
> > drivers/cxl/acpi.c. So, it's not clear to me that cxl_acpi driver
> > failures need to be more explicit.
> > 
> > Otherwise, pretty much any ACPI hiccup message in the kernel would be
> > candidate for claiming "BIOS is busted".
> 
> I really do like your patch you proposed a few weeks back.  I'm happy
> to pull that and test it if you'd like to move forward on that instead.

All that one did is annotate all cxl_acpi driver error messages with
"FW_BUG", if that's useful then yeah that patch [1] can be considered.

[1]: http://lore.kernel.org/r/6614575a1c15c_2583ad29476@dwillia2-xfh.jf.intel.com.notmuch