Received-SPF: pass (google.com: domain of linux-kernel+bounces-166911-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= <bjorn@kernel.org>
To: Jean-Philippe Brucker <jean-philippe@linaro.org>
Cc: Jiri Olsa <olsajiri@gmail.com>, Arnaldo Carvalho de Melo
 <acme@redhat.com>, linux-kernel@vger.kernel.org, =?utf-8?B?QmrDtnJuIFQ=?=
 =?utf-8?B?w7ZwZWw=?=
 <bjorn@rivosinc.com>, Nathan Chancellor <nathan@kernel.org>, Nick
 Desaulniers <ndesaulniers@google.com>, Tom Rix <trix@redhat.com>,
 bpf@vger.kernel.org, Anders Roxell <anders.roxell@linaro.org>,
 llvm@lists.linux.dev
Subject: Re: [PATCH v2] tools/build: Add clang cross-compilation flags to
 feature detection
In-Reply-To: <20240429171145.GA241057@myrica>
References: <20231102103252.247147-1-bjorn@kernel.org>
 <ZUOWcXDpCOzxbFW0@krava> <87o79wxvnu.fsf@all.your.base.are.belong.to.us>
 <20240429171145.GA241057@myrica>
Date: Thu, 02 May 2024 23:07:01 +0200
Message-ID: <87a5l7x6ru.fsf@all.your.base.are.belong.to.us>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Jean-Philippe Brucker <jean-philippe@linaro.org> writes:

> On Fri, Apr 26, 2024 at 12:31:17PM +0200, Bj=C3=B6rn T=C3=B6pel wrote:
>> Jiri Olsa <olsajiri@gmail.com> writes:
>>=20
>> > On Thu, Nov 02, 2023 at 11:32:52AM +0100, Bj=C3=B6rn T=C3=B6pel wrote:
>> >> From: Bj=C3=B6rn T=C3=B6pel <bjorn@rivosinc.com>
>> >>=20
>> >> When a tool cross-build has LLVM=3D1 set, the clang cross-compilation
>> >> flags are not passed to the feature detection build system. This
>> >> results in the host's features are detected instead of the targets.
>> >>=20
>> >> E.g, triggering a cross-build of bpftool:
>> >>=20
>> >>   cd tools/bpf/bpftool
>> >>   make ARCH=3Driscv CROSS_COMPILE=3Driscv64-linux-gnu- LLVM=3D1
>> >>=20
>> >> would report the host's, and not the target's features.
>> >>=20
>> >> Correct the issue by passing the CLANG_CROSS_FLAGS variable to the
>> >> feature detection makefile.
>> >>=20
>> >> Fixes: cebdb7374577 ("tools: Help cross-building with clang")
>> >> Signed-off-by: Bj=C3=B6rn T=C3=B6pel <bjorn@rivosinc.com>
>> >
>> > Acked-by: Jiri Olsa <jolsa@kernel.org>
>>=20
>> Waking up the dead!
>>=20
>> Arnaldo, Jean-Philippe: I'm still stung by what this patch fixes. LMK
>> what you need from me/this patch to pick it up.
>
> I guess the problem is these files don't have a specific tree. Since you
> mention BPF maybe it should go through the BPF tree, in which case you
> could resend to the tools/bpf maintainers (and "PATCH bpf" subject prefix)
>
> FWIW the change looks good to me:
>
> Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org>

Thanks for the review. Yes, maybe it's a orphan files issue! It does
seem a bit weird to route it via BPF, since it's just a regular
cross-build fix -- Not directly related to BPF. Regardless; I'll do a
respin targetted at *some* tree. ;-)


Bj=C3=B6rn