Received-SPF: pass (google.com: domain of linux-kernel+bounces-166992-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <0628b0141236db57156d744727df0c48.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <ZjN0NkYifXY0OsZt@shell.armlinux.org.uk>
References: <E1rl62V-004UFh-Te@rmk-PC.armlinux.org.uk> <e15b8a1165a5437ab1fa868ccd0b629c.sboyd@kernel.org> <560549ed7db5da2f2727dc053a5d196d.sboyd@kernel.org> <ZjNIiDeXIjXhJlT4@shell.armlinux.org.uk> <ZjNNT+KBNpQL+U3b@shell.armlinux.org.uk> <ZjN0NkYifXY0OsZt@shell.armlinux.org.uk>
Subject: Re: [PATCH] clkdev: report over-sized strings when creating clkdev entries
From: Stephen Boyd <sboyd@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, Duanqiang Wen <duanqiangwen@net-swift.com>, mturquette@baylibre.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
To: Russell King (Oracle) <linux@armlinux.org.uk>
Date: Thu, 02 May 2024 15:18:02 -0700
User-Agent: alot/0.10

Quoting Russell King (Oracle) (2024-05-02 04:08:38)
> On Thu, May 02, 2024 at 09:22:39AM +0100, Russell King (Oracle) wrote:
> > On Thu, May 02, 2024 at 09:02:16AM +0100, Russell King (Oracle) wrote:
> > > On Wed, May 01, 2024 at 06:02:54PM -0700, Stephen Boyd wrote:
> > > > Quoting Stephen Boyd (2024-05-01 17:59:16)
> > > > > Quoting Russell King (Oracle) (2024-03-15 04:47:55)
> > > > > > Report an error when an attempt to register a clkdev entry resu=
lts in a
> > > > > > truncated string so the problem can be easily spotted.
> > > > > >=20
> > > > > > Reported by: Duanqiang Wen <duanqiangwen@net-swift.com>
> > > > > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.u=
k>
> > > > > > ---
> > > > >=20
> > > > > Applied to clk-next
> > > > >=20
> > > >=20
> > > > And backed out because I get a compilation failure
> > > >=20
> > > > drivers/clk/clkdev.c: In function 'vclkdev_alloc':
> > > > drivers/clk/clkdev.c:182:17: error: function 'vclkdev_alloc' might =
be a candidate for 'gnu_printf' format attribute [-Werror=3Dsuggest-attribu=
te=3Dformat]
> > > >   182 |                 res =3D vsnprintf(cla->dev_id, sizeof(cla->=
dev_id), dev_fmt, ap);
> > > >       |                 ^~~
> > > > cc1: all warnings being treated as errors
> > > > make[5]: *** [scripts/Makefile.build:244: drivers/clk/clkdev.o] Err=
or 1
> > > > make[4]: *** [scripts/Makefile.build:485: drivers/clk] Error 2
> > >=20
> > > It builds fine for me. I don't get this _error_, and it's really no
> > > different from what it originally was - instead of using vcsnprintf()
> > > we're now using vsnprintf(). That should make no difference what so
> > > ever.
> >=20
> > ... and I've just checked, and it builds entirely cleanly for me.
> >=20
> > I'll merge it.
>=20
> It should be in tonight's linux-next tree.

Ok thanks

>=20
> I also note... the kernel build bot never flagged the above, not even
> a warning for it, and it would've built the patch as it was Cc'd to
> linux-kernel.

Indeed. I see a report here[1] but it's only a warning. And there was
some work a few years ago[2] that I forgot about. Seems there was a
possible fix[3] as well.

> So my conclusion is the error you are seeing is somehow
> specific to your environment. Maybe you're building with an additional
> set of warning flags and -Werror?
>=20

Yes I build with W=3D1 but I didn't think that turned warnings into
errors. Maybe that part is new.

[1] https://lore.kernel.org/all/202403110643.27JXEVCI-lkp@intel.com/
[2] https://lore.kernel.org/all/20210310085937.GF4931@dell/
[3] https://lore.kernel.org/all/20221111071809.3440-1-liubo03@inspur.com/